Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread David Faure
On March 4, 2014, 7:42 p.m., David Faure wrote: I don't get it. What's the problem with sending a mimetype for empty files? I would think this is actually expected - for all files, including empty ones. Why does this fix the bug? Dawit Alemayehu wrote: It fails and ends up

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread Dawit Alemayehu
On March 4, 2014, 7:42 p.m., David Faure wrote: I don't get it. What's the problem with sending a mimetype for empty files? I would think this is actually expected - for all files, including empty ones. Why does this fix the bug? Dawit Alemayehu wrote: It fails and ends up

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread David Faure
On March 4, 2014, 7:42 p.m., David Faure wrote: I don't get it. What's the problem with sending a mimetype for empty files? I would think this is actually expected - for all files, including empty ones. Why does this fix the bug? Dawit Alemayehu wrote: It fails and ends up

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116523/ --- (Updated March 12, 2014, 11:35 a.m.) Review request for kdelibs and

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116523/ --- (Updated March 12, 2014, 11:39 a.m.) Review request for kdelibs and

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116523/ --- (Updated March 12, 2014, 12:47 p.m.) Review request for kdelibs and

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116523/#review52743 --- kioslave/ftp/ftp.cpp

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116523/ --- (Updated March 12, 2014, 1:26 p.m.) Review request for kdelibs and David

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116523/#review52761 --- Ship it! Thanks. I hope we don't get into the case of

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread Dawit Alemayehu
On March 12, 2014, 2:39 p.m., David Faure wrote: Thanks. I hope we don't get into the case of Unknown Size when the size is actually 0, though. That case would still be buggy, and I'm not sure how we could fix it. Well I could think of one scenario where that could potentially

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116523/ --- (Updated March 13, 2014, 5:05 a.m.) Status -- This change has been

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116523/#review52862 --- This review has been submitted with commit

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-11 Thread Dawit Alemayehu
On March 4, 2014, 7:42 p.m., David Faure wrote: I don't get it. What's the problem with sending a mimetype for empty files? I would think this is actually expected - for all files, including empty ones. Why does this fix the bug? Dawit Alemayehu wrote: It fails and ends up

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-05 Thread Dawit Alemayehu
On March 4, 2014, 7:42 p.m., David Faure wrote: I don't get it. What's the problem with sending a mimetype for empty files? I would think this is actually expected - for all files, including empty ones. Why does this fix the bug? It fails and ends up sending an error message. See the

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116523/#review51922 --- I don't get it. What's the problem with sending a mimetype