Re: Review Request 127102: Use fixed width for digital clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127102/#review93603 --- Ship it! Ship It! - Martin Klapetek On March 16, 2016,

Re: Review Request 127102: Use fixed width for digital clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127102/ --- (Updated March 16, 2016, 3:56 p.m.) Status -- This change has been

Re: Review Request 127102: Use fixed width for digital clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127102/ --- (Updated März 16, 2016, 4:35 nachm.) Review request for kde-workspace

Re: Review Request 127102: Use fixed width for digital clock applet

> On März 15, 2016, 5:48 nachm., Martin Klapetek wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, lines 565-568 > > > > > > Can't we just compare "A" and "P" width's and use that? Would

Re: Review Request 127102: Use fixed width for digital clock applet

> On March 15, 2016, 5:48 p.m., Martin Klapetek wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, lines 565-568 > > > > > > Can't we just compare "A" and "P" width's and use that? Would

Re: Review Request 127102: Use fixed width for digital clock applet

> On March 15, 2016, 5:48 p.m., Martin Klapetek wrote: > > I've tested it extensively and it works great. Thanks a lot! > > > > There's one more issue - http://paste.opensuse.org/view/raw/f8ba5d0d - the > > same font size should also be applied to the left date label (there are; > > the

Re: Review Request 127102: Use fixed width for digital clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127102/#review93561 --- I've tested it extensively and it works great. Thanks a lot!

Re: Review Request 127102: Use fixed width for digital clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127102/ --- (Updated März 8, 2016, 6:53 nachm.) Review request for kde-workspace and

Re: Review Request 127102: Use fixed width for digital clock applet

> On Feb. 18, 2016, 1:05 vorm., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 555 > > > > > > rather than looping, can we use FontMetric's maximumCharacterWidth > >

Re: Review Request 127102: Use fixed width for digital clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127102/ --- (Updated Feb. 19, 2016, 6:11 nachm.) Review request for kde-workspace

Re: Review Request 127102: Use fixed width for digital clock applet

> On Feb. 18, 2016, 12:05 a.m., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 555 > > > > > > rather than looping, can we use FontMetric's maximumCharacterWidth > >

Re: Review Request 127102: Use fixed width for digital clock applet

> On Feb. 18, 2016, 1:05 vorm., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 555 > > > > > > rather than looping, can we use FontMetric's maximumCharacterWidth > >

Re: Review Request 127102: Use fixed width for digital clock applet

> On Feb. 18, 2016, 1:05 vorm., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 555 > > > > > > rather than looping, can we use FontMetric's maximumCharacterWidth > >

Re: Review Request 127102: Use fixed width for digital clock applet

> On Feb. 18, 2016, 12:05 a.m., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 555 > > > > > > rather than looping, can we use FontMetric's maximumCharacterWidth > >

Re: Review Request 127102: Use fixed width for digital clock applet

> On Feb. 18, 2016, 1:05 vorm., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 555 > > > > > > rather than looping, can we use FontMetric's maximumCharacterWidth > >

Re: Review Request 127102: Use fixed width for digital clock applet

> On Feb. 18, 2016, 1:05 a.m., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 555 > > > > > > rather than looping, can we use FontMetric's maximumCharacterWidth > >

Re: Review Request 127102: Use fixed width for digital clock applet

> On Feb. 18, 2016, 1:05 vorm., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 555 > > > > > > rather than looping, can we use FontMetric's maximumCharacterWidth > >

Re: Review Request 127102: Use fixed width for digital clock applet

> On Feb. 18, 2016, 1:05 a.m., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 555 > > > > > > rather than looping, can we use FontMetric's maximumCharacterWidth > >

Re: Review Request 127102: Use fixed width for digital clock applet

> On Feb. 18, 2016, 1:05 vorm., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 555 > > > > > > rather than looping, can we use FontMetric's maximumCharacterWidth > >

Re: Review Request 127102: Use fixed width for digital clock applet

> On Feb. 18, 2016, 12:05 a.m., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 555 > > > > > > rather than looping, can we use FontMetric's maximumCharacterWidth > >

Re: Review Request 127102: Use fixed width for digital clock applet

> On Feb. 17, 2016, 11:59 p.m., David Edmundson wrote: > > Is this needed after: https://git.reviewboard.kde.org/r/127073/ ? probably - Marco --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 127102: Use fixed width for digital clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127102/#review92514 --- applets/digital-clock/package/contents/ui/DigitalClock.qml

Re: Review Request 127102: Use fixed width for digital clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127102/#review92513 --- Is this needed after: