Re: Skanpage moved to kdereview

2021-08-17 Thread Harald Sitter
On Wed, Aug 11, 2021 at 9:46 PM Alexander Stippich wrote: > > - getUnitString -> can that maybe use > > https://api.kde.org/frameworks/kcoreaddons/html/classKFormat.html > > What do you have in mind here? getUnitString just matches the enum of libksane > to a unit suffix string, it does not

Re: Skanpage moved to kdereview

2021-08-11 Thread Alexander Stippich
On Montag, 9. August 2021 17:34:52 CEST Harald Sitter wrote: > it works amazingly well. good job! I mostly only have some nitpicky stuff > Thanks! > - since the code base is really close to > complete reuse coverage, it might be nice to push it over the finishing > line and then `reuse lint` it

Re: Skanpage moved to kdereview

2021-08-11 Thread Alexander Stippich
On Sonntag, 8. August 2021 23:12:11 CEST Albert Astals Cid wrote: > El diumenge, 8 d’agost de 2021, a les 18:50:17 (CEST), Alexander Stippich va escriure: > > Hello everyone, > > > > Skanpage is now in kdereview. > > Skanpage is a scanning application and originally a concept from Kåre Särs > >

Re: Skanpage moved to kdereview

2021-08-09 Thread Albert Astals Cid
El dilluns, 9 d’agost de 2021, a les 17:34:52 (CEST), Harald Sitter va escriure: > it works amazingly well. good job! I mostly only have some nitpicky stuff > > - since the code base is really close to > complete reuse coverage, it might be nice to push it over the finishing > line and then

Re: Skanpage moved to kdereview

2021-08-09 Thread Harald Sitter
it works amazingly well. good job! I mostly only have some nitpicky stuff - since the code base is really close to complete reuse coverage, it might be nice to push it over the finishing line and then `reuse lint` it to not have it fall behind again - your cmake code is GPL but policy-wise it

Re: Skanpage moved to kdereview

2021-08-08 Thread Albert Astals Cid
El diumenge, 8 d’agost de 2021, a les 18:50:17 (CEST), Alexander Stippich va escriure: > Hello everyone, > > Skanpage is now in kdereview. > Skanpage is a scanning application and originally a concept from Kåre Särs > from approx. 5 years ago. I started to work on it late last year and now >