Re: Re: Re: other_stuff.h | [was: Review Request for KDecoration]

2014-11-12 Thread Martin Gräßlin
Martin GräßlinOn Tuesday 11 November 2014 17:53:53 wrote: On Tuesday 11 November 2014 17:48:58 Thomas Lübking wrote: On Dienstag, 11. November 2014 17:06:53 CEST, Martin Gräßlin wrote: In case you have better naming suggestions please let me know. ::geometry(Qt::WindowFrameSection

Re: other_stuff.h | [was: Review Request for KDecoration]

2014-11-11 Thread Martin Gräßlin
On Thursday 06 November 2014 15:14:52 Thomas Lübking wrote: decorationdefines.h, decorationsettings.h - BorderSize - do we *really* want to keep this or rather allow pixel/pointwise configuration of 2,3, or 4 border sizes globally? could you please

Re: other_stuff.h | [was: Review Request for KDecoration]

2014-11-11 Thread Martin Gräßlin
On Thursday 06 November 2014 15:14:52 Thomas Lübking wrote: decoratedclient.h -- maximal available - maximal possible Addressed in 389ff3b borderingScreenEdges - adjacentScreenEdges or touchedScreenEdges Renamed to adjacentScreenEdges: * kdecoration: f8d1147 *

Re: other_stuff.h | [was: Review Request for KDecoration]

2014-11-11 Thread Thomas Lübking
On Dienstag, 11. November 2014 14:43:56 CEST, Martin Gräßlin wrote: BorderSize - do we *really* want to keep this or rather allow pixel/pointwise configuration of 2,3, or 4 border sizes globally? could you please explain your alternative approach? I'm kind of not getting it and yes I'm also

Re: other_stuff.h | [was: Review Request for KDecoration]

2014-11-11 Thread Martin Gräßlin
On Thursday 06 November 2014 15:14:52 Thomas Lübking wrote: decorationshadow.h -- QSize topLeft() etc. etc.: a) shadow-topLeft() does not sound like a size b) the entire information (9 tiles) can also be provided by two rects (innerRect, outerRect) c) with a conv. func. just

Re: Re: other_stuff.h | [was: Review Request for KDecoration]

2014-11-11 Thread Martin Gräßlin
On Tuesday 11 November 2014 17:00:24 Thomas Lübking wrote: On Dienstag, 11. November 2014 14:43:56 CEST, Martin Gräßlin wrote: BorderSize - do we *really* want to keep this or rather allow pixel/pointwise configuration of 2,3, or 4 border sizes globally? could you please explain your

Re: other_stuff.h | [was: Review Request for KDecoration]

2014-11-11 Thread Thomas Lübking
On Dienstag, 11. November 2014 17:06:53 CEST, Martin Gräßlin wrote: In case you have better naming suggestions please let me know. ::geometry(Qt::WindowFrameSection tile) ? If you need parameterless accessors, i'd just add a geometry ::topLeftGeometry() Cheers, Thomas

Re: Re: other_stuff.h | [was: Review Request for KDecoration]

2014-11-11 Thread Martin Gräßlin
On Tuesday 11 November 2014 17:48:58 Thomas Lübking wrote: On Dienstag, 11. November 2014 17:06:53 CEST, Martin Gräßlin wrote: In case you have better naming suggestions please let me know. ::geometry(Qt::WindowFrameSection tile) ? If you need parameterless accessors, i'd just add a

Re: other_stuff.h | [was: Review Request for KDecoration]

2014-11-06 Thread Martin Gräßlin
On Thursday 06 November 2014 15:14:52 Thomas Lübking wrote: decoratedclient.h -- maximal available - maximal possible borderingScreenEdges - adjacentScreenEdges or touchedScreenEdges additional request: void monitorProperty(const QString prop, bool onoff); signals: void

Re: other_stuff.h | [was: Review Request for KDecoration]

2014-11-06 Thread Thomas Lübking
On Donnerstag, 6. November 2014 15:20:25 CEST, Martin Gräßlin wrote: property means X11 property? In that case: good suggestion and clearly useful. generic - I could assume it would work on wayland as well? But X11 property itfp, yes. Cheers, Thomas