Re: Review Request: Add Activity Awareness to KFilePlaces* Widget (OnlyInActivity)

2012-10-02 Thread David Faure
On Oct. 25, 2011, 10:05 a.m., Kai Uwe Broulik wrote: Is there any progress on this? I’d propose you enhance the feature to make the individual activities selectable, i.e. you can choose in which particular activities an entry should appear, similar to KWin’s Activity menu in the

Re: Review Request: Add Activity Awareness to KFilePlaces* Widget (OnlyInActivity)

2012-10-02 Thread Stephen Kelly
David Faure wrote: If we (=someone) make a frameworks branch for kactivities, it should be quite simple to port that away from kdecore (I suppose it was mostly using KPluginLoader, which has now moved to the kservice framework). So this might just be a matter of updating a few CMakeLists.txt

Re: Review Request: Add Activity Awareness to KFilePlaces* Widget (OnlyInActivity)

2012-10-02 Thread Aaron J. Seigo
On Oct. 25, 2011, 10:05 a.m., Kai Uwe Broulik wrote: Is there any progress on this? I’d propose you enhance the feature to make the individual activities selectable, i.e. you can choose in which particular activities an entry should appear, similar to KWin’s Activity menu in the

Re: Review Request: Add Activity Awareness to KFilePlaces* Widget (OnlyInActivity)

2012-10-02 Thread Ivan Čukić
making a frameworks branch in the kactivities repo is fine. the library should indeed be easy to port. The core library currently uses only KDebug, i18nc and KUrl. The data models library, the service and the workspace addons use more stuff. So, the core library (that is meant to be used in

Porting KActivities to KF5 (Re: Review Request: Add Activity Awareness to KFilePlaces* Widget (OnlyInActivity))

2012-10-02 Thread David Faure
On Tuesday 02 October 2012 19:47:31 Ivan Čukić wrote: making a frameworks branch in the kactivities repo is fine. the library should indeed be easy to port. The core library currently uses only KDebug, i18nc and KUrl. - qDebug, QUrl, and either tr or the ki18n framework, depending on the

Re: Porting KActivities to KF5 (Re: Review Request: Add Activity Awareness to KFilePlaces* Widget (OnlyInActivity))

2012-10-02 Thread Ivan Čukić
In short, the whole libs / runtime split idea from KDE4, is gone in KF5, replaced with the more modular here is all you need for technology xyz. I know. That is the reason why I decided to keep it in one repository in the first place - to have it as close as possible to the layout it will

Re: Review Request: Add Activity Awareness to KFilePlaces* Widget (OnlyInActivity)

2011-10-27 Thread Jeffery MacEachern
On Oct. 25, 2011, 10:05 a.m., Kai Uwe Broulik wrote: Is there any progress on this? I’d propose you enhance the feature to make the individual activities selectable, i.e. you can choose in which particular activities an entry should appear, similar to KWin’s Activity menu in the

Re: Review Request: Add Activity Awareness to KFilePlaces* Widget (OnlyInActivity)

2011-10-26 Thread Aaron J. Seigo
On Oct. 25, 2011, 10:05 a.m., Kai Uwe Broulik wrote: Is there any progress on this? I’d propose you enhance the feature to make the individual activities selectable, i.e. you can choose in which particular activities an entry should appear, similar to KWin’s Activity menu in the

Re: Review Request: Add Activity Awareness to KFilePlaces* Widget (OnlyInActivity)

2011-10-25 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101348/#review7592 --- Is there any progress on this? I’d propose you enhance the

Re: Review Request: Add Activity Awareness to KFilePlaces* Widget (OnlyInActivity)

2011-08-09 Thread Jeffery MacEachern
On May 31, 2011, 9:24 p.m., Kevin Ottens wrote: Note that I can't really comment on the activities specific parts, Ivan would probably be a better reviewer for that parts. Anyway I found a couple of smaller issues which need fixing. The below have been fixed locally, but I haven't had

Re: Review Request: Add Activity Awareness to KFilePlaces* Widget (OnlyInActivity)

2011-05-31 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101348/#review3605 --- Note that I can't really comment on the activities specific

Review Request: Add Activity Awareness to KFilePlaces* Widget (OnlyInActivity)

2011-05-13 Thread Jeffery MacEachern
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101348/ --- Review request for kdelibs, Kevin Ottens and David Faure. Summary ---

Re: Review Request: Add Activity Awareness to KFilePlaces* Widget (OnlyInActivity)

2011-05-13 Thread Jeffery MacEachern
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101348/ --- (Updated May 13, 2011, 2:26 a.m.) Review request for kdelibs, Kevin

Re: Review Request: Add Activity Awareness to KFilePlaces* Widget (OnlyInActivity)

2011-05-13 Thread Jeffery MacEachern
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101348/ --- (Updated May 13, 2011, 2:30 a.m.) Review request for kdelibs, Kevin