Re: Review Request: Changed KUrl::toLocalFile to use QUrl::path() instead QUrl::toLocalFile() on non-Windows platforms

2011-07-11 Thread Aaron J. Seigo
On July 10, 2011, 1:20 p.m., Ingo Klöcker wrote: This changes the behavior of toLocalFile() for non-local URLs. Instead of an empty string your version returns the (remote) path. I'm not sure how relevant this is because it makes little sense to call toLocalFile() on non-local URLs.

Re: Review Request: Changed KUrl::toLocalFile to use QUrl::path() instead QUrl::toLocalFile() on non-Windows platforms

2011-07-10 Thread Ingo Klöcker
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101906/#review4572 --- This changes the behavior of toLocalFile() for non-local URLs.

Re: Review Request: Changed KUrl::toLocalFile to use QUrl::path() instead QUrl::toLocalFile() on non-Windows platforms

2011-07-10 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101906/ --- (Updated July 10, 2011, 3:34 p.m.) Review request for kdelibs and David

Re: Review Request: Changed KUrl::toLocalFile to use QUrl::path() instead QUrl::toLocalFile() on non-Windows platforms

2011-07-10 Thread Dawit Alemayehu
On July 10, 2011, 1:20 p.m., Ingo Klöcker wrote: This changes the behavior of toLocalFile() for non-local URLs. Instead of an empty string your version returns the (remote) path. I'm not sure how relevant this is because it makes little sense to call toLocalFile() on non-local URLs.