Re: Review Request: Don't hang when determining MIME type of corrupted files

2011-10-19 Thread David Faure
> On Aug. 21, 2011, 10:07 a.m., David Faure wrote: > > Thanks Peter and Miroslav. The analysis looks correct, the pre-read part of > > the patch looks good. I'm just wondering about using Unbuffered. If someone > > installs a mimetype definition with multiple rules trying to match some > > byt

Re: Review Request: Don't hang when determining MIME type of corrupted files

2011-10-19 Thread Miroslav Ľos
> On Aug. 21, 2011, 10:07 a.m., David Faure wrote: > > Thanks Peter and Miroslav. The analysis looks correct, the pre-read part of > > the patch looks good. I'm just wondering about using Unbuffered. If someone > > installs a mimetype definition with multiple rules trying to match some > > byt

Re: Review Request: Don't hang when determining MIME type of corrupted files

2011-10-09 Thread David Faure
> On Aug. 21, 2011, 10:07 a.m., David Faure wrote: > > Thanks Peter and Miroslav. The analysis looks correct, the pre-read part of > > the patch looks good. I'm just wondering about using Unbuffered. If someone > > installs a mimetype definition with multiple rules trying to match some > > byt

Re: Review Request: Don't hang when determining MIME type of corrupted files

2011-09-18 Thread Miroslav Ľos
> On Aug. 21, 2011, 10:07 a.m., David Faure wrote: > > Thanks Peter and Miroslav. The analysis looks correct, the pre-read part of > > the patch looks good. I'm just wondering about using Unbuffered. If someone > > installs a mimetype definition with multiple rules trying to match some > > byt

Re: Review Request: Don't hang when determining MIME type of corrupted files

2011-09-17 Thread Christoph Feck
> On Aug. 21, 2011, 10:07 a.m., David Faure wrote: > > Thanks Peter and Miroslav. The analysis looks correct, the pre-read part of > > the patch looks good. I'm just wondering about using Unbuffered. If someone > > installs a mimetype definition with multiple rules trying to match some > > byt

Re: Review Request: Don't hang when determining MIME type of corrupted files

2011-09-02 Thread David Faure
> On Aug. 21, 2011, 10:07 a.m., David Faure wrote: > > Thanks Peter and Miroslav. The analysis looks correct, the pre-read part of > > the patch looks good. I'm just wondering about using Unbuffered. If someone > > installs a mimetype definition with multiple rules trying to match some > > byt

Re: Review Request: Don't hang when determining MIME type of corrupted files

2011-08-25 Thread David Faure
On Monday 22 August 2011 20:12:13 Miroslav Ľos wrote: > > On Aug. 21, 2011, 10:07 a.m., David Faure wrote: > > > Thanks Peter and Miroslav. The analysis looks correct, the pre-read part > > > of the patch looks good. I'm just wondering about using Unbuffered. If > > > someone installs a mimetype de

Re: Review Request: Don't hang when determining MIME type of corrupted files

2011-08-22 Thread Miroslav Ľos
> On Aug. 21, 2011, 10:07 a.m., David Faure wrote: > > Thanks Peter and Miroslav. The analysis looks correct, the pre-read part of > > the patch looks good. I'm just wondering about using Unbuffered. If someone > > installs a mimetype definition with multiple rules trying to match some > > byt

Re: Review Request: Don't hang when determining MIME type of corrupted files

2011-08-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102391/#review5872 --- Thanks Peter and Miroslav. The analysis looks correct, the pre-r

Review Request: Don't hang when determining MIME type of corrupted files

2011-08-20 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102391/ --- Review request for kdelibs and David Faure. Summary --- If KMimeTypeR