Review Request 101486 (Q/KComboBox related KConfigDialogManager change) breaks apps

2011-11-30 Thread Andreas Pakulat
Hi, just came around to notice this now, but the mentioned code-change from the review request: https://git.reviewboard.kde.org/r/101486/ actually does break apps. In particular it breaks kdevelop. We have a KComboBox subclass which actually wants to store a custom string-property into the

Re: Review Request 101486 (Q/KComboBox related KConfigDialogManager change) breaks apps

2011-11-30 Thread Christoph Feck
On Wednesday 30 November 2011 21:50:41 Andreas Pakulat wrote: Hi, just came around to notice this now, but the mentioned code-change from the review request: https://git.reviewboard.kde.org/r/101486/ actually does break apps. In particular it breaks kdevelop. We have a KComboBox subclass

Re: Review Request 101486 (Q/KComboBox related KConfigDialogManager change) breaks apps

2011-11-30 Thread Andreas Pakulat
On 30.11.11 22:06:12, Christoph Feck wrote: On Wednesday 30 November 2011 21:50:41 Andreas Pakulat wrote: Since nonetheless there's the case of breaking existing apps with this change, I'd like to check other peoples opinions on adding some more logic to the kconfigdialogmanager's code so