Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog

2013-03-24 Thread Laurent Montel
On March 22, 2013, 5:38 p.m., Laurent Montel wrote: For me seems good. Regards Sven Brauch wrote: Sorry to annoy you again ;) just to make sure, I'd push this to kdelibs master now, ok? I hope nobody will mind the increase in the required attica version... yes in master.

Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog

2013-03-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/#review29797 --- This review has been submitted with commit

Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog

2013-03-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/ --- (Updated March 24, 2013, 12:55 p.m.) Status -- This change has been

Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog

2013-03-24 Thread Sven Brauch
On March 22, 2013, 5:38 p.m., Laurent Montel wrote: For me seems good. Regards Sorry to annoy you again ;) just to make sure, I'd push this to kdelibs master now, ok? I hope nobody will mind the increase in the required attica version... - Sven

Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog

2013-03-23 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/ --- (Updated March 22, 2013, 11:31 a.m.) Review request for Attica, kdelibs

Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog

2013-03-22 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/#review29670 --- You need to increase attic - Laurent Montel On March 18,

Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog

2013-03-22 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/#review29671 --- You need to increase attica version and make kdelibs depends

Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog

2013-03-22 Thread Sven Brauch
On March 22, 2013, 6:20 a.m., Laurent Montel wrote: You need to increase attica version and make kdelibs depends against it. Otherwise it will not compile. We can't depends against git master version, we must have a official release regards. Ah, yes. So, I would increase attica's

Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog

2013-03-22 Thread Laurent Montel
On March 22, 2013, 6:20 a.m., Laurent Montel wrote: You need to increase attica version and make kdelibs depends against it. Otherwise it will not compile. We can't depends against git master version, we must have a official release regards. Sven Brauch wrote: Ah, yes. So, I

Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog

2013-03-22 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/#review29732 --- For me seems good. Regards - Laurent Montel On March 22,

Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog

2013-03-21 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/#review29639 --- The patch to attica, which is needed by this, has been

Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog

2013-03-19 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/ --- Review request for Attica, kdelibs and Jeremy Paul Whiting. Description