Re: Review Request 112529: By default hide SMB shares that end with $

2013-09-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112529/ --- (Updated Sept. 9, 2013, 12:29 p.m.) Status -- This change has been

Re: Review Request 112529: By default hide SMB shares that end with $

2013-09-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112529/#review39640 --- This review has been submitted with commit

Re: Review Request 112529: By default hide SMB shares that end with $

2013-09-06 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112529/#review39456 --- kioslave/smb/kio_smb_browse.cpp

Re: Review Request 112529: By default hide SMB shares that end with $

2013-09-06 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112529/ --- (Updated Sept. 6, 2013, 12:35 p.m.) Review request for KDE Runtime.

Re: Review Request 112529: By default hide SMB shares that end with $

2013-09-06 Thread Dawit Alemayehu
On Sept. 6, 2013, 11:04 a.m., Mark Gaiser wrote: kioslave/smb/kio_smb_browse.cpp, lines 348-354 http://git.reviewboard.kde.org/r/112529/diff/1/?file=187202#file187202line348 This - while most was there already - seems odd to me. Your other code catches IPC$, ADMIN$, printer$ and

Re: Review Request 112529: By default hide SMB shares that end with $

2013-09-06 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112529/#review39461 --- kioslave/smb/kio_smb_browse.cpp

Re: Review Request 112529: By default hide SMB shares that end with $

2013-09-06 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112529/ --- (Updated Sept. 6, 2013, 1:04 p.m.) Review request for KDE Runtime.

Re: Review Request 112529: By default hide SMB shares that end with $

2013-09-06 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112529/#review39462 --- as far as i can judge it, it looks OK to me. Someone else

Re: Review Request 112529: By default hide SMB shares that end with $

2013-09-05 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112529/#review39399 --- There seems to be no patch attached - Kai Uwe Broulik On

Re: Review Request 112529: By default hide SMB shares that end with $

2013-09-05 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112529/ --- (Updated Sept. 5, 2013, 1:32 p.m.) Review request for KDE Runtime.

Review Request 112529: By default hide SMB shares that end with $

2013-09-04 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112529/ --- Review request for KDE Runtime. Description --- The attached patch