Re: Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}

2013-12-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114219/#review44926 --- Ship it! Yes, clearly correct. For your question about

Re: Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}

2013-12-01 Thread Yichao Yu
On Dec. 1, 2013, 3:47 a.m., David Faure wrote: Yes, clearly correct. For your question about branches: commit in the stable branch and merge upwards (or ask the module maintainers to merge upwards). Thank you for the review. I don't have a git account yet (will apply soon) so could

Re: Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}

2013-12-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114219/#review44972 --- This review has been submitted with commit

Re: Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}

2013-12-01 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114219/ --- (Updated Dec. 2, 2013, 7:27 a.m.) Status -- This change has been

Re: Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}

2013-11-30 Thread Martin Gräßlin
On Nov. 30, 2013, 1:45 a.m., Thomas Lübking wrote: kcontrol/krdb/krdb.cpp, line 102 http://git.reviewboard.kde.org/r/114219/diff/1/?file=221836#file221836line102 QFile::encodeName() seems equal to QString::toLocal8Bit(), ::decodeName() to ::fromLocal8Bit() I don't

Re: Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}

2013-11-30 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114219/ --- (Updated Nov. 30, 2013, 2:55 p.m.) Review request for kde-workspace,

Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}

2013-11-29 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114219/ --- Review request for kde-workspace, David Faure, Martin Gräßlin, and Hugo

Re: Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}

2013-11-29 Thread Yichao Yu
On Nov. 29, 2013, 7:45 p.m., Thomas Lübking wrote: kcontrol/krdb/krdb.cpp, line 102 http://git.reviewboard.kde.org/r/114219/diff/1/?file=221836#file221836line102 QFile::encodeName() seems equal to QString::toLocal8Bit(), ::decodeName() to ::fromLocal8Bit() I don't