Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField

2017-01-23 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114437/#review102234 --- Mr Leszek, I'm very sorry we failed to commit this 3 years

Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField

2017-01-23 Thread Sebastian Kügler
> On Jan. 22, 2017, 10:20 p.m., Albert Astals Cid wrote: > > Sebas should I commited this? After 3 years i'm not sure kde-runtime is the > > best thing to update in it's almost frozen state. > > Sebastian Kügler wrote: > I'd just discard it. I don't think anybody is releasing kde-runtime

Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField

2017-01-23 Thread Albert Astals Cid
> On Jan. 22, 2017, 10:20 p.m., Albert Astals Cid wrote: > > Sebas should I commited this? After 3 years i'm not sure kde-runtime is the > > best thing to update in it's almost frozen state. > > Sebastian Kügler wrote: > I'd just discard it. I don't think anybody is releasing kde-runtime

Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField

2017-01-23 Thread Sebastian Kügler
> On Jan. 22, 2017, 10:20 p.m., Albert Astals Cid wrote: > > Sebas should I commited this? After 3 years i'm not sure kde-runtime is the > > best thing to update in it's almost frozen state. I'd just discard it. I don't think anybody is releasing kde-runtime anyway, and the proper way to fix

Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField

2017-01-22 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114437/#review102202 --- Sebas should I commited this? After 3 years i'm not sure

Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField

2013-12-14 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114437/#review45699 --- Ship it! Looks good. - Sebastian Kügler On Dec. 13, 2013,

Review Request 114437: Add right click contextmenu for Plasma Components TextField

2013-12-13 Thread Leszek Lesner
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114437/ --- Review request for KDE Runtime. Repository: kde-runtime Description

Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField

2013-12-13 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114437/#review45652 --- Two comments inline.

Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField

2013-12-13 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114437/#review45654 --- plasma/declarativeimports/plasmacomponents/qml/TextField.qml

Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField

2013-12-13 Thread Leszek Lesner
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114437/ --- (Updated Dec. 13, 2013, 3:35 p.m.) Review request for KDE Runtime.

Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField

2013-12-13 Thread Leszek Lesner
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114437/ --- (Updated Dec. 13, 2013, 3:37 p.m.) Review request for KDE Runtime.

Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField

2013-12-13 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114437/#review45657 --- Where is the message extraction for these i18n() ? - Burkhard