Re: Review Request 114737: KInfocenter/OpenGL: reimplement the ReadPipe() function with QProcess

2014-03-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114737/#review52377 --- This review has been submitted with commit

Re: Review Request 114737: KInfocenter/OpenGL: reimplement the ReadPipe() function with QProcess

2014-01-26 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114737/#review48287 --- I made another change because I noticed a QProcess: Destroyed

Re: Review Request 114737: KInfocenter/OpenGL: reimplement the ReadPipe() function with QProcess

2014-01-26 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114737/ --- (Updated Jan. 26, 2014, 10:43 a.m.) Review request for kde-workspace and

Re: Review Request 114737: KInfocenter/OpenGL: reimplement the ReadPipe() function with QProcess

2014-01-14 Thread David Stephen Hubner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114737/#review47419 --- Ship it! Looks good to me - David Stephen Hubner On Jan.

Review Request 114737: KInfocenter/OpenGL: reimplement the ReadPipe() function with QProcess

2014-01-04 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114737/ --- Review request for kde-workspace and David Stephen Hubner. Repository:

Re: Review Request 114737: KInfocenter/OpenGL: reimplement the ReadPipe() function with QProcess

2014-01-04 Thread Rolf Eike Beer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114737/#review46765 --- kinfocenter/Modules/opengl/opengl.cpp

Re: Review Request 114737: KInfocenter/OpenGL: reimplement the ReadPipe() function with QProcess

2014-01-04 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114737/ --- (Updated Jan. 4, 2014, 5:54 p.m.) Review request for kde-workspace and

Re: Review Request 114737: KInfocenter/OpenGL: reimplement the ReadPipe() function with QProcess

2014-01-04 Thread Rolf Eike Beer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114737/#review46798 --- Looks fine to me, although I have not tested it. One minor