Re: Review Request 116017: Implement POST - POST redirection support in KIO

2014-03-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116017/#review51568 --- This review has been submitted with commit

Re: Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-27 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116017/ --- (Updated Feb. 27, 2014, 1:41 p.m.) Review request for kdelibs, Andrea

Re: Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-27 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116017/#review51063 --- kio/kio/job.cpp

Re: Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-27 Thread David Faure
On Feb. 24, 2014, 7:17 p.m., David Faure wrote: kio/kio/job.h, line 307 https://git.reviewboard.kde.org/r/116017/diff/1/?file=245840#file245840line307 recommended you use the function for when... - rather unclear. Which function? In the commit log you said you wanted to encourage

Re: Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-27 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116017/ --- (Updated Feb. 28, 2014, 5:42 a.m.) Review request for kdelibs, Andrea

Re: Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-27 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116017/ --- (Updated Feb. 28, 2014, 5:44 a.m.) Review request for kdelibs, Andrea

Re: Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-26 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116017/ --- (Updated Feb. 26, 2014, 8:34 a.m.) Review request for kdelibs, Andrea

Re: Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-26 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116017/#review50948 --- kio/kio/job.cpp

Re: Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-26 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116017/#review50957 --- ... may be it's more clear what I mean in my comments by

Re: Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-26 Thread Dawit Alemayehu
On Feb. 26, 2014, 4:15 p.m., Andrea Iacovitti wrote: ... may be it's more clear what I mean in my comments by showing code, see http://paste.kde.org/pvzj0ppio I did many tests and didn't found issues so far No I completely understood your point. It was just that my implementation

Re: Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-26 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116017/ --- (Updated Feb. 27, 2014, 6:04 a.m.) Review request for kdelibs, Andrea

Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-24 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116017/ --- Review request for kdelibs, Andrea Iacovitti and David Faure.

Re: Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-24 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116017/#review50761 --- I quickly tested the patch using a basic html form and it

Re: Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-24 Thread Dawit Alemayehu
On Feb. 24, 2014, 8:47 p.m., Andrea Iacovitti wrote: I quickly tested the patch using a basic html form and it seems it break http post operation (regardless of redirection). I get back a 400 Bad Request from the server and can see the following debug message: kio_http(17852)/kio