---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119130/
---
Review request for kdelibs and David Faure.
Repository: kio
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119130/#review61646
---
src/filewidgets/knewfilemenu.cpp
On July 5, 2014, 1:11 p.m., Mark Gaiser wrote:
src/filewidgets/knewfilemenu.cpp, line 874
https://git.reviewboard.kde.org/r/119130/diff/1/?file=287354#file287354line874
There is no need for this check since QStandardPaths::locateAll only
returns paths that exist:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119130/
---
(Updated July 5, 2014, 1:26 p.m.)
Review request for kdelibs and David
On jul 5, 2014, 1:11 p.m., Mark Gaiser wrote:
src/filewidgets/knewfilemenu.cpp, lines 875-878
https://git.reviewboard.kde.org/r/119130/diff/1/?file=287354#file287354line875
You should be able to replace this with:
files.append(dir.entryList(QStringList() *.desktop,
On July 5, 2014, 1:51 p.m., Mark Gaiser wrote:
Last question, could you make a unittest for this?
I'm not quite sure if it's even possible since this is in a private class.
You might be able to test this using KNewFileMenu::checkUpToDate?
KIO has very few unittests for KNewFileMenu,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119130/#review61661
---
Ship it!
Well spotted, and sorry for the copy/paste error
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119130/
---
(Updated July 5, 2014, 6:54 p.m.)
Status
--
This change has been
