Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-29 Thread RJVB Bertin
On July 21, 2014, 7:16 a.m., Ian Wadham wrote: So where are we leaving this? Any conclusions? Any solutions or further patches? Should we report the inconsistent handling of Native file dialogs as a bug on bugs.kde.org (without a patch this time)? If so, against what product

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-27 Thread RJVB Bertin
On July 21, 2014, 7:16 a.m., Ian Wadham wrote: So where are we leaving this? Any conclusions? Any solutions or further patches? Should we report the inconsistent handling of Native file dialogs as a bug on bugs.kde.org (without a patch this time)? If so, against what product

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-21 Thread Thomas Lübking
On Juli 21, 2014, 5:16 vorm., Ian Wadham wrote: So where are we leaving this? Any conclusions? Any solutions or further patches? Should we report the inconsistent handling of Native file dialogs as a bug on bugs.kde.org (without a patch this time)? If so, against what product

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-21 Thread Ian Wadham
On July 21, 2014, 5:16 a.m., Ian Wadham wrote: So where are we leaving this? Any conclusions? Any solutions or further patches? Should we report the inconsistent handling of Native file dialogs as a bug on bugs.kde.org (without a patch this time)? If so, against what product

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-20 Thread Ian Wadham
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119243/#review62755 --- So where are we leaving this? Any conclusions? Any solutions

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-16 Thread RJVB Bertin
On July 12, 2014, 10:08 a.m., Marko Käning wrote: Ian Wadham wrote: It seems to me there should be a config item UnifiedTitleAndToolBarOnMac=true (or false) in some KDE file somewhere. But what is that file's name and where is it usually located in the Linux/KDE directory

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-16 Thread Ian Wadham
On July 12, 2014, 10:08 a.m., Marko Käning wrote: Ian Wadham wrote: It seems to me there should be a config item UnifiedTitleAndToolBarOnMac=true (or false) in some KDE file somewhere. But what is that file's name and where is it usually located in the Linux/KDE directory

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-16 Thread RJVB Bertin
On July 12, 2014, 2:11 p.m., Aleix Pol Gonzalez wrote: kio/kfile/kfiledialog.cpp, line 316 https://git.reviewboard.kde.org/r/119243/diff/1/?file=289740#file289740line316 I don't know why you did that, but it doesn't look good. Marko Käning wrote: Actually, when submitting

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-16 Thread RJVB Bertin
On July 12, 2014, 10:08 a.m., Marko Käning wrote: kdeui/widgets/kmainwindow.cpp, line 244 https://git.reviewboard.kde.org/r/119243/diff/1/?file=289738#file289738line244 Actually, I don't know whether I want this integration as default... Ian Wadham wrote: I have tested this

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-16 Thread RJVB Bertin
On July 12, 2014, 10:08 a.m., Marko Käning wrote: Ian Wadham wrote: It seems to me there should be a config item UnifiedTitleAndToolBarOnMac=true (or false) in some KDE file somewhere. But what is that file's name and where is it usually located in the Linux/KDE directory

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-16 Thread Ian Wadham
On July 12, 2014, 2:11 p.m., Marko Käning wrote: Other than that it looks ok. Please update the patch though. Ian Wadham wrote: I have tested the patch on Apple OS X in my kdesrc-build environment for KDE 4.13 branch. Before I did so, I removed the comment from line 316 and also

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-15 Thread Thomas Lübking
On Juli 12, 2014, 2:11 nachm., Aleix Pol Gonzalez wrote: kio/kfile/kfiledialog.cpp, line 316 https://git.reviewboard.kde.org/r/119243/diff/1/?file=289740#file289740line316 I don't know why you did that, but it doesn't look good. Marko Käning wrote: Actually, when submitting

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-14 Thread Thomas Lübking
On Juli 12, 2014, 2:11 nachm., Aleix Pol Gonzalez wrote: kio/kfile/kfiledialog.cpp, line 316 https://git.reviewboard.kde.org/r/119243/diff/1/?file=289740#file289740line316 I don't know why you did that, but it doesn't look good. Marko Käning wrote: Actually, when submitting

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-14 Thread Ian Wadham
On July 12, 2014, 2:11 p.m., Marko Käning wrote: Other than that it looks ok. Please update the patch though. I have tested the patch on Apple OS X in my kdesrc-build environment for KDE 4.13 branch. Before I did so, I removed the comment from line 316 and also the pair of braces from the

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-14 Thread Ian Wadham
On July 12, 2014, 2:11 p.m., Aleix Pol Gonzalez wrote: kio/kfile/kfiledialog.cpp, line 316 https://git.reviewboard.kde.org/r/119243/diff/1/?file=289740#file289740line316 I don't know why you did that, but it doesn't look good. Marko Käning wrote: Actually, when submitting

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-14 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119243/ --- (Updated July 14, 2014, 7:08 p.m.) Review request for KDE Software on

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-14 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119243/ --- (Updated July 14, 2014, 8:15 p.m.) Review request for KDE Software on

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-13 Thread Ian Wadham
On July 12, 2014, 2:11 p.m., Aleix Pol Gonzalez wrote: kio/kfile/kfiledialog.cpp, line 316 https://git.reviewboard.kde.org/r/119243/diff/1/?file=289740#file289740line316 I don't know why you did that, but it doesn't look good. Marko Käning wrote: Actually, when submitting

Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-12 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119243/ --- Review request for kdelibs, Christoph Feck and Ian Wadham. Bugs: 337356

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-12 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119243/#review62175 --- Just out of curiosity, but why would KIO need to know the

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119243/#review62184 --- kio/kfile/kfiledialog.cpp

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-12 Thread Ian Wadham
On July 12, 2014, 10:08 a.m., Marko Käning wrote: It seems to me there should be a config item UnifiedTitleAndToolBarOnMac=true (or false) in some KDE file somewhere. But what is that file's name and where is it usually located in the Linux/KDE directory trees? And how could a user get