---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120202/
---
(Updated Aug. 17, 2015, 5 p.m.)
Review request for KDE Software on Mac
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120202/
---
(Updated Jan. 3, 2015, 8:42 p.m.)
Review request for KDE Software on Mac
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120202/
---
(Updated Jan. 3, 2015, 8:41 p.m.)
Review request for KDE Software on Mac
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120202/
---
(Updated Nov. 19, 2014, 6 p.m.)
Review request for KDE Software on Mac
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120202/
---
(Updated Nov. 19, 2014, 6:05 p.m.)
Review request for KDE Software on
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120202/
---
(Updated Oct. 18, 2014, 8:45 p.m.)
Review request for KDE Software on
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120202/
---
(Updated Oct. 16, 2014, 1:26 p.m.)
Review request for KDE Software on
On Oct. 15, 2014, 10:07 p.m., Thomas Lübking wrote:
Please check https://techbase.kde.org/Policies/Kdelibs_Coding_Style
Sure, and guess what I noticed first ;)
```
Nobody is forced to use this style, but to have consistent formatting of the
source code files it is recommended to make use
On Oct. 15, 2014, 10:07 p.m., Thomas Lübking wrote:
Please check https://techbase.kde.org/Policies/Kdelibs_Coding_Style
René J.V. Bertin wrote:
Sure, and guess what I noticed first ;)
```
Nobody is forced to use this style, but to have consistent formatting of
the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120202/
---
(Updated Oct. 15, 2014, 9:51 p.m.)
Review request for KDE Software on
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120202/#review68511
---
Please check
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120202/
---
(Updated Sept. 25, 2014, 3:58 p.m.)
Review request for KDE Software on
On Sept. 18, 2014, 10:28 nachm., Albert Astals Cid wrote:
kdeui/util/kwallet.h, line 545
https://git.reviewboard.kde.org/r/120202/diff/1/?file=312224#file312224line545
This is bad, slots in an ifdef are a bad idea.
Is there any reason this slot has to be in KWallet and
On Sept. 21, 2014, 6:11 nachm., Thomas Lübking wrote:
kdeui/util/qosxkeychain.h, line 99
https://git.reviewboard.kde.org/r/120202/diff/2/?file=314175#file314175line99
If OSXKaychain is an exported class (i don't know), this is an ABI
incompatible change.
It's also
On Sept. 21, 2014, 6:11 nachm., Thomas Lübking wrote:
kdeui/util/qosxkeychain.h, line 99
https://git.reviewboard.kde.org/r/120202/diff/2/?file=314175#file314175line99
If OSXKaychain is an exported class (i don't know), this is an ABI
incompatible change.
It's also
On Sept. 21, 2014, 8:11 p.m., Thomas Lübking wrote:
kdeui/util/qosxkeychain.h, line 99
https://git.reviewboard.kde.org/r/120202/diff/2/?file=314175#file314175line99
If OSXKaychain is an exported class (i don't know), this is an ABI
incompatible change.
It's also
On Sept. 21, 2014, 6:11 nachm., Thomas Lübking wrote:
kdeui/util/qosxkeychain.h, line 99
https://git.reviewboard.kde.org/r/120202/diff/2/?file=314175#file314175line99
If OSXKaychain is an exported class (i don't know), this is an ABI
incompatible change.
It's also
On Sept. 21, 2014, 8:11 p.m., Thomas Lübking wrote:
kdeui/util/qosxkeychain.h, line 99
https://git.reviewboard.kde.org/r/120202/diff/2/?file=314175#file314175line99
If OSXKaychain is an exported class (i don't know), this is an ABI
incompatible change.
It's also
On Sept. 18, 2014, 10:28 p.m., Albert Astals Cid wrote:
kdeui/util/kwallet.h, line 545
https://git.reviewboard.kde.org/r/120202/diff/1/?file=312224#file312224line545
This is bad, slots in an ifdef are a bad idea.
Is there any reason this slot has to be in KWallet and
On Sept. 19, 2014, 12:28 a.m., Albert Astals Cid wrote:
kdeui/util/kwallet.h, line 545
https://git.reviewboard.kde.org/r/120202/diff/1/?file=312224#file312224line545
This is bad, slots in an ifdef are a bad idea.
Is there any reason this slot has to be in KWallet and
On set. 18, 2014, 10:28 p.m., Albert Astals Cid wrote:
kdeui/util/kwallet.h, line 545
https://git.reviewboard.kde.org/r/120202/diff/1/?file=312224#file312224line545
This is bad, slots in an ifdef are a bad idea.
Is there any reason this slot has to be in KWallet and not
On Sept. 18, 2014, 10:28 nachm., Albert Astals Cid wrote:
kdeui/util/kwallet.h, line 545
https://git.reviewboard.kde.org/r/120202/diff/1/?file=312224#file312224line545
This is bad, slots in an ifdef are a bad idea.
Is there any reason this slot has to be in KWallet and
On Sept. 19, 2014, 12:28 a.m., Albert Astals Cid wrote:
kdeui/util/kwallet.h, line 545
https://git.reviewboard.kde.org/r/120202/diff/1/?file=312224#file312224line545
This is bad, slots in an ifdef are a bad idea.
Is there any reason this slot has to be in KWallet and
On set. 18, 2014, 10:28 p.m., Albert Astals Cid wrote:
kdeui/util/kwallet.h, line 545
https://git.reviewboard.kde.org/r/120202/diff/1/?file=312224#file312224line545
This is bad, slots in an ifdef are a bad idea.
Is there any reason this slot has to be in KWallet and not
On Sept. 18, 2014, 10:28 nachm., Albert Astals Cid wrote:
kdeui/util/kwallet.h, line 545
https://git.reviewboard.kde.org/r/120202/diff/1/?file=312224#file312224line545
This is bad, slots in an ifdef are a bad idea.
Is there any reason this slot has to be in KWallet and
On Sept. 19, 2014, 12:28 a.m., Albert Astals Cid wrote:
kdeui/util/kwallet.h, line 545
https://git.reviewboard.kde.org/r/120202/diff/1/?file=312224#file312224line545
This is bad, slots in an ifdef are a bad idea.
Is there any reason this slot has to be in KWallet and
On set. 18, 2014, 10:28 p.m., Albert Astals Cid wrote:
kdeui/util/kwallet.h, line 545
https://git.reviewboard.kde.org/r/120202/diff/1/?file=312224#file312224line545
This is bad, slots in an ifdef are a bad idea.
Is there any reason this slot has to be in KWallet and not
OK, implementation question.
How do I declare a slot in a private class that doesn't have a specific
header file? Putting `private QSLOT` above the function definition makes
things compile, but the runtime complains about a missing slot (curiously
even expecting it in KWallet::Wallet). Yes,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120202/#review67155
---
kdeui/util/qosxkeychain.h
On Sept. 21, 2014, 8:11 p.m., Thomas Lübking wrote:
kdeui/util/qosxkeychain.h, line 99
https://git.reviewboard.kde.org/r/120202/diff/2/?file=314175#file314175line99
If OSXKaychain is an exported class (i don't know), this is an ABI
incompatible change.
It's also
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120202/#review66894
---
kdeui/util/kwallet.h
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120202/
---
Review request for KDE Software on Mac OS X and kdelibs.
Repository:
32 matches
Mail list logo