Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

2014-10-04 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120363/#review67927 --- See also bug 334174 - Marko Käning On Sept. 25, 2014, 3:32

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

2014-09-27 Thread Marko Käning
Hi Thiago, On 26 Sep 2014, at 07:01 , Thiago Macieira thi...@kde.org wrote: And still it needs to be studied for Qt5, unless the plan is to never transition to Qt 5 (which means KDE-on-Mac will stop compiling within 2 years). did you miss our efforts on KF5 including setting up an OSX/CI

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

2014-09-26 Thread Thiago Macieira
On Friday 26 September 2014 07:05:09 Marko Käning wrote: Hi Thiago, On 26 Sep 2014, at 07:01 , Thiago Macieira thi...@kde.org wrote: And still it needs to be studied for Qt5, unless the plan is to never transition to Qt 5 (which means KDE-on-Mac will stop compiling within 2 years).

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

2014-09-26 Thread Ben Cooksley
On Fri, Sep 26, 2014 at 5:01 PM, Thiago Macieira thi...@kde.org wrote: On Thursday 25 September 2014 22:32:35 René J.V. Bertin wrote: Ah, apparently Thiago missed the multiple recent reminders of the fact that we OS X users are going to be stuck in/with KDE4 for a tad longer than the average

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

2014-09-26 Thread Thomas Lübking
On Freitag, 26. September 2014 10:41:39 CEST, Ben Cooksley wrote: Applying a solution to a single OS is inherently wrong On Fri, Sep 26, 2014 at 5:01 PM, Thiago Macieira thi...@kde.org wrote: And still it needs to be studied for Qt5 Afaics there are two major issues with this patch (and

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

2014-09-26 Thread René J . V . Bertin
On Sept. 25, 2014, 8:07 p.m., Thomas Lübking wrote: Aside Thiagos concern, what actually causes the menubar/docker item stuff? Quoting QApplication (4.8): On X11, the window system is initialized if GUIenabled is true. If GUIenabled is false, the application does not connect to

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

2014-09-26 Thread Thiago Macieira
On Friday 26 September 2014 11:08:23 René J.V. Bertin wrote: Patches should *always* be upstreamed, especially when we are essentially the distributor (in essence we are carrying forks of our own projects due to these patches). Heh, and when upstream means Qt, we'll probably have to

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

2014-09-26 Thread René J . V . Bertin
On Sept. 25, 2014, 8:07 p.m., Thomas Lübking wrote: Aside Thiagos concern, what actually causes the menubar/docker item stuff? Quoting QApplication (4.8): On X11, the window system is initialized if GUIenabled is true. If GUIenabled is false, the application does not connect to

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

2014-09-26 Thread René J . V . Bertin
On Sept. 25, 2014, 8:07 p.m., Thomas Lübking wrote: Aside Thiagos concern, what actually causes the menubar/docker item stuff? Quoting QApplication (4.8): On X11, the window system is initialized if GUIenabled is true. If GUIenabled is false, the application does not connect to

Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

2014-09-25 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120363/ --- Review request for KDE Software on Mac OS X and kdelibs. Repository:

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

2014-09-25 Thread Thiago Macieira
On Thursday 25 September 2014 13:32:41 René J.V. Bertin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120363/ --- Review

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

2014-09-25 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120363/#review67442 --- Aside Thiagos concern, what actually causes the

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

2014-09-25 Thread René J . V . Bertin
On Sept. 25, 2014, 8:07 p.m., Thomas Lübking wrote: Aside Thiagos concern, what actually causes the menubar/docker item stuff? Quoting QApplication (4.8): On X11, the window system is initialized if GUIenabled is true. If GUIenabled is false, the application does not connect to

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

2014-09-25 Thread Thomas Lübking
On Sept. 25, 2014, 6:07 nachm., Thomas Lübking wrote: Aside Thiagos concern, what actually causes the menubar/docker item stuff? Quoting QApplication (4.8): On X11, the window system is initialized if GUIenabled is true. If GUIenabled is false, the application does not connect to

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

2014-09-25 Thread René J . V . Bertin
On Sept. 25, 2014, 8:07 p.m., Thomas Lübking wrote: Aside Thiagos concern, what actually causes the menubar/docker item stuff? Quoting QApplication (4.8): On X11, the window system is initialized if GUIenabled is true. If GUIenabled is false, the application does not connect to

Re: Review Request 120363: proposal to use the NOGUI switch in CMake files to set the default value for GUIenabled

2014-09-25 Thread Thiago Macieira
On Thursday 25 September 2014 22:32:35 René J.V. Bertin wrote: Ah, apparently Thiago missed the multiple recent reminders of the fact that we OS X users are going to be stuck in/with KDE4 for a tad longer than the average Linux user (Debian apart, maybe? ;)) Anyway, I guess I'm going to have