Re: Review Request 120554: Initial frameworks port of kompare

2014-10-16 Thread Kevin Kofler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120554/#review68582 --- See my point by point review below. Once all the issues are

Re: Review Request 120554: Initial frameworks port of kompare

2014-10-16 Thread Kevin Kofler
On Okt. 16, 2014, 10:47 nachm., Kevin Kofler wrote: komparepart/kompare_part.cpp, line 295 https://git.reviewboard.kde.org/r/120554/diff/4/?file=318659#file318659line295 This should pass at least QUrl::RemoveUserInfo to toString(), we don't want to echo passwords in error

Re: Review Request 120554: Initial frameworks port of kompare

2014-10-16 Thread Kevin Kofler
On Okt. 16, 2014, 10:47 nachm., Kevin Kofler wrote: komparepart/kompare_part.cpp, line 295 https://git.reviewboard.kde.org/r/120554/diff/4/?file=318659#file318659line295 This should pass at least QUrl::RemoveUserInfo to toString(), we don't want to echo passwords in error

Re: Review Request 120554: Initial frameworks port of kompare

2014-10-16 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120554/ --- (Updated Oct. 16, 2014, 7:45 p.m.) Review request for kdelibs and Kevin

Re: Review Request 120554: Initial frameworks port of kompare

2014-10-16 Thread Kevin Kofler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120554/#review68587 --- Oh, I missed this one: The QFileDialog it uses wasn't

Re: Review Request 120554: Initial frameworks port of kompare

2014-10-16 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120554/ --- (Updated Oct. 16, 2014, 7:48 p.m.) Review request for kdelibs and Kevin

Re: Review Request 120554: Initial frameworks port of kompare

2014-10-16 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120554/ --- (Updated Oct. 16, 2014, 7:53 p.m.) Review request for kdelibs and Kevin

Re: Review Request 120554: Initial frameworks port of kompare

2014-10-16 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120554/ --- (Updated Oct. 17, 2014, 2:05 a.m.) Status -- This change has been

Re: Review Request 120554: Initial frameworks port of kompare

2014-10-15 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120554/ --- (Updated Oct. 15, 2014, 11:24 p.m.) Review request for kdelibs and Kevin

Re: Review Request 120554: Initial frameworks port of kompare

2014-10-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120554/#review68379 --- komparepart/kompare_part.cpp

Re: Review Request 120554: Initial frameworks port of kompare

2014-10-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120554/ --- (Updated Oct. 14, 2014, 2:53 p.m.) Review request for kdelibs and

Re: Review Request 120554: Initial frameworks port of kompare

2014-10-13 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120554/ --- (Updated Oct. 13, 2014, 5:46 p.m.) Review request for kdelibs and

Review Request 120554: Initial frameworks port of kompare

2014-10-10 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120554/ --- Review request for kdelibs and Vavelin Kevin. Repository: kompare