Re: Review Request 121286: Adding support for lldb in DrKonqi (step 1)

2014-11-30 Thread Pino Toscano
On Nov. 29, 2014, 10:20 p.m., Pino Toscano wrote: drkonqi/backtracegenerator.cpp, line 97 https://git.reviewboard.kde.org/r/121286/diff/3/?file=331098#file331098line97 Still hardcodes the debugger name; I'm not a drkonqui developer, so I cannot tell you exactly what to do --

Re: Review Request 121286: Adding support for lldb in DrKonqi (step 1)

2014-11-30 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121286/#review71117 --- drkonqi/backtracegenerator.cpp

Re: Review Request 121286: Adding support for lldb in DrKonqi (step 1)

2014-11-30 Thread René J . V . Bertin
On Nov. 29, 2014, 11:20 p.m., Pino Toscano wrote: drkonqi/drkonqibackends.cpp, line 175 https://git.reviewboard.kde.org/r/121286/diff/3/?file=331101#file331101line175 This macros won't be defined outside Mac, so please check for its existency as well. On the compilers I have

Re: Review Request 121286: Adding support for lldb in DrKonqi (step 1)

2014-11-30 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121286/ --- (Updated Nov. 30, 2014, 8:53 p.m.) Review request for KDE Software on

Re: Review Request 121286: Adding support for lldb in DrKonqi (step 1)

2014-11-30 Thread Thomas Lübking
On Nov. 29, 2014, 10:20 nachm., Pino Toscano wrote: drkonqi/drkonqibackends.cpp, line 175 https://git.reviewboard.kde.org/r/121286/diff/3/?file=331101#file331101line175 This macros won't be defined outside Mac, so please check for its existency as well. René J.V. Bertin wrote:

Re: Review Request 121286: Adding support for lldb in DrKonqi (step 1)

2014-11-30 Thread René J . V . Bertin
On Nov. 30, 2014, 1:43 p.m., Thomas Lübking wrote: drkonqi/backtracegenerator.cpp, line 99 https://git.reviewboard.kde.org/r/121286/diff/3/?file=331098#file331098line99 -setOpenMode(QIODevice::ReadOnly|.)? Why is this required, btw.? Does lldb wet itself if DrKonqi

Re: Review Request 121286: Adding support for lldb in DrKonqi (step 1)

2014-11-30 Thread René J . V . Bertin
On Nov. 29, 2014, 11:20 p.m., Pino Toscano wrote: drkonqi/drkonqibackends.cpp, line 175 https://git.reviewboard.kde.org/r/121286/diff/3/?file=331101#file331101line175 This macros won't be defined outside Mac, so please check for its existency as well. René J.V. Bertin wrote:

Re: Review Request 121286: Adding support for lldb in DrKonqi (step 1)

2014-11-29 Thread René J . V . Bertin
On Nov. 29, 2014, 12:09 a.m., Pino Toscano wrote: drkonqi/backtracegenerator.cpp, lines 97-100 https://git.reviewboard.kde.org/r/121286/diff/1/?file=331014#file331014line97 Shouldn't this rather be some attribute in the rc file, instead of hardcoding the lldb behaviour in the

Re: Review Request 121286: Adding support for lldb in DrKonqi (step 1)

2014-11-29 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121286/ --- (Updated Nov. 29, 2014, 11:03 p.m.) Review request for KDE Software on

Re: Review Request 121286: Adding support for lldb in DrKonqi (step 1)

2014-11-29 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121286/#review71100 --- drkonqi/backtracegenerator.cpp

Re: Review Request 121286: Adding support for lldb in DrKonqi (step 1)

2014-11-29 Thread Ian Wadham
On Nov. 29, 2014, 10:20 p.m., Pino Toscano wrote: drkonqi/backtracegenerator.cpp, line 97 https://git.reviewboard.kde.org/r/121286/diff/3/?file=331098#file331098line97 Still hardcodes the debugger name; I'm not a drkonqui developer, so I cannot tell you exactly what to do --

Re: Review Request 121286: Adding support for lldb in DrKonqi (step 1)

2014-11-28 Thread Pino Toscano
On Nov. 28, 2014, 11:09 p.m., Pino Toscano wrote: drkonqi/backtracegenerator.cpp, lines 97-100 https://git.reviewboard.kde.org/r/121286/diff/1/?file=331014#file331014line97 Shouldn't this rather be some attribute in the rc file, instead of hardcoding the lldb behaviour in the