----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122563/#review76003 -----------------------------------------------------------
Ship it! Ship It! - Jeremy Whiting On Feb. 13, 2015, 12:19 p.m., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122563/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2015, 12:19 p.m.) > > > Review request for KDE Software on Mac OS X and kdelibs. > > > Repository: kdelibs > > > Description > ------- > > OS X applications usually remember the last used screen, size and screen > position across restarts, and do not save screen-resolution dependent > settings. > > The patch proposed here emulates that behaviour by following the example > given in the documentation for `QWidget::saveGeometry`: the current geometry > is saved in a key called `geometry`, and position is kept up to date by > letting `QEvent::Move` dirty the size setting, as under MS Windows. > > I think it's good practice to support previously stored settings when > changing a config store, so the code attempts to restore "legacy" settings > when the new key is unavailable. > > > Diffs > ----- > > kdeui/widgets/kmainwindow.cpp 85beacc > > Diff: https://git.reviewboard.kde.org/r/122563/diff/ > > > Testing > ------- > > On OS X 10.9.5 with Qt 4.8.6 and kdelibs 4.14.5 (head of the 4.14 branch); > tested with systemsettings, kate and kontact. > > > Thanks, > > René J.V. Bertin > >
