---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/
---
(Updated Jan. 21, 2017, 12:46 a.m.)
Status
--
This change has been
> On Oct. 19, 2015, 6:50 p.m., Rex Dieter wrote:
> > May as well drop this now, it's largely superceded by code in in repo
> > already, for example,
> > https://quickgit.kde.org/?p=sonnet.git=commit=0e6edac621fbd366b126ebd851fbea21355e02d0
Dropping as suggested by Rex.
- Albert
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review87098
---
May as well drop this now, it's largely superceded by code in
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review83458
---
Ship it!
This is the obvious easy fix (I was about to submit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/
---
(Updated Квітень 7, 2015, 2:20 після полудня)
Review request for KDE
On March 17, 2015, 6:05 p.m., Christophe Giboudeaux wrote:
src/plugins/hunspell/CMakeLists.txt, line 9
https://git.reviewboard.kde.org/r/122987/diff/4/?file=355374#file355374line9
endif()
Eugene Shalygin wrote:
Ping?
He means you shouldn't put anything inside endif()
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review78586
---
This doesn't let the user change the path but the
On Березень 17, 2015, 6:05 після полудня, Christophe Giboudeaux wrote:
src/plugins/hunspell/CMakeLists.txt, line 9
https://git.reviewboard.kde.org/r/122987/diff/4/?file=355374#file355374line9
endif()
Ping?
- Eugene
---
On Березень 17, 2015, 2:07 після полудня, Laurent Montel wrote:
src/plugins/hunspell/hunspellclient.cpp, line 27
https://git.reviewboard.kde.org/r/122987/diff/3/?file=355372#file355372line27
#include ...
we use local file.
Rolf Eike Beer wrote:
No, the file is in an
On März 17, 2015, 1:07 nachm., Laurent Montel wrote:
src/plugins/hunspell/hunspellclient.cpp, line 27
https://git.reviewboard.kde.org/r/122987/diff/3/?file=355372#file355372line27
#include ...
we use local file.
No, the file is in an include path, not in the same directory as
On Березень 17, 2015, 6:05 після полудня, Christophe Giboudeaux wrote:
src/plugins/hunspell/CMakeLists.txt, line 7
https://git.reviewboard.kde.org/r/122987/diff/4/?file=355374#file355374line7
So you change an hardcoded path by a user chosen hardcoded one ?
looking at
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77617
---
src/plugins/hunspell/CMakeLists.txt
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77622
---
(not entitled to give a ship it, but) have you checked if
On March 17, 2015, 1:41 p.m., Luigi Toscano wrote:
(not entitled to give a ship it, but) have you checked if this is still
relevant for the Sonnet framework?
Ups, this review is for sonnet; I was confused by the group (please use
kdeframeworks instead of kdelibs for Frameworks-related
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/
---
Review request for kdelibs.
Repository: sonnet
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/
---
(Updated Березень 17, 2015, 1:22 після полудня)
Review request for
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/
---
(Updated Березень 17, 2015, 1:50 після полудня)
Review request for KDE
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/
---
(Updated Березень 17, 2015, 2:09 після полудня)
Review request for KDE
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77636
---
Ok for me.
Just wait that maintainer gives you a Ship it
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77631
---
I am not maintainer of this module but I can put a +1
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77630
---
src/plugins/hunspell/hunspellclient.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/
---
(Updated Березень 17, 2015, 2:05 після полудня)
Review request for KDE
On Березень 17, 2015, 1:41 після полудня, Luigi Toscano wrote:
(not entitled to give a ship it, but) have you checked if this is still
relevant for the Sonnet framework?
Luigi Toscano wrote:
Ups, this review is for sonnet; I was confused by the group (please use
kdeframeworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77647
---
src/plugins/hunspell/CMakeLists.txt
24 matches
Mail list logo
