Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123797/ --- (Updated Mai 15, 2015, 6:45 nachm.) Status -- This change has been d

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123797/#review80420 --- Then just discard this review request and open a new one again

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123797/ --- (Updated Mai 15, 2015, 6:33 nachm.) Review request for kde-workspace and

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

> On Mai 15, 2015, 6:01 nachm., Martin Gräßlin wrote: > > This patch is against kde-workspace, but the development happens in > > plasma-workspace nowadays. Could you please rebase against the newer > > repository? > > Patrick Eigensatz wrote: > Sorry, I saw your comment a bît too late. Ca

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

> On May 15, 2015, 8:01 p.m., Martin Gräßlin wrote: > > This patch is against kde-workspace, but the development happens in > > plasma-workspace nowadays. Could you please rebase against the newer > > repository? > > Patrick Eigensatz wrote: > Sorry, I saw your comment a bît too late. Can

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

> On Mai 15, 2015, 6:01 nachm., Martin Gräßlin wrote: > > This patch is against kde-workspace, but the development happens in > > plasma-workspace nowadays. Could you please rebase against the newer > > repository? Sorry, I saw your comment a bît too late. Can you tell me how to rebase my pat

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123797/ --- (Updated Mai 15, 2015, 6:05 nachm.) Review request for kde-workspace and

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

> On Mai 15, 2015, 2:27 nachm., Kai Uwe Broulik wrote: > > plasma-workspace/klipper/historyitem.cpp, line 89 > > > > > > return nullptr; > > Patrick Eigensatz wrote: > Thank you! Existing code uses everywhere

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123797/#review80412 --- This patch is against kde-workspace, but the development happe

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

> On Mai 15, 2015, 2:27 nachm., Kai Uwe Broulik wrote: > > plasma-workspace/klipper/historyitem.cpp, line 89 > > > > > > return nullptr; > > Patrick Eigensatz wrote: > Thank you! Existing code uses everywhere

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

> On Mai 15, 2015, 2:27 nachm., Kai Uwe Broulik wrote: > > plasma-workspace/klipper/historyitem.cpp, line 89 > > > > > > return nullptr; > > Patrick Eigensatz wrote: > Thank you! Existing code uses everywhere

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123797/ --- (Updated Mai 15, 2015, 2:56 nachm.) Review request for kde-workspace and

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

> On Mai 15, 2015, 2:27 nachm., Kai Uwe Broulik wrote: > > plasma-workspace/klipper/historyitem.cpp, line 89 > > > > > > return nullptr; > > Patrick Eigensatz wrote: > Thank you! Existing code uses everywhere

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

> On Mai 15, 2015, 2:27 nachm., Kai Uwe Broulik wrote: > > plasma-workspace/klipper/historyitem.cpp, line 89 > > > > > > return nullptr; Thank you! Existing code uses everywhere "return 0;", I can't find the dec

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123797/#review80406 --- plasma-workspace/klipper/historyitem.cpp (line 88)

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123797/ --- (Updated Mai 15, 2015, 2:24 nachm.) Review request for kde-workspace and