Re: Review Request 123881: Add KONSOLEPRIVATE_EXPORT to HistoryScroll since it's hasScroll method is needed.

2015-08-08 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123881/ --- (Updated Aug. 8, 2015, 1:50 p.m.) Status -- This change has been

Re: Review Request 123881: Add KONSOLEPRIVATE_EXPORT to HistoryScroll since it's hasScroll method is needed.

2015-08-07 Thread José Manuel Santamaría Lema
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123881/#review83538 --- Ship it! Ship It! - José Manuel Santamaría Lema On Mayo

Re: Review Request 123881: Add KONSOLEPRIVATE_EXPORT to HistoryScroll since it's hasScroll method is needed.

2015-08-07 Thread José Manuel Santamaría Lema
On Mayo 23, 2015, 12:23 a.m., Aleix Pol Gonzalez wrote: Hm.. Builds here. Also builds in build.kde.org... https://build.kde.org/job/konsole%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ :/ Jeremy Whiting wrote: I'm not sure why, but I did test a few times before making

Re: Review Request 123881: Add KONSOLEPRIVATE_EXPORT to HistoryScroll since it's hasScroll method is needed.

2015-05-24 Thread Aleix Pol Gonzalez
On May 23, 2015, 2:23 a.m., Aleix Pol Gonzalez wrote: Hm.. Builds here. Also builds in build.kde.org... https://build.kde.org/job/konsole%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ :/ Jeremy Whiting wrote: I'm not sure why, but I did test a few times before making

Re: Review Request 123881: Add KONSOLEPRIVATE_EXPORT to HistoryScroll since it's hasScroll method is needed.

2015-05-23 Thread Jeremy Whiting
On May 22, 2015, 6:23 p.m., Aleix Pol Gonzalez wrote: Hm.. Builds here. Also builds in build.kde.org... https://build.kde.org/job/konsole%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ :/ I'm not sure why, but I did test a few times before making this change. Could it be

Review Request 123881: Add KONSOLEPRIVATE_EXPORT to HistoryScroll since it's hasScroll method is needed.

2015-05-22 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123881/ --- Review request for KDE Base Apps and Konsole. Repository: konsole

Re: Review Request 123881: Add KONSOLEPRIVATE_EXPORT to HistoryScroll since it's hasScroll method is needed.

2015-05-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123881/#review80746 --- Hm.. Builds here. Also builds in build.kde.org...