Re: Review Request 125561: Sync FindGettext.cmake macros with upstream module from CMake

2015-10-09 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125561/#review86524 --- Thanks for working on this, it's really appreciated. -

Re: Review Request 125561: Sync FindGettext.cmake macros with upstream module from CMake

2015-10-09 Thread Jeremy Whiting
> On Oct. 9, 2015, 2:26 p.m., Albert Astals Cid wrote: > > This doesn't look like "a bugfix" to me. > > Jeremy Whiting wrote: > Oh, but it is. Without this or cmake_policy(SET CMP0002 OLD) (see > https://bugs.kde.org/show_bug.cgi?id=316308) applications that have their own > translations

Re: Review Request 125561: Sync FindGettext.cmake macros with upstream module from CMake

2015-10-09 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125561/#review86580 --- This doesn't look like "a bugfix" to me. - Albert Astals Cid

Re: Review Request 125561: Sync FindGettext.cmake macros with upstream module from CMake

2015-10-09 Thread Jeremy Whiting
> On Oct. 9, 2015, 2:26 p.m., Albert Astals Cid wrote: > > This doesn't look like "a bugfix" to me. Oh, but it is. Without this or cmake_policy(SET CMP0002 OLD) (see https://bugs.kde.org/show_bug.cgi?id=316308) applications that have their own translations in the tarball (everything we

Re: Review Request 125561: Sync FindGettext.cmake macros with upstream module from CMake

2015-10-09 Thread Albert Astals Cid
> On oct. 9, 2015, 8:26 p.m., Albert Astals Cid wrote: > > This doesn't look like "a bugfix" to me. > > Jeremy Whiting wrote: > Oh, but it is. Without this or cmake_policy(SET CMP0002 OLD) (see > https://bugs.kde.org/show_bug.cgi?id=316308) applications that have their own > translations

Review Request 125561: Sync FindGettext.cmake macros with upstream module from CMake

2015-10-08 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125561/ --- Review request for Build System, kdelibs, Localization and Translation

Re: Review Request 125561: Sync FindGettext.cmake macros with upstream module from CMake

2015-10-08 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125561/#review86518 --- Looks good to me, but I can't quite follow it all myself.