Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126704/#review91183 --- As put by reviewboard, the patch only has whitespace

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126704/ --- (Updated Янв. 16, 2016, 4:14 п.п.) Review request for kde-workspace,

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126704/#review91188 --- Fix it, then Ship it! Fix copyright and push.

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

> On Янв. 13, 2016, 12:31 д.п., Aleix Pol Gonzalez wrote: > > Aleix, can we ship it? I guess we have very little time to commit it for 5.6.x because user visible strings will be frozen soon (if not yet). - Andrey --- This is an

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126704/ --- (Updated Янв. 17, 2016, 12:46 д.п.) Status -- This change has been

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

> On Янв. 13, 2016, 12:31 д.п., Aleix Pol Gonzalez wrote: > > src/iconthemesmodel.cpp, line 99 > > > > > > Now that you have the CursorsThemeModel that shouldn't be needed > > anymore. > > > > If it

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

> On Янв. 12, 2016, 12:11 п.п., Aleix Pol Gonzalez wrote: > > All in all it looks quite good. > > > > I'd suggest creating a CursorThemesModel inheriting IconThemesModel that > > overrides some methods (you can add virtuals). Otherwise we're adding > > weirdly specific logic. > > > > Also

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126704/ --- (Updated Янв. 13, 2016, 6:03 д.п.) Review request for kde-workspace,

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

> On Янв. 12, 2016, 12:11 п.п., Aleix Pol Gonzalez wrote: > > All in all it looks quite good. > > > > I'd suggest creating a CursorThemesModel inheriting IconThemesModel that > > overrides some methods (you can add virtuals). Otherwise we're adding > > weirdly specific logic. > > > > Also

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126704/#review90964 --- All in all it looks quite good. I'd suggest creating a

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

> On Янв. 12, 2016, 12:11 п.п., Aleix Pol Gonzalez wrote: > > All in all it looks quite good. > > > > I'd suggest creating a CursorThemesModel inheriting IconThemesModel that > > overrides some methods (you can add virtuals). Otherwise we're adding > > weirdly specific logic. > > > > Also

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126704/ --- (Updated Янв. 12, 2016, 3:49 п.п.) Review request for kde-workspace,

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126704/#review90985 --- src/iconthemesmodel.cpp (line 54)

Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126704/ --- Review request for kde-workspace, Aleix Pol Gonzalez and Harald Sitter.