Re: Zanshin is in kdereview

2017-07-19 Thread Kevin Ottens
Hello, On Sunday, 2 July 2017 12:33:47 CEST Albert Astals Cid wrote: > El diumenge, 2 de juliol de 2017, a les 1:58:52 CEST, Kevin Ottens va > > It's been a week now without objection or further change requests. It's > > been in kdereview for three weeks now. Shall we more to extragear/pim > >

Re: Zanshin is in kdereview

2017-07-06 Thread Sandro Knauß
Hey, > > But I don't see why you are not just link against the relevant parts of > > kdepim and remove the copy. And than tell kdepim that you are using these > > files, so the team can take that into account when touching the files. > > As I mentioned earlier I don't because that is private API

Re: Zanshin is in kdereview

2017-07-03 Thread laurent Montel
Le dimanche 2 juillet 2017, 18:43:38 CEST Kevin Ottens a écrit : > > But what I can say from my work in Debian is that often Debian needs to > > coordinate the discussion to get rid of copies, that could have been > > avoided if the different projects had been talking directly with each > >

Re: Zanshin is in kdereview

2017-07-03 Thread Sandro Knauß
Hey, > 2) the third one (libkdepim) I'm forbidden to link against since it's private API to kdepim (turned into a dumping ground apparently...). > > Obviously, as soon as libkdepim is cleaned up (which I regularly hear it's > supposed to happen) and features are moved in proper frameworks I'll

Re: Zanshin is in kdereview

2017-07-02 Thread Kevin Ottens
Hello, On Sunday, 2 July 2017 13:52:48 CEST Sandro Knauß wrote: > > 2) the third one (libkdepim) I'm forbidden to link against since it's > > private API to kdepim (turned into a dumping ground apparently...). > > > > Obviously, as soon as libkdepim is cleaned up (which I regularly hear it's > >

Re: Zanshin is in kdereview

2017-07-02 Thread Albert Astals Cid
El diumenge, 2 de juliol de 2017, a les 1:58:52 CEST, Kevin Ottens va escriure: > Hello, > > On Sunday, 25 June 2017 14:00:05 CEST Kevin Ottens wrote: > > On Thursday, 8 June 2017 09:36:51 CEST Kevin Ottens wrote: > > > OK, this time it's the right one. :-) >

Re: Zanshin is in kdereview

2017-07-01 Thread Kevin Ottens
Hello, On Sunday, 25 June 2017 14:00:05 CEST Kevin Ottens wrote: > On Thursday, 8 June 2017 09:36:51 CEST Kevin Ottens wrote: > > OK, this time it's the right one. :-) > > > > Zanshin is now in kdereview and aiming for extragear/pim. Please review > > away! > >

Re: Zanshin is in kdereview

2017-06-25 Thread Kevin Ottens
Hello, On Thursday, 8 June 2017 09:36:51 CEST Kevin Ottens wrote: > OK, this time it's the right one. :-) > > Zanshin is now in kdereview and aiming for extragear/pim. Please review > away! > > Thanks in advance. So I pushed just now all the patches mentioned in this t

Re: Zanshin is in kdereview

2017-06-23 Thread Kevin Ottens
Hello, On Friday, 23 June 2017 16:11:12 CEST Luigi Toscano wrote: > On Friday, 23 June 2017 16:08:31 CEST Kevin Ottens wrote: > > On Tuesday, 20 June 2017 22:14:33 CEST Kevin Ottens wrote: > > > On Monday, 19 June 2017 21:50:16 CEST Luigi Toscano wrote: > > > > [...] > > > > I'm not sure why you

Re: Zanshin is in kdereview

2017-06-23 Thread Luigi Toscano
On Friday, 23 June 2017 16:08:31 CEST Kevin Ottens wrote: > Hello, > > On Tuesday, 20 June 2017 22:14:33 CEST Kevin Ottens wrote: > > On Monday, 19 June 2017 21:50:16 CEST Luigi Toscano wrote: > > > [...] > > > I'm not sure why you didn't like the above solution. > > > > Just more work over

Re: Zanshin is in kdereview

2017-06-23 Thread Kevin Ottens
Hello, On Tuesday, 20 June 2017 22:14:33 CEST Kevin Ottens wrote: > On Monday, 19 June 2017 21:50:16 CEST Luigi Toscano wrote: > > [...] > > I'm not sure why you didn't like the above solution. > > Just more work over time, and I don't have the bandwidth ATM. Typically we > tend to assume ki18n

Re: Zanshin is in kdereview

2017-06-21 Thread Kevin Ottens
Hello, On Saturday, 10 June 2017 15:08:36 CEST Kevin Ottens wrote: > On Thursday, 8 June 2017 13:03:35 CEST Jonathan Riddell wrote: > > If I stop Akonadi it silently stops working, an error message might be > > informative. > > I'll see what can be done, I'll need to investigate on how best to

Re: Zanshin is in kdereview

2017-06-20 Thread Kevin Ottens
Hello, On Monday, 19 June 2017 21:50:16 CEST Luigi Toscano wrote: > Kevin Ottens ha scritto: > > On Monday, 19 June 2017 18:56:39 CEST Luigi Toscano wrote: > >> On Monday, 19 June 2017 18:50:23 CEST Kevin Ottens wrote: > >>> On Tuesday, 13 June 2017 00:07:01 CEST Albert Astals Cid wrote: >

Re: Zanshin is in kdereview

2017-06-20 Thread Kevin Ottens
Hello, On Monday, 19 June 2017 23:11:09 CEST Albert Astals Cid wrote: > That makes no sense, the kxmlgui code will call i18n(), so you need to have > it in a .mo file not on a .ts file. Fair enough, I abandoned that patch, did another one to switch to i18n everywhere instead:

Re: Zanshin is in kdereview

2017-06-20 Thread Kevin Ottens
Hello, On Monday, 19 June 2017 21:49:26 CEST Jonathan Riddell wrote: > On Mon, Jun 19, 2017 at 09:36:39PM +0200, Kevin Ottens wrote: > > Looks like I just didn't clone at the right time. > > > > That said, there's something fishy with the signature: > > https://paste.kde.org/pgh6b1em7 > >

Re: Zanshin is in kdereview

2017-06-19 Thread Albert Astals Cid
El dilluns, 19 de juny de 2017, a les 18:50:23 CEST, Kevin Ottens va escriure: > Hello, > > On Tuesday, 13 June 2017 00:07:01 CEST Albert Astals Cid wrote: > > Have you read the page that speaks about how to write Messages.sh files? > > It's quite good. Please read it and explain what you don't

Re: Zanshin is in kdereview

2017-06-19 Thread Luigi Toscano
Kevin Ottens ha scritto: > Hello, > > On Monday, 19 June 2017 18:56:39 CEST Luigi Toscano wrote: >> On Monday, 19 June 2017 18:50:23 CEST Kevin Ottens wrote: >>> On Tuesday, 13 June 2017 00:07:01 CEST Albert Astals Cid wrote: Have you read the page that speaks about how to write Messages.sh

Re: Zanshin is in kdereview

2017-06-19 Thread Jonathan Riddell
On Mon, Jun 19, 2017 at 09:36:39PM +0200, Kevin Ottens wrote: > Hello, > > On Monday, 12 June 2017 16:48:26 CEST Jonathan Riddell wrote: > > On 10 June 2017 at 14:08, Kevin Ottens wrote: > > >> You have a release script in scripts/release.sh, consider using > > >> kde:releaseme as

Re: Zanshin is in kdereview

2017-06-19 Thread Kevin Ottens
Hello, On Monday, 19 June 2017 18:56:39 CEST Luigi Toscano wrote: > On Monday, 19 June 2017 18:50:23 CEST Kevin Ottens wrote: > > On Tuesday, 13 June 2017 00:07:01 CEST Albert Astals Cid wrote: > > > Have you read the page that speaks about how to write Messages.sh files? > > > It's quite good.

Re: Zanshin is in kdereview

2017-06-19 Thread Kevin Ottens
Hello, On Monday, 12 June 2017 16:48:26 CEST Jonathan Riddell wrote: > On 10 June 2017 at 14:08, Kevin Ottens wrote: > >> You have a release script in scripts/release.sh, consider using > >> kde:releaseme as extracting translations can be quite faffy and > >> releaseme does all

Re: Zanshin is in kdereview

2017-06-19 Thread Luigi Toscano
On Monday, 19 June 2017 18:50:23 CEST Kevin Ottens wrote: > Hello, > > On Tuesday, 13 June 2017 00:07:01 CEST Albert Astals Cid wrote: > > Have you read the page that speaks about how to write Messages.sh files? > > It's quite good. Please read it and explain what you don't understand. > > It's

Re: Zanshin is in kdereview

2017-06-19 Thread Kevin Ottens
Hello, On Tuesday, 13 June 2017 00:07:01 CEST Albert Astals Cid wrote: > Have you read the page that speaks about how to write Messages.sh files? > It's quite good. Please read it and explain what you don't understand. It's more that I don't quite see clearly the distribution of the .po and such

Re: Zanshin is in kdereview

2017-06-12 Thread Albert Astals Cid
time it's the right one. :-) > > > > > > Zanshin is now in kdereview and aiming for extragear/pim. Please review > > > away! > > > > Oh, you use kparts, but use a tr() based system instead of a i18n one. > > > > Can I ask why? > > Because it got started

Re: Zanshin is in kdereview

2017-06-12 Thread Jonathan Riddell
On 10 June 2017 at 14:08, Kevin Ottens wrote: >> You have a release script in scripts/release.sh, consider using >> kde:releaseme as extracting translations can be quite faffy and >> releaseme does all that for you. > > I tried that recently but didn't manage to get it to work at

Re: Zanshin is in kdereview

2017-06-10 Thread Kevin Ottens
Hello, On Thursday, 8 June 2017 22:12:10 CEST Albert Astals Cid wrote: > Sincerely i'd just suggest to kill the 3rdparty folder altogether, if you're > concerned about people not being able to compile your thing you're better > server just providing an appimage/snap/flatpack. It's more that: 1)

Re: Zanshin is in kdereview

2017-06-10 Thread Kevin Ottens
Hello, On Thursday, 8 June 2017 19:24:54 CEST Albert Astals Cid wrote: > El dijous, 8 de juny de 2017, a les 9:36:51 CEST, Kevin Ottens va escriure: > > OK, this time it's the right one. :-) > > > > Zanshin is now in kdereview and aiming for extragear/pim. Please review &

Re: Zanshin is in kdereview

2017-06-10 Thread Kevin Ottens
Hello, On Thursday, 8 June 2017 13:03:35 CEST Jonathan Riddell wrote: > There's some GPL 2 only files in 3rdparty/kdepim, if they are used it > means the applications can only be copied as GPL 2, consider > contacting the copyright holders to fix this as it doesn't match the > rest of the source.

Re: Zanshin is in kdereview

2017-06-08 Thread Albert Astals Cid
an error message might be > informative. > > On my KDE neon User Edition install if I run Kontact it appears fine > but on closing Kontact it crashes, this doesn't happen if I don't have > Zanshin installed. > > Looks lovely otherwise > > Jonathan > > On 8 June 2017 at

Re: Zanshin is in kdereview

2017-06-08 Thread Albert Astals Cid
El dijous, 8 de juny de 2017, a les 9:36:51 CEST, Kevin Ottens va escriure: > Hello, > > OK, this time it's the right one. :-) > > Zanshin is now in kdereview and aiming for extragear/pim. Please review > away! Oh, you use kparts, but use a tr() based system instead of a i1

Re: Zanshin is in kdereview

2017-06-08 Thread Jonathan Riddell
On 8 June 2017 at 08:36, Kevin Ottens <er...@kde.org> wrote: > Hello, > > OK, this time it's the right one. :-) > > Zanshin is now in kdereview and aiming for extragear/pim. Please review away! > > Thanks in advance. > > Regards. > -- > Kévin Ottens,

Zanshin is in kdereview

2017-06-08 Thread Kevin Ottens
Hello, OK, this time it's the right one. :-) Zanshin is now in kdereview and aiming for extragear/pim. Please review away! Thanks in advance. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description