Re: Review Request: Don't hang when determining MIME type of corrupted files

2011-08-25 Thread David Faure
On Monday 22 August 2011 20:12:13 Miroslav Ľos wrote: On Aug. 21, 2011, 10:07 a.m., David Faure wrote: Thanks Peter and Miroslav. The analysis looks correct, the pre-read part of the patch looks good. I'm just wondering about using Unbuffered. If someone installs a mimetype definition

Re: Review Request: GSoC: Errors handling during file transfer.

2011-08-25 Thread David Faure
On Wednesday 24 August 2011 16:24:05 Cyril Oblikov wrote: I wrote: But did you at least run jobtest (in kdelibs/kio/tests) to make sure that the new code doesn't break it? E.g. the creation of a dialog for sure broke it, but now you've fixed that bit. No, I didn't use tests. Are there

Re: playground-libs/libkvkontakte has moved to kdereview

2011-08-25 Thread Alexander Potashev
2011/8/9 Alexander Potashev aspotas...@gmail.com: playground-libs/libkvkontakte moved to kdereview today. The next target for this project is extragear/libs. libkvkontakte has been in kdereview for more than two weeks already. Is it OK to move it into extragear-libs now? -- Alexander

Re: Re: playground-libs/libkvkontakte has moved to kdereview

2011-08-25 Thread Albert Astals Cid
A Dijous, 25 d'agost de 2011, Alexander Potashev vàreu escriure: 2011/8/9 Alexander Potashev aspotas...@gmail.com: playground-libs/libkvkontakte moved to kdereview today. The next target for this project is extragear/libs. libkvkontakte has been in kdereview for more than two weeks

Re: Re: playground-libs/libkvkontakte has moved to kdereview

2011-08-25 Thread Alexander Potashev
2011/8/25 Albert Astals Cid aa...@kde.org: I thought you were going to get rid of the private members and use a d-pointer instead? What is the point of this? I think it will be OK to keep all class members in the main (public) classes and use d-ptr only in case of real necessity. --

Re: Re: Re: playground-libs/libkvkontakte has moved to kdereview

2011-08-25 Thread Albert Astals Cid
A Dijous, 25 d'agost de 2011, Alexander Potashev vàreu escriure: 2011/8/25 Albert Astals Cid aa...@kde.org: I thought you were going to get rid of the private members and use a d-pointer instead? What is the point of this? I think it will be OK to keep all class members in the main

Re: Re: Re: playground-libs/libkvkontakte has moved to kdereview

2011-08-25 Thread Alexander Potashev
2011/8/25 Albert Astals Cid aa...@kde.org: The point is that usually you do not know what the library will end up doing and by using d-pointers everywhere you make it easier for yourself to maintain binary compatibility in the future. But in the case that most classes won't grow in the future

Re: Review Request: Fix KUrlCompletionPrivate::urlCompletion's behavior

2011-08-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102425/#review6007 --- This review has been submitted with commit

Re: kdeinit

2011-08-25 Thread Alex Fiestas
Something I'm going to do, and I hope that some of the metalworkers will follow is to get involved in the new platform (uStuff, NM, BlueZ...), only by winning our relevance we will be able to control the platform again. Also, I'd like to point something: In number of people I think that KDE

Review Request: Allow externally deleted files to be removed from view in Dolphin

2011-08-25 Thread Tirtha Chatterjee
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102435/ --- Review request for KDE Base Apps and Peter Penz. Summary ---

Review Request: Support GnuPG2 in KNewstuff3

2011-08-25 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102439/ --- Review request for kdelibs. Summary --- So far knewstuff has gpg

Re: Review Request: Support GnuPG2 in KNewstuff3

2011-08-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102439/#review6018 --- This review has been submitted with commit