Review Request: Write to the correct xmlFile in KToolBar::Private::slotContextShowText()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103812/ --- Review request for kdelibs and David Faure. Description --- KToolBar::Private::slotContextShowText() was assuming that the xmlgui file it had to write was KGlobal::mainComponent.componentName() + ui.rc; which is obviously wrong since we have a setXMLFile function for a reason. I tried using xmlguiClient-xmlFile() directly but in Okular we use the same the same toolbar name defined in two xml files, so that still did not work because this means we end up with just one KToolbar (yes i know that might be a misuse of the API). So i ended up going through the actioncollections to find the action and get the correct client from there. This addresses bug 292574. http://bugs.kde.org/show_bug.cgi?id=292574 Diffs - kdeui/widgets/ktoolbar.cpp cce242b Diff: http://git.reviewboard.kde.org/r/103812/diff/diff Testing --- Fixes the issue in Okular, i tested it does still work with Kate that is using the ui.rc scheme. Thanks, Albert Astals Cid
Re: Review Request: Report file errors when extracting files using karchive
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103808/#review10174 --- kdecore/io/karchive.h http://git.reviewboard.kde.org/r/103808/#comment8363 Needs doxygen documentation - Albert Astals Cid On Jan. 28, 2012, 12:09 p.m., Theofilos Intzoglou wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103808/ --- (Updated Jan. 28, 2012, 12:09 p.m.) Review request for kdelibs. Description --- A simple patch to check if something goes wrong when extracting files from an archive. You can read the error code using copyToErrorCode() Diffs - kdecore/io/karchive.h 7cd7c0c kdecore/io/karchive.cpp 86d61d5 Diff: http://git.reviewboard.kde.org/r/103808/diff/diff Testing --- Thanks, Theofilos Intzoglou
Re: Review Request: Report file errors when extracting files using karchive
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103808/ --- (Updated Jan. 28, 2012, 4:46 p.m.) Review request for kdelibs. Changes --- * Added doxygen documentation Description --- A simple patch to check if something goes wrong when extracting files from an archive. You can read the error code using copyToErrorCode() Diffs (updated) - kdecore/io/karchive.h 7cd7c0c kdecore/io/karchive.cpp 86d61d5 Diff: http://git.reviewboard.kde.org/r/103808/diff/diff Testing --- Thanks, Theofilos Intzoglou
Re: Review Request: Report file errors when extracting files using karchive
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103808/#review10182
---
Not sure if this is 4.x material or frameworks-only (I occasionally see
karchive undergoing some changes there). Only returning errors from that
QFile::write call seems weird IMHO (other parts of the code may fail too).
kdecore/io/karchive.h
http://git.reviewboard.kde.org/r/103808/#comment8364
The documentation is still missing the @since tag.
kdecore/io/karchive.cpp
http://git.reviewboard.kde.org/r/103808/#comment8367
If you're just breaking out of the loop in the next iteration, why not do
something like this:
while (remainingSize 0) {
// yadda, yadda
if (f.write(...) == -1) {
d-fileError = f.error();
break;
}
}
- Raphael Kubo da Costa
On Jan. 28, 2012, 4:46 p.m., Theofilos Intzoglou wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103808/
---
(Updated Jan. 28, 2012, 4:46 p.m.)
Review request for kdelibs.
Description
---
A simple patch to check if something goes wrong when extracting files from an
archive. You can read the error code using copyToErrorCode()
Diffs
-
kdecore/io/karchive.h 7cd7c0c
kdecore/io/karchive.cpp 86d61d5
Diff: http://git.reviewboard.kde.org/r/103808/diff/diff
Testing
---
Thanks,
Theofilos Intzoglou
Review Request: Add yet another code generation option for having invokable methods
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103815/ --- Review request for kdelibs and David Faure. Description --- The patch addresses the current issue, for instance with QML-based KDE UIs. There is no clean way currently for having, for example a Settings page for a KDE Mobile application, and interact with the backend (generated code) directly from the QML bits. The current workaround is to have proxy methods in a helper class that are properly exposed to QML. There are no visible drawbacks for this extension as far as a programmer might wanna expose it on wish. :) The patch has a minor drawback because it puts the static keyword in line with the rest of the method declaration, so resides the Q_INVOKABLE macro. It is not any source or binary incompatible change though, just generated code-style internals. The patch is simpler and cleaner this way, and I personally prefer the not split declaration as well. Although this is behind the main point of the addition, thus can be altered, if needed. Diffs - kdecore/kconfig_compiler/README.dox b9606f1 kdecore/kconfig_compiler/kconfig_compiler.cpp 4203d30 Diff: http://git.reviewboard.kde.org/r/103815/diff/diff Testing --- Tested and works properly on Archlinux (build- and runtime). The Q_INVOKABLE accessor and mutator methods are properly generated. That said, it is being planned against the frameworks branch since no new features involved in the KDE4.X series anymore. Thanks, Laszlo Papp
