Re: Review Request: Fix a VLC crash by delaying object deletion to avoid invalid access by QtDBus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100577/#review10221 --- I think this is the same crash that happens every time in

Re: Review Request: Add option to control PAM support

On Jan. 29, 2012, 4:42 p.m., Alexander Neundorf wrote: The change in FindPAM.cmake is wrong. FindPAM.cmake does not care whether WITH_PAM is TRUE or not, when called, it will search PAM. If WITH_PAM is disabled, FindPAM.cmake will not be executed, and additionally all PAM_*

Re: Review Request: Fix a VLC crash by delaying object deletion to avoid invalid access by QtDBus

On Monday, 30 de January de 2012 08.05.50, Cristian Oneț wrote: Diffs - kio/bookmarks/kbookmarkmanager.cc d8a9cb7 kio/kio/fileundomanager.cpp f580c29 kio/kio/scheduler.cpp 6b36d9d Diff: http://git.reviewboard.kde.org/r/100577/diff/diff Do you have a valgrind trace of the

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Jan. 30, 2012, 2:28 p.m.) Review request for KDE Base Apps and

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/#review10232 --- Isn't it better to move FindKDeclarative.cmake to the

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Jan. 30, 2012, 4:35 p.m.) Review request for KDE Base Apps and

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/#review10238 --- ksmserver/FindKDeclarative.cmake

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Jan. 30, 2012, 5:08 p.m.) Review request for KDE Base Apps and

Re: Review Request: Port shutdown dialog to QML

On Jan. 30, 2012, 3:40 p.m., Raphael Kubo da Costa wrote: Isn't it better to move FindKDeclarative.cmake to the top-level cmake/modules directory with the other find-files? No if the intention is to prevent the file from being installed, which is the case here. On Jan. 30, 2012, 3:40

Re: Review Request: Port shutdown dialog to QML

On Jan. 30, 2012, 4:44 p.m., Raphael Kubo da Costa wrote: ksmserver/FindKDeclarative.cmake, line 14 http://git.reviewboard.kde.org/r/103621/diff/8/?file=48390#file48390line14 Where is Copyright.txt? :) If you move this file to cmake/modules you can share the license

Review Request: Make the writeConfig() method a public slot

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103829/ --- Review request for kdelibs and David Faure. Description ---

Re: Review Request: Make the writeConfig() method a public slot

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103829/#review10251 --- Ship it! That looks pretty straightforward and makes sense.

Re: Review Request: Make the writeConfig() method a public slot

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103829/#review10252 --- AFAIK, changing the order of virtual member functions might

Re: Review Request: Make the writeConfig() method a public slot

On Jan. 30, 2012, 10:21 p.m., Frank Reininghaus wrote: AFAIK, changing the order of virtual member functions might break binary compatibility: http://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ Sorry about that, I missed the Branch: frameworks. - Frank