Re: Review Request: Fix KShortcut to really allow the usage of multiple shortcuts

2012-05-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104801/#review13648 --- As documented, the shortcut(types) method allows to retrieve

Re: Review Request: Move the Preferred Web shorcut selection checkbox into its own column

2012-05-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104900/#review13653 --- Preferred? I'm confused. Aren't the checked keywords the only

Re: Review Request: Fix KShortcut to really allow the usage of multiple shortcuts

2012-05-10 Thread David Faure
On May 10, 2012, 8:38 a.m., David Faure wrote: As documented, the shortcut(types) method allows to retrieve either the current shortcuts (like most other methods), or the *default* shortcuts, i.e. those that were set by the application developer initially, before the user could make

Re: Review Request: Plasma Components: TextField and TextArea: Show placeholders even if item has the focus

2012-05-10 Thread Sebastian Kügler
On May 9, 2012, 6:30 p.m., Mark Gaiser wrote: Ehh optional perhaps? I've seen forms behave like this before and back then when i first saw it i tried to delete the text.. Which obviously didn't happen. The text just disappears as soon as i start typing. I kinda dislike that behavior.

Re: Review Request: Plasma Components: TextField and TextArea: Show placeholders even if item has the focus

2012-05-10 Thread Sebastian Kügler
On May 9, 2012, 6:30 p.m., Mark Gaiser wrote: Ehh optional perhaps? I've seen forms behave like this before and back then when i first saw it i tried to delete the text.. Which obviously didn't happen. The text just disappears as soon as i start typing. I kinda dislike that behavior.

Re: Review Request: Plasma Components: TextField and TextArea: Show placeholders even if item has the focus

2012-05-10 Thread David Edmundson
On May 9, 2012, 6:30 p.m., Mark Gaiser wrote: Ehh optional perhaps? I've seen forms behave like this before and back then when i first saw it i tried to delete the text.. Which obviously didn't happen. The text just disappears as soon as i start typing. I kinda dislike that behavior.

Re: Review Request: Plasma Components: TextField and TextArea: Show placeholders even if item has the focus

2012-05-10 Thread David Edmundson
On May 9, 2012, 6:30 p.m., Mark Gaiser wrote: Ehh optional perhaps? I've seen forms behave like this before and back then when i first saw it i tried to delete the text.. Which obviously didn't happen. The text just disappears as soon as i start typing. I kinda dislike that behavior.

Re: Review Request: Plasma Components: TextField and TextArea: Show placeholders even if item has the focus

2012-05-10 Thread Sebastian Gottfried
On May 9, 2012, 6:30 p.m., Mark Gaiser wrote: Ehh optional perhaps? I've seen forms behave like this before and back then when i first saw it i tried to delete the text.. Which obviously didn't happen. The text just disappears as soon as i start typing. I kinda dislike that behavior.

Re: Review Request: Move the Preferred Web shorcut selection checkbox into its own column

2012-05-10 Thread Dawit Alemayehu
On May 10, 2012, 8:41 a.m., David Faure wrote: Preferred? I'm confused. Aren't the checked keywords the only ones that work, and the other ones are disabled? IMHO this is enabled/disabled, not preferred (which sounds like the other ones are working, just harder to reach) Nope.

Re: Review Request: Move the Preferred Web shorcut selection checkbox into its own column

2012-05-10 Thread David Faure
On May 10, 2012, 8:41 a.m., David Faure wrote: Preferred? I'm confused. Aren't the checked keywords the only ones that work, and the other ones are disabled? IMHO this is enabled/disabled, not preferred (which sounds like the other ones are working, just harder to reach) Dawit

Review Request: kjs: Update Error.prototype.toString to ECMA Edition 5.1r6 format

2012-05-10 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104907/ --- Review request for kdelibs. Description --- kjs: Update

Review Request: kjs: Introduce use leftFirst parameter in relation check, according to Ecmascript 5.1r6.

2012-05-10 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104906/ --- Review request for kdelibs. Description --- kjs: Introduce use

Review Request: kjs: Fix Errorprototype inheritance

2012-05-10 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104908/ --- Review request for kdelibs. Description --- kjs: Fix Errorprototype

Re: Review Request: Plasma Components: TextField and TextArea: Show placeholders even if item has the focus

2012-05-10 Thread Mark Gaiser
On May 9, 2012, 6:30 p.m., Mark Gaiser wrote: Ehh optional perhaps? I've seen forms behave like this before and back then when i first saw it i tried to delete the text.. Which obviously didn't happen. The text just disappears as soon as i start typing. I kinda dislike that behavior.

Re: The Nepomuk Situation

2012-05-10 Thread Vishesh Handa
Does anyone have any objections to the current plan? * Remove kde-runtime/nepomuk * All nepomuk development happens in nepomuk-core * nepomuk-core will install everything with a Nepomuk2 namespace * Applications will have to explicitly depend on nepomuk-core if they want to use the new APIs

Re: Review Request: Plasma Components: TextField and TextArea: Show placeholders even if item has the focus

2012-05-10 Thread Laszlo Papp
On May 9, 2012, 6:30 p.m., Mark Gaiser wrote: Ehh optional perhaps? I've seen forms behave like this before and back then when i first saw it i tried to delete the text.. Which obviously didn't happen. The text just disappears as soon as i start typing. I kinda dislike that behavior.

Re: The Nepomuk Situation

2012-05-10 Thread Alex Fiestas
Seems perfect, no breaking, no kdelibs modification.