Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-10-04 Thread Aleix Pol
On Wed, Oct 3, 2012 at 6:21 PM, Marco Martin notm...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106124/ On October 3rd, 2012, 3:42 p.m., *Martin Gräßlin* wrote: It's submitted, isn't it? yep, marked as such - Marco

Re: Review LibKdeAccessibilityClient

2012-10-04 Thread Frederik Gladhorn
Hi, so after we took the time to hack a bit more on the library in Randa, I would be happy about more comments. The plan is to use it for our tools (currently Simon and Magnifier), so the only thing I didn't do is to change it to depend on ECM. I find the CMake part is quite nice now, it

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-10-04 Thread Jonathan Marten
Aleix Pol aleix...@kde.org writes: FWIW, I'd suggest to redesign the Screen Saver KCM now, it looks terribly unusable... Does anybody have a plan there? I started looking at this (initially to address bug 57572, the ability to select the savers used by Random) recently. Since it turned out

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-10-04 Thread Aleix Pol
On Thu, Oct 4, 2012 at 2:37 PM, Jonathan Marten j...@keelhaul.demon.co.uk wrote: Aleix Pol aleix...@kde.org writes: FWIW, I'd suggest to redesign the Screen Saver KCM now, it looks terribly unusable... Does anybody have a plan there? I started looking at this (initially to address bug

Re: Review Request: Check if the startDir has an schema before discarting it

2012-10-04 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106475/#review19914 --- Causes a regression. When using Save Image As... in Konqueror,

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

2012-10-04 Thread Stephen Kelly
Alexander Neundorf wrote: On Monday 01 October 2012, David Faure wrote: On Monday 01 October 2012 09:53:22 Stephen Kelly wrote: Instead, I say we should do a 'pain free' update to 2.8.7 now, and an update to 2.8.11 later. Yes. I disagree. If we upgrade now, I want to have at least

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

2012-10-04 Thread Stephen Kelly
Alexander Neundorf wrote: On Monday 01 October 2012, David Faure wrote: On Monday 01 October 2012 09:53:22 Stephen Kelly wrote: Instead, I say we should do a 'pain free' update to 2.8.7 now, and an update to 2.8.11 later. Yes. I disagree. If we upgrade now, I want to have at least