Re: Adopting AppData in KDE?

2013-11-05 Thread Richard Hughes
On 4 November 2013 21:29, Weng Xuetian wen...@gmail.com wrote: It's not about NoDisplay, plasmoids is a kind of widgets on KDE desktop, it also use desktop file to store metadata, though it's not sit in share/applications but some kde private folder. But each small widget is like an small

Re: Review Request 113630: Port the original KDE4 ksplash theme to QML

2013-11-05 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113630/#review43036 --- Didn't test. But it doesn't have that fancy fade-blur-in

Re: Review Request 113630: Port the original KDE4 ksplash theme to QML

2013-11-05 Thread Martin Klapetek
On Nov. 5, 2013, 10:21 a.m., Kai Uwe Broulik wrote: ksplash/ksplashqml/themes/Classic/main.qml, line 29 http://git.reviewboard.kde.org/r/113630/diff/1/?file=209049#file209049line29 Do we even need this? It's not like the splash did or would ever be resolution independent I think

Re: Review Request 113630: Port the original KDE4 ksplash theme to QML

2013-11-05 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113630/ --- (Updated Nov. 5, 2013, 10:42 a.m.) Review request for kde-workspace.

Re: Review Request 113518: KDM/KFrontend: Avoid potentially exploitable privilege dropping

2013-11-05 Thread Martin Bříza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113518/ --- (Updated Nov. 5, 2013, 10:49 a.m.) Review request for kde-workspace and

Re: Adopting AppData in KDE?

2013-11-05 Thread henry miller
Sven Brauch svenbra...@googlemail.com wrote: Let's not make a fight of this. I think the point that some people (including me) didn't find the strategy for creating a standard quite optimal was made, and we should drop it now and focus on discussing the adoption of the specification. I want

Re: Adopting AppData in KDE?

2013-11-05 Thread Weng Xuetian
On Monday, November 04, 2013 08:58:22 PM Richard Hughes wrote: On 4 November 2013 20:56, Weng Xuetian wen...@gmail.com wrote: Some questions: 1. What about non-application case? In GNOME we only consider an application to have a desktop file without NoDisplay=true. That's probably a

Re: Adopting AppData in KDE?

2013-11-05 Thread Weng Xuetian
Some questions: 1. What about non-application case? KDE plasmoid, and some kcm worked as a plugin in system setttings, some of them also present a desktop, which doesn't theoratically an application, but I think should be able to install from app center. 2. What if an application doesn't

Re: Adopting AppData in KDE?

2013-11-05 Thread Aaron J. Seigo
On Tuesday, November 5, 2013 08:28:08 Richard Hughes wrote: On 4 November 2013 21:29, Weng Xuetian wen...@gmail.com wrote: It's not about NoDisplay, plasmoids is a kind of widgets on KDE desktop, it also use desktop file to store metadata, though it's not sit in share/applications but

Re: Adopting AppData in KDE?

2013-11-05 Thread Richard Hughes
On 5 November 2013 12:06, Aaron J. Seigo ase...@kde.org wrote: plasmapkg -i pathtopackage Sure, but what does that do? Does that copy a file in a special directory or something? Richard.

Re: Adopting AppData in KDE?

2013-11-05 Thread Aaron J. Seigo
On Tuesday, November 5, 2013 12:08:57 Richard Hughes wrote: On 5 November 2013 12:06, Aaron J. Seigo ase...@kde.org wrote: plasmapkg -i pathtopackage Sure, but what does that do? it should be of no concern to the installer. what it does is an implementation detail. it may even change

Re: Adopting AppData in KDE?

2013-11-05 Thread Richard Hughes
On 5 November 2013 12:18, Aaron J. Seigo ase...@kde.org wrote: why do you need to know this? can AppStream not call external tools to do the installation? The way AppStream is generated in Fedora is we: * Take the binary rpm file * Explode it somewhere (without installing it) * Parse the

Re: Review Request 113630: Port the original KDE4 ksplash theme to QML

2013-11-05 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113630/#review43052 --- ksplash/ksplashqml/themes/Classic/Theme.rc

Re: Review Request 113630: Port the original KDE4 ksplash theme to QML

2013-11-05 Thread Martin Klapetek
On Nov. 5, 2013, 1:07 p.m., Sebastian Kügler wrote: ksplash/ksplashqml/themes/Classic/main.qml, line 132 http://git.reviewboard.kde.org/r/113630/diff/2/?file=209134#file209134line132 This looks odd? Yes, the last icon (the image itself) is actually bigger than the rest :S -

Review Request 113642: Fix warnings about annotations in DBus XML for KWallet

2013-11-05 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113642/ --- Review request for kdelibs. Repository: kdelibs Description ---

Review Request 113644: Fix Standalone Build for KWallet

2013-11-05 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113644/ --- Review request for kdelibs and Aurélien Gâteau. Repository: kdelibs

Review Request 113643: Fix Standalone Configuration for KJobWidgets

2013-11-05 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113643/ --- Review request for kdelibs and Aurélien Gâteau. Repository: kdelibs

Re: Review Request 113644: Fix Standalone Build for KWallet

2013-11-05 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113644/#review43056 --- Looks good, thanks! Note: you should use the kdeframeworks

Re: Review Request 113644: Fix Standalone Build for KWallet

2013-11-05 Thread David Narváez
On Nov. 5, 2013, 1:51 p.m., Aurélien Gâteau wrote: Looks good, thanks! Note: you should use the kdeframeworks group instead of the kdelibs group for KF5 review requests. Sorry for the inconvenience, I fixed my other reviews accordingly. - David

Re: Can we make api.kde.org search better?

2013-11-05 Thread Aleix Pol
On Sat, Nov 2, 2013 at 5:59 PM, Allen Winter win...@kde.org wrote: On Saturday, November 02, 2013 12:15:15 AM Albert Astals Cid wrote: Hi, yesterday i was talking with someone about the desktop file class we have in KDE, he tried to find its api by going to api.kde.org and typing

Re: Adopting AppData in KDE?

2013-11-05 Thread Aaron J. Seigo
On Tuesday, November 5, 2013 12:57:28 Richard Hughes wrote: On 5 November 2013 12:18, Aaron J. Seigo ase...@kde.org wrote: why do you need to know this? can AppStream not call external tools to do the installation? The way AppStream is generated in Fedora is we: ok ... this is separate

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-05 Thread Kevin Ottens
On Nov. 4, 2013, 4:12 p.m., John Layt wrote: I've asked on the Qt Development list about Qt 5 Solaris support. I'm told it builds and works to some extent, and patches are welcome, but not without having been tested on a real Solaris build first, which I have no desire to do. I

Re: Review Request 113630: Port the original KDE4 ksplash theme to QML

2013-11-05 Thread Martin Klapetek
On Nov. 5, 2013, 1:07 p.m., Sebastian Kügler wrote: ksplash/ksplashqml/themes/Classic/main.qml, line 95 http://git.reviewboard.kde.org/r/113630/diff/2/?file=209134#file209134line95 Encapsulate the NumberAnimation into its own file. It should be easy to change. How would that go?

Re: Review Request 113630: Port the original KDE4 ksplash theme to QML

2013-11-05 Thread Sebastian Kügler
On Nov. 5, 2013, 1:07 p.m., Sebastian Kügler wrote: ksplash/ksplashqml/themes/Classic/main.qml, line 95 http://git.reviewboard.kde.org/r/113630/diff/2/?file=209134#file209134line95 Encapsulate the NumberAnimation into its own file. It should be easy to change. Martin Klapetek

KF5 Update Meeting Minutes 2013-w45

2013-11-05 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 43 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, apol, d_ed, dfaure, dMaggot, mgraesslin, Riddell, sandsmark, sebas, svuorela, teo and myself. * afiestas is working toward completion of

Re: KF5 Update Meeting Minutes 2013-w45

2013-11-05 Thread Dominik Haumann
On Tuesday 05 November 2013 17:13:01 Milian Wolff wrote: On Tuesday 05 November 2013 17:04:47 Kevin Ottens wrote: snip * sandsmark cleaned up KTextEditorSpellingInterface; I think this was discussed before, but I forgot it again :( The KTextEditor stuff, will it stay in KDELibs for

Re: KF5 Update Meeting Minutes 2013-w45

2013-11-05 Thread Dominik Haumann
On Tuesday 05 November 2013 17:20:27 Dominik Haumann wrote: On Tuesday 05 November 2013 17:13:01 Milian Wolff wrote: On Tuesday 05 November 2013 17:04:47 Kevin Ottens wrote: snip * sandsmark cleaned up KTextEditorSpellingInterface; I think this was discussed before, but I forgot

Re: Adopting AppData in KDE?

2013-11-05 Thread Matthias Klumpp
2013/11/5 Aaron J. Seigo ase...@kde.org: On Tuesday, November 5, 2013 12:57:28 Richard Hughes wrote: On 5 November 2013 12:18, Aaron J. Seigo ase...@kde.org wrote: why do you need to know this? can AppStream not call external tools to do the installation? The way AppStream is generated in

Re: Adopting AppData in KDE?

2013-11-05 Thread Todd
On Nov 5, 2013 12:49 PM, Weng Xuetian wen...@gmail.com wrote: On Monday, November 04, 2013 08:58:22 PM Richard Hughes wrote: On 4 November 2013 20:56, Weng Xuetian wen...@gmail.com wrote: Some questions: 1. What about non-application case? In GNOME we only consider an application to

Re: Adopting AppData in KDE?

2013-11-05 Thread Richard Hughes
On 5 November 2013 17:12, Todd toddr...@gmail.com wrote: For project_group/, I think it would be good to allow arbitrary groups rather than limiting it to only a few recognized groups. I think restricting it to the desktops specified in the menu-spec makes sense. I think it would be good too

Re: Adopting AppData in KDE?

2013-11-05 Thread Todd
On Nov 5, 2013 5:18 PM, Todd toddr...@gmail.com wrote: On Nov 5, 2013 12:49 PM, Weng Xuetian wen...@gmail.com wrote: On Monday, November 04, 2013 08:58:22 PM Richard Hughes wrote: On 4 November 2013 20:56, Weng Xuetian wen...@gmail.com wrote: Some questions: 1. What about

Re: Review Request 113644: Fix Standalone Build for KWallet

2013-11-05 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113644/ --- (Updated Nov. 5, 2013, 5:27 p.m.) Status -- This change has been

Re: Adopting AppData in KDE?

2013-11-05 Thread Richard Hughes
On 5 November 2013 17:37, Todd toddr...@gmail.com wrote: Define ChangeLog? You mean what changed between versions? Yes, as well as the version number and date, probably. I'd be open to ideas about this. Can you file an issue and we can talk about possible ideas there. In this case you can

Re: Review Request 113518: KDM/KFrontend: Avoid potentially exploitable privilege dropping

2013-11-05 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113518/#review43117 --- what exploit do you have in mind? - Oswald Buddenhagen On

Re: Adopting AppData in KDE?

2013-11-05 Thread Richard Hughes
On 5 November 2013 18:42, Todd toddr...@gmail.com wrote: Okay, but if this is going to be a separate file with outs own spec then it is probably outside the scope of this project. But the two efforts could be coordinated. Well, I'm not saying it's out of scope for AppData, I'm simply saying

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-11-05 Thread shivam makkar
On Oct. 25, 2013, 7:58 p.m., Xuetian Weng wrote: Could you also post a preview for French ? It should have 4 symbol on one key, I'd like to how that looks. Seems you didn't parse the led information? (It's ok to leave it there) Some key name doesn't looks correct (F1 - F12), could

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-11-05 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/ --- (Updated Nov. 5, 2013, 8:22 p.m.) Review request for KDE Runtime,

Re: Adopting AppData in KDE?

2013-11-05 Thread Matthias Klumpp
2013/11/5 Todd toddr...@gmail.com: [...] Looking at the spec, I have a few suggestions: (I assume you mean the AppStream spec) For project_group/, I think it would be good to allow arbitrary groups rather than limiting it to only a few recognized groups. This is another gatekeeper issue: no

Re: Adopting AppData in KDE?

2013-11-05 Thread Matthias Klumpp
Hi! In order to solve the translation-issues: I think KDE could very well use Scripty to insert translations into the AppData files. However, I am currently thinking about adding a new element to specify a gettext-domian to fetch trabslations from. The problem is that, in order for the AppStream

Re: Adopting AppData in KDE?

2013-11-05 Thread Daniel Nicoletti
2013/11/5 Matthias Klumpp matth...@tenstral.net: Hi! In order to solve the translation-issues: I think KDE could very well use Scripty to insert translations into the AppData files. However, I am currently thinking about adding a new element to specify a gettext-domian to fetch trabslations

Re: Adopting AppData in KDE?

2013-11-05 Thread Marco Martin
On Saturday 02 November 2013 15:06:26 Aaron J. Seigo wrote: On Saturday, November 2, 2013 14:35:10 Matthias Klumpp wrote: What I see as truly invaluable in AppStream is standardizing the metadata for Free software applications. It is something Bodega will undoubtedly benefit from as well.

Re: Adopting AppData in KDE?

2013-11-05 Thread Matthias Klumpp
2013/11/5 Marco Martin notm...@gmail.com: [...] use cases (not to mention more general web based ones) unserviced. Can you please clarify what AppStream is missing for mobile? Ignoring the lack of UI (that’s fixable): non-repository based listings and installation, anything that isn’t an

Re: Can we make api.kde.org search better?

2013-11-05 Thread Albert Astals Cid
El Dimarts, 5 de novembre de 2013, a les 15:17:05, Aleix Pol va escriure: On Sat, Nov 2, 2013 at 5:59 PM, Allen Winter win...@kde.org wrote: On Saturday, November 02, 2013 12:15:15 AM Albert Astals Cid wrote: Hi, yesterday i was talking with someone about the desktop file class we have