Re: Review Request 113858: Add .reviewboardrc

2013-11-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113858/#review44661 --- This review has been submitted with commit

Re: Review Request 113858: Add .reviewboardrc

2013-11-28 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113858/ --- (Updated Nov. 28, 2013, 9:35 a.m.) Status -- This change has been

Re: Review Request 114105: kcm proxy: fix for noProxyFor setting when 'system proxy' type

2013-11-28 Thread Andrea Iacovitti
On Nov. 28, 2013, 5:17 a.m., Dawit Alemayehu wrote: konqueror/settings/kio/kproxydlg.cpp, line 295 http://git.reviewboard.kde.org/r/114105/diff/1/?file=219633#file219633line295 nitpick: no need for KSaveIOConfig here. ?. Not sure what do you mean On Nov. 28, 2013, 5:17 a.m.,

Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows

2013-11-28 Thread Nico Kruber
On July 1, 2013, 3:27 p.m., Martin Gräßlin wrote: from my side it looks OK, though I won't give a ship-it. This is a decision to the kinfocenter developers whether they are fine with the ifdefs. we'd like to include it in the next release and since the last message in this review request

Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows

2013-11-28 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/#review44671 --- Ship it! Besides the i18n misssing, sure, ship it, i don't

Re: Review Request 114105: kcm proxy: fix for noProxyFor setting when 'system proxy' type

2013-11-28 Thread Dawit Alemayehu
On Nov. 28, 2013, 5:17 a.m., Dawit Alemayehu wrote: konqueror/settings/kio/kproxydlg.cpp, line 295 http://git.reviewboard.kde.org/r/114105/diff/1/?file=219633#file219633line295 nitpick: no need for KSaveIOConfig here. Andrea Iacovitti wrote: ?. Not sure what do you mean

Re: Review Request 114105: kcm proxy: fix for noProxyFor setting when 'system proxy' type

2013-11-28 Thread Dawit Alemayehu
On Nov. 28, 2013, 5:17 a.m., Dawit Alemayehu wrote: konqueror/settings/kio/kproxydlg.cpp, line 444 http://git.reviewboard.kde.org/r/114105/diff/1/?file=219633#file219633line444 This does not make sense. I explicitly check show me the value and you uncheck it as a result of me

Re: Review Request 114105: kcm proxy: fix for noProxyFor setting when 'system proxy' type

2013-11-28 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114105/#review44690 --- Ship it! Minus this change =

Re: Review Request 112880: Added KColorSchemeToken class.

2013-11-28 Thread Kevin Ottens
On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: To get in this patch would benefit from being based on the frameworks branch and go into kdeclarative. Kevin Ottens wrote: Any chance for an update? Denis Kuplyakov wrote: Yes I will finish it, when have time. There are many

Re: Review Request 114105: kcm proxy: fix for noProxyFor setting when 'system proxy' type

2013-11-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114105/#review44709 --- This review has been submitted with commit

Re: Review Request 114105: kcm proxy: fix for noProxyFor setting when 'system proxy' type

2013-11-28 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114105/ --- (Updated Nov. 28, 2013, 4:16 p.m.) Status -- This change has been

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-11-28 Thread Mark Gaiser
On Nov. 26, 2013, 5:12 p.m., Kevin Ottens wrote: It's been stalled for almost three months now, any chance to see progress or should it be discarded? Mark Gaiser wrote: No, it should most certainly not be disgarded. It was even working when i posted this post up for review.

Re: Review Request 112880: Added KColorSchemeToken class.

2013-11-28 Thread Denis Kuplyakov
On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: To get in this patch would benefit from being based on the frameworks branch and go into kdeclarative. Kevin Ottens wrote: Any chance for an update? Denis Kuplyakov wrote: Yes I will finish it, when have time. There are many

Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows

2013-11-28 Thread David Stephen Hubner
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/#review44724 --- Hi, I maintain KInfoCenter :) Also agree on the shipping it,

Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

2013-11-28 Thread Burkhard Lück
On Nov. 22, 2013, 7:05 a.m., Ben Cooksley wrote: khelpcenter/plugintraverser.cpp, line 95 http://git.reviewboard.kde.org/r/111851/diff/1/?file=176031#file176031line95 Do you intend on modifying the control modules used by Dolphin and Konqueror here to fit this? That sounds like

Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

2013-11-28 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/ --- (Updated Nov. 28, 2013, 8:36 p.m.) Review request for Documentation, KDE

Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

2013-11-28 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/#review44734 --- In theory I have a possible solution using the existing

Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

2013-11-28 Thread David Faure
On Nov. 28, 2013, 8:42 p.m., Burkhard Lück wrote: In theory I have a possible solution using the existing X-KDE-PluginKeyword in the desktop files, so no changes outside khelpcenter would be required. But in contrary to the api documentation this does not work or I do wrong: $

Re: Review Request 112880: Added KColorSchemeToken class.

2013-11-28 Thread Kevin Ottens
On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: To get in this patch would benefit from being based on the frameworks branch and go into kdeclarative. Kevin Ottens wrote: Any chance for an update? Denis Kuplyakov wrote: Yes I will finish it, when have time. There are many