Re: Review Request 120580: [OS X] make KWalletD::connectToScreenSaver a stub function

2014-10-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120580/#review68428 --- I'd be interested to know the reason for connecting to the

Re: Gwenview maintainership

2014-10-15 Thread Aurélien Gâteau
On Tue, Oct 14, 2014, at 22:10, Lukáš Tinkl wrote: Dne 14.10.2014 v 17:51 Aurélien Gâteau napsal(a): For the past few months, I haven't been doing any work on KDE projects, and I don't see this changing for now. It's time for me to step down from the projects I maintain. This includes

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

2014-10-15 Thread René J . V . Bertin
On Oct. 14, 2014, 9:35 p.m., Thomas Lübking wrote: kioslave/trash/kcmtrash.cpp, line 220 https://git.reviewboard.kde.org/r/120573/diff/6/?file=318518#file318518line220 don't know about the exotic OS policy on this, but changes to i18n strings need to happen for new minors only

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

2014-10-15 Thread René J . V . Bertin
On Oct. 14, 2014, 9:35 p.m., Thomas Lübking wrote: kioslave/trash/trashimpl.cpp, line 362 https://git.reviewboard.kde.org/r/120573/diff/6/?file=318520#file318520line362 This can only make sense when a) init() created $TRASH/KDE.trash b) deleteEmptyTrashInfraStructure()

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

2014-10-15 Thread René J . V . Bertin
On Oct. 14, 2014, 11:13 p.m., David Faure wrote: kioslave/trash/trashimpl.cpp, line 854 https://git.reviewboard.kde.org/r/120573/diff/6/?file=318520#file318520line854 deleteEmptyTrashInfraStructure is implemented on all OSes, but only called on Mac, which seems a bit

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

2014-10-15 Thread René J . V . Bertin
On Oct. 14, 2014, 11:13 p.m., David Faure wrote: kioslave/trash/trashimpl.cpp, line 984 https://git.reviewboard.kde.org/r/120573/diff/6/?file=318520#file318520line984 Damn, if only we had known, we could have made the XDG spec closer to the OSX implementation just by adding es

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

2014-10-15 Thread René J . V . Bertin
On Oct. 14, 2014, 11:13 p.m., David Faure wrote: kioslave/trash/trashimpl.cpp, line 1043 https://git.reviewboard.kde.org/r/120573/diff/6/?file=318520#file318520line1043 such a debug statement is more useful if it prints out the input to the method, i.e. topdir. Point(s) taken.

Re: Gwenview maintainership

2014-10-15 Thread Vishesh Handa
Perhaps you could discuss the details on the list? I'm quite interested in these details, specially since I was fooling around on a gallery application based on the VDG mockups [1] [1] https://forum.kde.org/viewtopic.php?f=285t=122869 On Wed, Oct 15, 2014 at 8:56 AM, Aurélien Gâteau

Re: Gwenview maintainership

2014-10-15 Thread Aurélien Gâteau
With details I mean adminstrivia like handing over mailing list, bugzilla, reviewboard and friends, not much about the future of Gwenview itself. Aurélien On Wed, Oct 15, 2014, at 12:37, Vishesh Handa wrote: Perhaps you could discuss the details on the list? I'm quite interested in these

Re: [Kde-pim] [UPDATE] kdepimlibs Coverity Scan Report, Oct 14 2014

2014-10-15 Thread Allen Winter
On Wednesday, October 15, 2014 08:59:26 AM Georg C. F. Greve wrote: On Tuesday 14 October 2014 17.53:06 Allen Winter wrote: Attached ? yes, I see an html attachment

Re: Gwenview maintainership

2014-10-15 Thread Vishesh Handa
On Wed, Oct 15, 2014 at 1:28 PM, Aurélien Gâteau agat...@kde.org wrote: With details I mean adminstrivia like handing over mailing list, bugzilla, reviewboard and friends, not much about the future of Gwenview itself. Ah. Alright. -- Vishesh Handa

Re: SDDM-KCM In Review

2014-10-15 Thread Vishesh Handa
Hey David. None of these are blockers. Just stuff I noticed. * There is this strange ACKNOWLEDGEMENTS file * themeconfig.cpp ** The delegate seems to have a fixed size of 128x128. This might not be ideal for hidpi screens ** ThemeConfig::dump - Extra indendation * thememodel.cpp -

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

2014-10-15 Thread René J . V . Bertin
On Oct. 14, 2014, 11:13 p.m., David Faure wrote: kioslave/trash/trashimpl.cpp, line 170 https://git.reviewboard.kde.org/r/120573/diff/6/?file=318520#file318520line170 Shouldn't this return false like the other blocks? And then I would swap the if and else blocks,

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

2014-10-15 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/ --- (Updated Oct. 15, 2014, 6:26 p.m.) Review request for KDE Software on

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

2014-10-15 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120202/ --- (Updated Oct. 15, 2014, 9:51 p.m.) Review request for KDE Software on

Re: Review Request 120580: [OS X] make KWalletD::connectToScreenSaver a stub function

2014-10-15 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120580/ --- (Updated Oct. 15, 2014, 7:59 p.m.) Status -- This change has been

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

2014-10-15 Thread Thomas Lübking
On Okt. 14, 2014, 7:35 nachm., Thomas Lübking wrote: kioslave/trash/trashimpl.cpp, line 362 https://git.reviewboard.kde.org/r/120573/diff/6/?file=318520#file318520line362 This can only make sense when a) init() created $TRASH/KDE.trash b) deleteEmptyTrashInfraStructure()

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

2014-10-15 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120202/#review68511 --- Please check

Re: libkface

2014-10-15 Thread Albert Astals Cid
Hi Gilles we just found a problem in libkface. It has i18n() calls but no Messages.sh and no KCatalogLoader to load it's translation catalog. Can you please take care of fixing that? Cheers, Albert El Dissabte, 11 d'octubre de 2014, a les 14:33:32, Gilles Caulier va escriure: So, what's

Re: libkface

2014-10-15 Thread Gilles Caulier
2014-10-15 22:56 GMT+02:00 Albert Astals Cid aa...@kde.org: Hi Gilles we just found a problem in libkface. It has i18n() calls but no Messages.sh and no KCatalogLoader to load it's translation catalog. Can you please take care of fixing that? Done :

Re: Review Request 120554: Initial frameworks port of kompare

2014-10-15 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120554/ --- (Updated Oct. 15, 2014, 11:24 p.m.) Review request for kdelibs and Kevin