Re: Plasma 5.2 bits for kdereview
On Thu, Jan 8, 2015 at 11:54 AM, Kåre Särs kare.s...@iki.fi wrote: On Thursday 08 January 2015 21:52:48 Ian Wadham wrote: On 08/01/2015, at 9:40 PM, Vishesh Handa wrote: On Thu, Jan 8, 2015 at 7:39 AM, Ian Wadham iandw...@gmail.com wrote: - I don't think Windows has anything like Baloo or KWallet, but Apple OS X certainly has, and has had for years. We, on the KDE-Mac list, are starting to integrate KWallet and Apple's Keychain app, but Baloo is still an unknown quantity, esp. re how hard-wired it is into KDE apps. Side note: Windows has really good search capabilities. I have not seen or heard of them, and I go to a PC Users' Group regularly. Which version of Windows? Maybe 8? They actually have many more features than Mac's spotlight, but they lack the marketing and usability of spotlight. Baloo would be a bad fit on both windows and mac. I am sad to hear that. It would be nice if apps from KDE could keep indexing terms in the same place as Spotlight. Is there something stopping Baloo from becoming a thin wrapper around the native solutions when used on those platforms? (Except man power ;) /Kåre Well, that's not what Baloo is. Baloo is an indexing solutions. There's the possibility that we might want to abstract it out for whatever use-case, we'd want a different solution for that use-case. See Phonon vs mplayer. Aleix
Holes in KDE (fork of Changes in Git Infra thread)
Comment often heard: we've lost $person / we're missing people to maintain/lead/do $project. This is understandable, and to be expected in a large, mature project such as KDE. However, in #kde and #kde-devel IRC channels we have new people almost daily trying to find some way to get involved with KDE. In an effort to bring the solution and the problem together, at Akademy we brainstormed and came up with the Mission forum [1]. What that forum needs is postings! When you as a devel are thinking about giving up maintainership, please write a Maintainer Wanted post. When fixing bugs, and seeing a valuable bit of code which needs porting, please write that up and put it on the forum. Of course we always need ideas for possible GSoC projects, and the forum is a good place to post and develop those ideas. Naturally they will eventually have to be moved to our GSoC docs, but they can be discussed and refined on the forum. Needed documentation, internationalization, translation, artwork, promo, and web work are also suitable. If you have written a help wanted blog or ML post in the past, dig it out and post it on the forum. I know devels often don't like forums, but guess who does like them? Beginners and people who are using search engines. We need these people to join our community and start helping out. That will happen when we ask in a public place, which is the forum. Valorie 1. https://forum.kde.org/viewforum.php?f=291
Re: Holes in KDE (fork of Changes in Git Infra thread)
Hello Valorie, On 10/01/2015, at 1:56 PM, Valorie Zimmerman wrote: Comment often heard: we've lost $person / we're missing people to maintain/lead/do $project. This is understandable, and to be expected in a large, mature project such as KDE. However, in #kde and #kde-devel IRC channels we have new people almost daily trying to find some way to get involved with KDE. In an effort to bring the solution and the problem together, at Akademy we brainstormed and came up with the Mission forum [1]. What that forum needs is postings! When you as a devel are thinking about giving up maintainership, please write a Maintainer Wanted post. When fixing bugs, and seeing a valuable bit of code which needs porting, please write that up and put it on the forum. Of course we always need ideas for possible GSoC projects, and the forum is a good place to post and develop those ideas. Naturally they will eventually have to be moved to our GSoC docs, but they can be discussed and refined on the forum. Great idea! I think you should get it posted on kde-announce or somewhere where *everyone* in the KDE Community will see it, not just kde-core-devel. But ahem! Here is an immediate turnoff for newbies (or old Bs like me… :-)). https://forum.kde.org/viewforum.php?f=291 says (in part): Forum rules • You cannot post new topics in this forum • You cannot reply to topics in this forum • You cannot edit your posts in this forum • You cannot delete your posts in this forum So what CAN I do? This needs major re-phrasing --- hopefully as positives rather than negatives. Being a rebellious old B, I clicked the New Topic button anyway… :-) Then I was greeted with an invitation to log in with my KDE Identity. Luckily, I have one. Otherwise, I would have to register a new KDE Identity in order to reply, for example, to a maintainer wanted post(?) Do you want the KDE Identity service to accumulate newbies and casual enquirers? Also the registration requirement might make a newbie think he/she had to JOIN KDE (right now), when he/she is just following up an initial interest and wants to know more. Another possible turnoff. Speaking for myself, I almost invariably click away from sites that want you to register, unless I am really, really interested. Needed documentation, internationalization, translation, artwork, promo, and web work are also suitable. If you have written a help wanted blog or ML post in the past, dig it out and post it on the forum. I know devels often don't like forums, but guess who does like them? Beginners and people who are using search engines. We need these people to join our community and start helping out. That will happen when we ask in a public place, which is the forum. Maybe I sounded negative above, but I really would like to *use* a forum like this. I have five well-documented KDE Games to hand over to new maintainers and I am getting older every day… :-( All the best, Ian W. 1. https://forum.kde.org/viewforum.php?f=291
Re: Plasma 5.2 bits for kdereview
On Thu, Jan 8, 2015 at 11:54 AM, Kåre Särs kare.s...@iki.fi wrote: Is there something stopping Baloo from becoming a thin wrapper around the native solutions when used on those platforms? (Except man power ;) /Kåre Yup. Mostly man power, and that I don't care and/or have access to the other platforms. -- Vishesh Handa
Re: Plasma 5.2 bits for kdereview
On Thu, Jan 8, 2015 at 11:52 AM, Ian Wadham iandw...@gmail.com wrote: On 08/01/2015, at 9:40 PM, Vishesh Handa wrote: On Thu, Jan 8, 2015 at 7:39 AM, Ian Wadham iandw...@gmail.com wrote: - I don't think Windows has anything like Baloo or KWallet, but Apple OS X certainly has, and has had for years. We, on the KDE-Mac list, are starting to integrate KWallet and Apple's Keychain app, but Baloo is still an unknown quantity, esp. re how hard-wired it is into KDE apps. Side note: Windows has really good search capabilities. I have not seen or heard of them, and I go to a PC Users' Group regularly. Which version of Windows? Maybe 8? I know windows 7 has it. I've only mostly looked at it from the technical documentation - http://msdn.microsoft.com/en-us/library/bb787584(v=vs.85).aspx http://msdn.microsoft.com/en-us/library/cc678933(v=vs.85).aspx Plus the NTFS file system has a the USN Journal which would allow you to know what has changed since last run. That directly caters to file indexers. Also, they have really good file change notification systems. Unlike Linux. They actually have many more features than Mac's spotlight, but they lack the marketing and usability of spotlight. Baloo would be a bad fit on both windows and mac. I am sad to hear that. It would be nice if apps from KDE could keep indexing terms in the same place as Spotlight. Baloo is good in comparison to Spotlight. We mostly lack from the kernel side. When I said that Baloo would be a bad fit on Windows/Mac - I meant that it would work worse than the existing solutions, because it doesn't tap into the kernels and filesystem APIs that are available on Windows/Mac. Also, people often write extra indexers on those platforms which it would not get access to. -- Vishesh Handa
Re: Review Request 121930: [OS X] improvements to KSharedData
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121930/ --- (Updated Jan. 9, 2015, 3:25 p.m.) Status -- This change has been marked as submitted. Review request for KDE Software on Mac OS X, kdelibs and Allen Winter. Repository: kdelibs Description --- This patch improves KSharedData on 2 points: - It enables `KSDC_THREAD_PROCESS_SHARED_SUPPORTED` on OS X because even if the OS cannot do timeouts on mutex locking, it does have Posix mutexes (pthreads). I don't know why this was deactivated explicitly on OS X (do you remember, Allan?), but haven't seen issues with KSDC_THREAD_PROCESS_SHARED_SUPPORTED - for now. - OS X doesn't have `posix_fallocate()`, but an emulation of this function is available in the Mozilla code (reference found on StackOverflow). The code seems to be license-compatible, so I removed the code for non-OS X platforms, and include it in `kshareddatacache_p.h`. Again, this seems to work. Diffs - kdecore/util/kshareddatacache_p.h 931de4d kdecore/util/posix_fallocate_mac.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121930/diff/ Testing --- On OS X 10.9.5 with kdelibs 4.14.4 and KDE PIM 4.13.3 (I use KMail as my default MUA). Thanks, René J.V. Bertin
Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash
On Jan. 9, 2015, 1:27 a.m., David Faure wrote: Sorry, this one got drowned in the ML noise and I missed it After renaming idForDevice to idForMountPoint, please push to kde-runtime once the Applications 14.12 freeze is over. Then you'll have to forward-port this commit to the kio repository, where the kio_trash code has moved (and port your code to Qt5/KF5, although hopefully it's not a lot of work). When will that freeze be over? Also, think I introduced a (minor?) regression when I heeded a number of comments on Oct. 17th, and wrote _Trash infrastructure is now created only when really needed (please check if I forgot any cases), which does NOT include scanning the trash nor doing something with a trashed file (knowing a trashed file by name should mean the infrastruct. exists)._ The regression being that when you empty the OS X trash and then navigate to the wastebin in Dolphin, any KDE content that was in the trash is still shown; even the properties are still available. I haven't checked exactly why this is yet; should I, or could I use it as a check to see if anyone actually uses the feature enough to be bothered? ;) - René J.V. --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/#review73542 --- On Nov. 28, 2014, 12:04 a.m., René J.V. Bertin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/ --- (Updated Nov. 28, 2014, 12:04 a.m.) Review request for KDE Software on Mac OS X, KDE Runtime and David Faure. Repository: kde-runtime Description --- KDE on OS X does not handle the desktop session (no Plasma) nor can it rely on XDG to obtain the proper paths to use for something like the trash. As a result, all applications that propose to move things they manage to the wastebin (Dolphin, but also digiKam) will store those items in a place that has no particular meaning on OS X, and that will thus tend to fill up. OS X stores trash in one of several locations. Files trashed from the boot volume (and/or the volume containing $HOME, I don't actually know that) end up in `~/.Trash`. Files deleted from other volumes end up in `/Volumes/volName/.Trashes/uid`, where volName is the volume name (regardless whether it's an external or a remote drive; only mounted NFS shares are handled differently) and uid the numerical user id. Permissions on `.Trashes` are the same as those expected by KDE. The kio_trash kioslave appears to support several actual trash directory locations, just like OS X. `TrashImpl::init()` creates a standard trash in `~/.local/share/Trash` (at least under OS X) but also `TrashImpl::trashForMountPoint()` that is used in cases I have not yet encountered. On OS X, my modified `TrashImpl::init()` sets the standard trash directory to `~/.Trash/KDE.trash` and will create the `files` and `info` subdirectories as required, because they will of course be deleted when the user empties the OS X trash. `TrashImpl::fileRemoved()` has been modified to call a new function, `deleteEmptyTrashInfraStructure` to delete the KDE trash's internal infrastructure when the wastebin is empty so that OS X also sees the trash as emptied. (Since implementing `deleteEmptyTrashInfraStructure` this feature actually works, as expected as far as I can tell). Remains to be done: - determine in what cases `trashForMountPoint()` is used, and finish the modifications for it to use `/.Trashes/uid/KDE.trash` Diffs - kioslave/trash/trashimpl.cpp fe2e152 kioslave/trash/trashimpl.h bc68723 kioslave/trash/tests/CMakeLists.txt 9161fdf kioslave/trash/kcmtrash.cpp f4811fd kioslave/trash/CMakeLists.txt 3604089 Diff: https://git.reviewboard.kde.org/r/120573/diff/ Testing --- On OS X 10.6.8 with kdelibs and kde-runtime git/4.14, using Dolphin. Tested actions are - move items to wastebin from $HOME and a directory on a different volume - restore items to both places - empty wastebin through Dolphin - empty OS X trashcan Thanks, René J.V. Bertin
Adding experimental parts to a KF5 library
Hi, Because of the short release cycle for the frameworks, it is hard to have bigger new features included into one of them. Slowly evolving APIs while developing stuff leaves a lot of crud and deprecated methods later. What is our policy about having experimental (unstable API/ABI) parts in a framework (obviously, in a separate binary, so that the main library remains BC)? Cheerio, Ivan -- KDE, ivan.cu...@kde.org, http://ivan.fomentgroup.org/ gpg key id: 850B6F76
Re: Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4
On Jan. 9, 2015, 11:53 a.m., David Edmundson wrote: do you have commit access? No, I don't. - Armin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121084/#review73572 --- On Nov. 9, 2014, 4:10 p.m., Armin K. wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121084/ --- (Updated Nov. 9, 2014, 4:10 p.m.) Review request for KDE Runtime, KDE Frameworks and Plasma. Repository: kio-extras Description --- KDE-Runtime already provides libmolletnetwork, so lets rename this one to include 5 as a suffix since many apps outside of KDE still depend on KDE-Runtime. Diffs - network/ioslave/CMakeLists.txt 06a964d network/kded/CMakeLists.txt 3be676e network/network/CMakeLists.txt c0fb43e Diff: https://git.reviewboard.kde.org/r/121084/diff/ Testing --- Thanks, Armin K.
Re: Adding experimental parts to a KF5 library
On Fri, Jan 9, 2015 at 5:34 PM, Ivan Čukić ivan.cu...@kde.org wrote: Hi, Because of the short release cycle for the frameworks, it is hard to have bigger new features included into one of them. Slowly evolving APIs while developing stuff leaves a lot of crud and deprecated methods later. What is our policy about having experimental (unstable API/ABI) parts in a framework (obviously, in a separate binary, so that the main library remains BC)? Cheerio, Ivan The C++ committee uses (for example) std::experimental::something. Why don't we adapt the same in frameworks. There it would probably be: framework::experimental::something. Or Qt as another example, they simply say it's a technology preview :) I don't think they put it under a special namespace.
Re: Plasma 5.2 bits for kdereview
On Fri, Jan 9, 2015 at 5:12 PM, Vishesh Handa m...@vhanda.in wrote: Yup. Mostly man power, and that I don't care and/or have access to the other platforms. Minor correction: It's more about not having the motivation. Less about access. I actually do own a mac. -- Vishesh Handa
Re: Plasma 5.2 bits for kdereview
Hello Vishesh, On 10/01/2015, at 3:18 AM, Vishesh Handa wrote: On Thu, Jan 8, 2015 at 11:52 AM, Ian Wadham iandw...@gmail.com wrote: On 08/01/2015, at 9:40 PM, Vishesh Handa wrote: On Thu, Jan 8, 2015 at 7:39 AM, Ian Wadham iandw...@gmail.com wrote: - I don't think Windows has anything like Baloo or KWallet Side note: Windows has really good search capabilities. I have not seen or heard of them, and I go to a PC Users' Group regularly. Which version of Windows? Maybe 8? I know windows 7 has it. I've only mostly looked at it from the technical documentation - http://msdn.microsoft.com/en-us/library/bb787584(v=vs.85).aspx http://msdn.microsoft.com/en-us/library/cc678933(v=vs.85).aspx Plus the NTFS file system has a the USN Journal which would allow you to know what has changed since last run. That directly caters to file indexers. Also, they have really good file change notification systems. Unlike Linux. Thank you very much for the information… :-) I will bring it up with our local PC Users Group. Cheers, Ian W.
Re: Plasma 5.2 bits for kdereview
Hello Vishesh, On Thu, Jan 8, 2015 at 11:54 AM, Kåre Särs kare.s...@iki.fi wrote: Is there something stopping Baloo from becoming a thin wrapper around the native solutions when used on those platforms? (Except man power ;) On 10/01/2015, at 7:01 AM, Vishesh Handa wrote: On Fri, Jan 9, 2015 at 5:12 PM, Vishesh Handa m...@vhanda.in wrote: Yup. Mostly man power, and that I don't care and/or have access to the other platforms. Minor correction: It's more about not having the motivation. Less about access. I actually do own a mac. We have a growing number of contributors on the KDE-Mac list kde-...@kde.org. If one of them is interested in writing a wrapper for Spotlight/Baloo, would you be able to help in a purely advisory role? We could CC you, if you do not wish to join the KDE-Mac list. Cheers, Ian W.
Re: Review Request 121717: libksysguard/processtable: Add new column Relative Start Time
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121717/ --- (Updated Jan. 9, 2015, 10:25 a.m.) Review request for KDE Base Apps and John Tapsell. Changes --- ping? (I am not sure about the visibility of this RR. The kde-baseapps is big...) Repository: libksysguard Description (updated) --- This will add a new column Relative Start Time which shows how much time has elapsed since the process was started. Some details: - add new heading with default location between Shared Memory and Command and not visible by default - define What's this - define Tooltip - define sorting - add class TimeUtil with methods: - systemUptimeSeconds - systemUptimeAbsolute - secondsToHumanElapsedString (for this one a unit test was added, see chronotest.cpp) This code reformatting goes in separate commits: - ProcessModel.cpp: reformat code: consistent number of linebreaks between method definitions (1 blank line) - ProcessModel.h: reformat code: split long enum line into separte lines for better diffing Side note on sorting: I was wondering if the sorting of the PID column is exactly the same as with the new Relative Start Time column. When testing on my computer it was. But according to this post one cannot generally assume that sorting by PID will reflect the relative start order of the processes: http://stackoverflow.com/questions/822797/about-the-pid-of-the-process Diffs - processcore/process.h 85a3a13388c44f768040dbc6602ab3211edd5b21 processui/ksysguardprocesslist.cpp 894e9a4d42112e01e742f1b0a2bcd6be7a844258 processui/timeutil.h PRE-CREATION tests/CMakeLists.txt 0fb3ab620564abf09f82d1609fc464d5597b2bd3 tests/chronotest.h PRE-CREATION tests/chronotest.cpp PRE-CREATION processcore/process.cpp 190f4902fa6f3bae2d8b60dbf1a43be71beb1820 processcore/processes_linux_p.cpp 0cff0e8b407a087dc29f755b12ea3d784ba34e6a processui/ProcessModel.h a338536023f9d003a44bcb8420b9288f8673ea92 processui/ProcessModel.cpp 3acf52b92f4a8ca054d88aad1ec6b31f4a31f297 Diff: https://git.reviewboard.kde.org/r/121717/diff/ Testing --- Run ksysguard, show new column, sort in both directions. Minor issue: as the seconds pass the values in the new column will not be updated automatically unless there is some user interaction (like mouse hovering/moving or sorting). New unit test passes. Thanks, Gregor Mi
Re: Review Request 121930: [OS X] improvements to KSharedData
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121930/ --- (Updated Jan. 9, 2015, 3:19 p.m.) Review request for KDE Software on Mac OS X, kdelibs and Allen Winter. Repository: kdelibs Description --- This patch improves KSharedData on 2 points: - It enables `KSDC_THREAD_PROCESS_SHARED_SUPPORTED` on OS X because even if the OS cannot do timeouts on mutex locking, it does have Posix mutexes (pthreads). I don't know why this was deactivated explicitly on OS X (do you remember, Allan?), but haven't seen issues with KSDC_THREAD_PROCESS_SHARED_SUPPORTED - for now. - OS X doesn't have `posix_fallocate()`, but an emulation of this function is available in the Mozilla code (reference found on StackOverflow). The code seems to be license-compatible, so I removed the code for non-OS X platforms, and include it in `kshareddatacache_p.h`. Again, this seems to work. Diffs (updated) - kdecore/util/kshareddatacache_p.h 931de4d kdecore/util/posix_fallocate_mac.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121930/diff/ Testing --- On OS X 10.9.5 with kdelibs 4.14.4 and KDE PIM 4.13.3 (I use KMail as my default MUA). Thanks, René J.V. Bertin
Re: Review Request 121930: [OS X] improvements to KSharedData
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121930/#review73597 --- Ship it! kdecore/util/kshareddatacache_p.h https://git.reviewboard.kde.org/r/121930/#comment51245 just add that to the conditional above, no need to duplicate it here. sorry that I didn't spot this sooner - Milian Wolff On Jan. 9, 2015, 2:19 p.m., René J.V. Bertin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121930/ --- (Updated Jan. 9, 2015, 2:19 p.m.) Review request for KDE Software on Mac OS X, kdelibs and Allen Winter. Repository: kdelibs Description --- This patch improves KSharedData on 2 points: - It enables `KSDC_THREAD_PROCESS_SHARED_SUPPORTED` on OS X because even if the OS cannot do timeouts on mutex locking, it does have Posix mutexes (pthreads). I don't know why this was deactivated explicitly on OS X (do you remember, Allan?), but haven't seen issues with KSDC_THREAD_PROCESS_SHARED_SUPPORTED - for now. - OS X doesn't have `posix_fallocate()`, but an emulation of this function is available in the Mozilla code (reference found on StackOverflow). The code seems to be license-compatible, so I removed the code for non-OS X platforms, and include it in `kshareddatacache_p.h`. Again, this seems to work. Diffs - kdecore/util/kshareddatacache_p.h 931de4d kdecore/util/posix_fallocate_mac.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121930/diff/ Testing --- On OS X 10.9.5 with kdelibs 4.14.4 and KDE PIM 4.13.3 (I use KMail as my default MUA). Thanks, René J.V. Bertin
