Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-15 Thread Patrick Eigensatz
On Mai 15, 2015, 7:31 nachm., Martin Gräßlin wrote: thanks for rebasing! I just had a look at the bug report and have to agree with comment #1: I do from time to time copy on purpose whitespaces (yes I'm weird). I also tend to copy newlines and I do want to have them in the

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-15 Thread Thomas Pfeiffer
On May 15, 2015, 7:31 p.m., Martin Gräßlin wrote: thanks for rebasing! I just had a look at the bug report and have to agree with comment #1: I do from time to time copy on purpose whitespaces (yes I'm weird). I also tend to copy newlines and I do want to have them in the history.

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-15 Thread Kai Uwe Broulik
On Mai 15, 2015, 7:31 nachm., Martin Gräßlin wrote: thanks for rebasing! I just had a look at the bug report and have to agree with comment #1: I do from time to time copy on purpose whitespaces (yes I'm weird). I also tend to copy newlines and I do want to have them in the

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-15 Thread Thomas Pfeiffer
On May 15, 2015, 7:31 p.m., Martin Gräßlin wrote: thanks for rebasing! I just had a look at the bug report and have to agree with comment #1: I do from time to time copy on purpose whitespaces (yes I'm weird). I also tend to copy newlines and I do want to have them in the history.

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-15 Thread Thomas Lübking
On Mai 15, 2015, 7:31 nachm., Martin Gräßlin wrote: thanks for rebasing! I just had a look at the bug report and have to agree with comment #1: I do from time to time copy on purpose whitespaces (yes I'm weird). I also tend to copy newlines and I do want to have them in the

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-15 Thread Patrick Eigensatz
On Mai 15, 2015, 7:31 nachm., Martin Gräßlin wrote: thanks for rebasing! I just had a look at the bug report and have to agree with comment #1: I do from time to time copy on purpose whitespaces (yes I'm weird). I also tend to copy newlines and I do want to have them in the

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-15 Thread Thomas Pfeiffer
On May 15, 2015, 7:31 p.m., Martin Gräßlin wrote: thanks for rebasing! I just had a look at the bug report and have to agree with comment #1: I do from time to time copy on purpose whitespaces (yes I'm weird). I also tend to copy newlines and I do want to have them in the history.

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-15 Thread Patrick Eigensatz
On Mai 15, 2015, 7:31 nachm., Martin Gräßlin wrote: thanks for rebasing! I just had a look at the bug report and have to agree with comment #1: I do from time to time copy on purpose whitespaces (yes I'm weird). I also tend to copy newlines and I do want to have them in the

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

2015-05-15 Thread Thomas Lübking
On Mai 15, 2015, 2:27 nachm., Kai Uwe Broulik wrote: plasma-workspace/klipper/historyitem.cpp, line 89 https://git.reviewboard.kde.org/r/123797/diff/1/?file=369295#file369295line89 return nullptr; Patrick Eigensatz wrote: Thank you! Existing code uses everywhere return 0;, I

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

2015-05-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123797/#review80406 --- plasma-workspace/klipper/historyitem.cpp (line 88)

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

2015-05-15 Thread Patrick Eigensatz
On Mai 15, 2015, 2:27 nachm., Kai Uwe Broulik wrote: plasma-workspace/klipper/historyitem.cpp, line 89 https://git.reviewboard.kde.org/r/123797/diff/1/?file=369295#file369295line89 return nullptr; Thank you! Existing code uses everywhere return 0;, I can't find the

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

2015-05-15 Thread Patrick Eigensatz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123797/ --- (Updated Mai 15, 2015, 2:56 nachm.) Review request for kde-workspace and

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

2015-05-15 Thread Patrick Eigensatz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123797/ --- (Updated Mai 15, 2015, 2:24 nachm.) Review request for kde-workspace and

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

2015-05-15 Thread Thomas Lübking
On Mai 15, 2015, 2:27 nachm., Kai Uwe Broulik wrote: plasma-workspace/klipper/historyitem.cpp, line 89 https://git.reviewboard.kde.org/r/123797/diff/1/?file=369295#file369295line89 return nullptr; Patrick Eigensatz wrote: Thank you! Existing code uses everywhere return 0;, I

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-15 Thread Patrick Eigensatz
On Mai 15, 2015, 7:31 nachm., Martin Gräßlin wrote: thanks for rebasing! I just had a look at the bug report and have to agree with comment #1: I do from time to time copy on purpose whitespaces (yes I'm weird). I also tend to copy newlines and I do want to have them in the

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123806/#review80423 --- thanks for rebasing! I just had a look at the bug report and

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-15 Thread Kai Uwe Broulik
On Mai 15, 2015, 7:31 nachm., Martin Gräßlin wrote: thanks for rebasing! I just had a look at the bug report and have to agree with comment #1: I do from time to time copy on purpose whitespaces (yes I'm weird). I also tend to copy newlines and I do want to have them in the

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-15 Thread Thomas Lübking
On Mai 15, 2015, 7:31 nachm., Martin Gräßlin wrote: thanks for rebasing! I just had a look at the bug report and have to agree with comment #1: I do from time to time copy on purpose whitespaces (yes I'm weird). I also tend to copy newlines and I do want to have them in the

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

2015-05-15 Thread Patrick Eigensatz
On Mai 15, 2015, 2:27 nachm., Kai Uwe Broulik wrote: plasma-workspace/klipper/historyitem.cpp, line 89 https://git.reviewboard.kde.org/r/123797/diff/1/?file=369295#file369295line89 return nullptr; Patrick Eigensatz wrote: Thank you! Existing code uses everywhere return 0;, I

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

2015-05-15 Thread Martin Gräßlin
On May 15, 2015, 8:01 p.m., Martin Gräßlin wrote: This patch is against kde-workspace, but the development happens in plasma-workspace nowadays. Could you please rebase against the newer repository? Patrick Eigensatz wrote: Sorry, I saw your comment a bît too late. Can you tell

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

2015-05-15 Thread Patrick Eigensatz
On Mai 15, 2015, 6:01 nachm., Martin Gräßlin wrote: This patch is against kde-workspace, but the development happens in plasma-workspace nowadays. Could you please rebase against the newer repository? Patrick Eigensatz wrote: Sorry, I saw your comment a bît too late. Can you

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

2015-05-15 Thread Patrick Eigensatz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123797/ --- (Updated Mai 15, 2015, 6:33 nachm.) Review request for kde-workspace and

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-15 Thread Patrick Eigensatz
On Mai 15, 2015, 7:31 nachm., Martin Gräßlin wrote: thanks for rebasing! I just had a look at the bug report and have to agree with comment #1: I do from time to time copy on purpose whitespaces (yes I'm weird). I also tend to copy newlines and I do want to have them in the

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

2015-05-15 Thread Patrick Eigensatz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123797/ --- (Updated Mai 15, 2015, 6:45 nachm.) Status -- This change has been

Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-15 Thread Patrick Eigensatz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123806/ --- Review request for kde-workspace and Patrick Eigensatz. Bugs: 192922

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

2015-05-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123797/#review80420 --- Then just discard this review request and open a new one

Re: Review Request 123797: [PATCH] klipper: Ignore blank entries

2015-05-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123797/#review80412 --- This patch is against kde-workspace, but the development

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-15 Thread Thomas Pfeiffer
On May 15, 2015, 7:31 p.m., Martin Gräßlin wrote: thanks for rebasing! I just had a look at the bug report and have to agree with comment #1: I do from time to time copy on purpose whitespaces (yes I'm weird). I also tend to copy newlines and I do want to have them in the history.