Re: Review Request 121755: Fix input focus for KDM's dialogs when GrabInput is not active

2015-08-04 Thread Wolfgang Bauer
On Juli 31, 2015, 10:24 vorm., Oswald Buddenhagen wrote: the description makes a good commit message, so please make sure you use that (apart from adding the BUG lines). Yes, of course. It's not my first commit to kde-workspace and I always handled it like that, i.e. using my

Re: Review Request 121755: Fix input focus for KDM's dialogs when GrabInput is not active

2015-08-04 Thread Wolfgang Bauer
On Juli 30, 2015, 12:05 nachm., Thomas Lübking wrote: This is Qt4, right? ::activateWindow() should be equivalent to XSetInputFocus(display, winId(), XRevertToParent, X11-time); unless a) _NET_ACTIVE_WINDOW is listed in _NET_SUPPORTED on the root window (supposed to be set and

Re: Replacement for KDateTime

2015-08-04 Thread Thiago Macieira
On Tuesday 04 August 2015 17:52:18 Ben Cooksley wrote: I'm assuming QLocale isn't routed through the platform plugin like other parts of Qt do in these cases, so we can't manipulate things there? Right. If a LC_TIME solution isn't possible, we could consider a QSystemLocale configuration

Re: Review Request 121755: Fix input focus for KDM's dialogs when GrabInput is not active

2015-08-04 Thread Thomas Lübking
On Juli 30, 2015, 10:05 vorm., Thomas Lübking wrote: This is Qt4, right? ::activateWindow() should be equivalent to XSetInputFocus(display, winId(), XRevertToParent, X11-time); unless a) _NET_ACTIVE_WINDOW is listed in _NET_SUPPORTED on the root window (supposed to be set and

Re: Replacement for KDateTime

2015-08-04 Thread John Layt
On 4 August 2015 at 10:45, John Layt jl...@kde.org wrote: Most of this discussion is very very off-topic, it belongs on the Qt development list, can we get back to the main topic of KCalCore and QDateTime? I have limited time to spare and I'd rather use it to solve the immediate problems that

Re: Review Request 121755: Fix input focus for KDM's dialogs when GrabInput is not active

2015-08-04 Thread Wolfgang Bauer
On Juli 30, 2015, 12:05 nachm., Thomas Lübking wrote: This is Qt4, right? ::activateWindow() should be equivalent to XSetInputFocus(display, winId(), XRevertToParent, X11-time); unless a) _NET_ACTIVE_WINDOW is listed in _NET_SUPPORTED on the root window (supposed to be set and

Re: Replacement for KDateTime

2015-08-04 Thread Thiago Macieira
On Tuesday 04 August 2015 10:03:20 John Layt wrote: One problem would be to update running processes (QLocale to track the locale file and emit some signal on changes) This is one of the areas Qt doesn't do well, on Windows and Mac soon as the underlying locale is change you get different

Re: Replacement for KDateTime

2015-08-04 Thread Thiago Macieira
On Tuesday 04 August 2015 10:03:20 John Layt wrote: Nor do we want to use the data in the POSIX file as it has too many shortcomings and lacks features and simply uses a different set of format codes to CLDR. That POSIX file can only ever really be used to tell non-Qt POSIX locale using apps

Re: Replacement for KDateTime

2015-08-04 Thread Thomas Lübking
On Montag, 3. August 2015 23:17:04 CEST, John Layt wrote: Not nonsense, exactly my long-term plan to get Gtk and other apps to use the right Plasma locale settings when running under Plasma. It 'just' requires the kcm to learn how to write and compile a POSIX locale file. That actually

Re: Replacement for KDateTime

2015-08-04 Thread John Layt
On 4 August 2015 at 03:03, Thiago Macieira thi...@kde.org wrote: On Monday 03 August 2015 21:57:36 John Layt wrote: The problem actually is that Plasma is not considered a system platform by QLocale, it doesn't go looking for what Plasma wants, it just uses the underlying GNU/Linux system

Re: Review Request 121755: Fix input focus for KDM's dialogs when GrabInput is not active

2015-08-04 Thread Thomas Lübking
On Juli 30, 2015, 10:05 vorm., Thomas Lübking wrote: This is Qt4, right? ::activateWindow() should be equivalent to XSetInputFocus(display, winId(), XRevertToParent, X11-time); unless a) _NET_ACTIVE_WINDOW is listed in _NET_SUPPORTED on the root window (supposed to be set and

Re: Replacement for KDateTime

2015-08-04 Thread John Layt
On 2 August 2015 at 14:26, John Layt j...@layt.net wrote: On 1 August 2015 at 19:47, Sandro Knauß b...@sandroknauss.de wrote: * indivual timezone support, this is something that we need when parsing ical and have no known timezone information. I havn't looked into it, but I think this

Re: Review Request 121755: Fix input focus for KDM's dialogs when GrabInput is not active

2015-08-04 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121755/ --- (Updated Aug. 4, 2015, 5:53 p.m.) Status -- This change has been

Re: Review Request 121755: Fix input focus for KDM's dialogs when GrabInput is not active

2015-08-04 Thread Wolfgang Bauer
On Juli 30, 2015, 12:05 nachm., Thomas Lübking wrote: This is Qt4, right? ::activateWindow() should be equivalent to XSetInputFocus(display, winId(), XRevertToParent, X11-time); unless a) _NET_ACTIVE_WINDOW is listed in _NET_SUPPORTED on the root window (supposed to be set and