Re: Kdiff3 in kdereview

2018-09-03 Thread Albert Astals Cid
El dilluns, 3 de setembre de 2018, a les 17:38:35 CEST, Michael Reeves va 
escriure:
> The memory leak should be gone with the latest commit. This also resolve s
> one source of noise coming from code that is not needed as of QT 5.3.2.
> Tested up to looking at a two directory diff and opening of the files. All
> messages seem to be gone. Some unnecessary Windows specific code has been
> removed from FileAccess. It now handles directory searches the same way on
> any platform. Qt program's really shouldn't have to know the os they are
> running on in most cases. That's kind of the point of using it in the first
> place.

Sounds good :)

Cheers,
  Albert

> 
> On Fri, Aug 31, 2018, 6:45 PM Albert Astals Cid  wrote:
> 
> >
> > Good :)
> >
> > One minor thing, there seems to be some small issue with memory leaks on
> > optiondialog.
> >
> > If you compile with
> >cmake -DECM_ENABLE_SANITIZERS="undefined;address
> >
> > and then just run kdiff3 and close it, i get these leaks reported at the
> > end (amogsnst others that are noise) https://paste.kde.org/pp5k6jc6u
> >
> > Cheers,
> >   Albert
> >
> >
> >
> >
> 






Re: Kdiff3 in kdereview

2018-09-03 Thread Michael Reeves
The memory leak should be gone with the latest commit. This also resolve s
one source of noise coming from code that is not needed as of QT 5.3.2.
Tested up to looking at a two directory diff and opening of the files. All
messages seem to be gone. Some unnecessary Windows specific code has been
removed from FileAccess. It now handles directory searches the same way on
any platform. Qt program's really shouldn't have to know the os they are
running on in most cases. That's kind of the point of using it in the first
place.

On Fri, Aug 31, 2018, 6:45 PM Albert Astals Cid  wrote:

>
> Good :)
>
> One minor thing, there seems to be some small issue with memory leaks on
> optiondialog.
>
> If you compile with
>cmake -DECM_ENABLE_SANITIZERS="undefined;address
>
> and then just run kdiff3 and close it, i get these leaks reported at the
> end (amogsnst others that are noise) https://paste.kde.org/pp5k6jc6u
>
> Cheers,
>   Albert
>
>
>
>