Re: Review Request: Prevent crash in KJob::emitResult() if job is deleted

2010-12-01 Thread Albert Astals Cid
> On 2010-12-01 17:23:11, Kevin Ottens wrote: > > Well, if the job is explicitely isAutoDelete() then I'd say it's a bug in > > the caller to try to delete it in the first place... > > Aurélien Gâteau wrote: > I see your point, but on the other hand if the job is not *autodelete* > and the

Re: Review Request: Prevent crash in KJob::emitResult() if job is deleted

2010-12-01 Thread Andras Mantia
> On 2010-12-01 17:23:11, Kevin Ottens wrote: > > Well, if the job is explicitely isAutoDelete() then I'd say it's a bug in > > the caller to try to delete it in the first place... > > Aurélien Gâteau wrote: > I see your point, but on the other hand if the job is not *autodelete* > and the

Re: Review Request: Prevent crash in KJob::emitResult() if job is deleted

2010-12-01 Thread Aurélien Gâteau
> On 2010-12-01 17:23:11, Kevin Ottens wrote: > > Well, if the job is explicitely isAutoDelete() then I'd say it's a bug in > > the caller to try to delete it in the first place... I see your point, but on the other hand if the job is not *autodelete* and the slot connected to result() deletes

Re: Review Request: Prevent crash in KJob::emitResult() if job is deleted

2010-12-01 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6022/#review9080 --- Well, if the job is explicitely isAutoDelete() then I'd say it's a

Review Request: Prevent crash in KJob::emitResult() if job is deleted

2010-12-01 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6022/ --- Review request for kdelibs and Kevin Ottens. Summary --- If a someone c

Re: Review Request: Adding "net usershare" suport for KSambaShare

2010-12-01 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4320/#review9079 --- dfaure is still the best person to comment on the KDirWatch bits.

Re: Review Request: Adding "net usershare" suport for KSambaShare

2010-12-01 Thread Rodrigo Belem
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4320/ --- (Updated 2010-12-01 01:56:04.253124) Review request for kdelibs, Raphael Kub