Re: Review Request: Adjust the kde "fake" mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain

2010-12-20 Thread Rex Dieter
> On 2010-12-20 22:13:15, David Faure wrote: > > Looks good now. lxr finds no other usage of the mimetype. commited r1208194 - Rex --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6111/#re

Re: Review Request: Adjust the kde "fake" mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain

2010-12-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6111/#review9347 --- Ship it! Looks good now. lxr finds no other usage of the mimetype

Re: Review Request: Adjust the kde "fake" mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain

2010-12-20 Thread Rex Dieter
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6111/ --- (Updated 2010-12-20 21:52:20.637316) Review request for kdelibs. Changes -

Re: Review Request: Make KRecentDirs namespace and export krecentdirs.h

2010-12-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6142/#review9330 --- Ship it! @since 4.6 should be added to the API documentation, giv

Re: Review request

2010-12-20 Thread David Faure
On Friday 17 December 2010, Raphael Kubo da Costa wrote: > #define ALKIMIA_EXPORT KDE_EXPORT > > Isn't it preferable to create an alk_export.h, as is more usual > for libraries? Yes, otherwise it won't compile on Windows, where the export macro needs to be changed depending on "building