Re: Use Q_GLOBAL_STATIC where K_GLOBAL_STATIC is not needed?

2011-02-10 Thread Thiago Macieira
On Thursday, 10 de February de 2011 00:25:12 Olivier Goffart wrote: Q_GLOBAL_STATIC is not public API. Don't use it. Would it be an option to make it public API by documenting it or is that out of the question? I'm in favor of making it public API. Even if that is the case, KDE

Re: A Qt replacement for KGlobal::ref and deref

2011-02-10 Thread Thiago Macieira
Em quinta-feira, 10 de fevereiro de 2011, às 10:49:08, Stefan Majewsky escreveu: On Thu, Feb 10, 2011 at 9:14 AM, Thiago Macieira thi...@kde.org wrote: The correct way to solve this problem is to show another window indicating that it is doing something and tell me what. We solve both

Re: Merge or Cherry-Pick?

2011-02-10 Thread Ian Monroe
On Thu, Feb 10, 2011 at 04:31, Johannes Sixt j.s...@viscovery.net wrote: Am 2/10/2011 10:40, schrieb Ben Cooksley: On Thu, Feb 10, 2011 at 9:35 PM, Johannes Sixt j.s...@viscovery.net wrote:  git push origin KDE/4.6 This is wrong, as it would try to push the content of HEAD (the merge of

Re: A Qt replacement for KGlobal::ref and deref

2011-02-10 Thread Ian Monroe
On Thu, Feb 10, 2011 at 08:43, Thiago Macieira thi...@kde.org wrote: Em quinta-feira, 10 de fevereiro de 2011, às 10:49:08, Stefan Majewsky escreveu: On Thu, Feb 10, 2011 at 9:14 AM, Thiago Macieira thi...@kde.org wrote: The correct way to solve this problem is to show another window

Re: A Qt replacement for KGlobal::ref and deref

2011-02-10 Thread Thiago Macieira
Em quinta-feira, 10 de fevereiro de 2011, às 09:04:09, Ian Monroe escreveu: On Thu, Feb 10, 2011 at 08:43, Thiago Macieira thi...@kde.org wrote: Em quinta-feira, 10 de fevereiro de 2011, às 10:49:08, Stefan Majewsky escreveu: On Thu, Feb 10, 2011 at 9:14 AM, Thiago Macieira thi...@kde.org

Re: Use Q_GLOBAL_STATIC where K_GLOBAL_STATIC is not needed?

2011-02-10 Thread Alex Fiestas
On 02/10/2011 09:04 AM, Thiago Macieira wrote: Even if that is the case, KDE should use K_GLOBAL_STATIC, which is better than Q_GLOBAL_STATIC. I don't know why is better (I haven't check the code) but then, maybe we can add a new public macro to Qt with the goodness of K_GLOBAL_STATIC and

Re: Use Q_GLOBAL_STATIC where K_GLOBAL_STATIC is not needed?

2011-02-10 Thread Thiago Macieira
On Thursday, 10 de February de 2011 19:57:42 Alex Fiestas wrote: On 02/10/2011 09:04 AM, Thiago Macieira wrote: Even if that is the case, KDE should use K_GLOBAL_STATIC, which is better than Q_GLOBAL_STATIC. I don't know why is better (I haven't check the code) but then, maybe we can add

Re: Use Q_GLOBAL_STATIC where K_GLOBAL_STATIC is not needed?

2011-02-10 Thread Stephen Kelly
Thiago Macieira wrote: It should have been in a qglobalstatic_p.h. We might even do that -- and intentionally break applications that are abusing the API. A quick grep says that would break akonadi, grantlee, qca, phonon, qxt and a couple of places in KDE that use it already (presumably

Re: A Qt replacement for KGlobal::ref and deref

2011-02-10 Thread Stephen Kelly
Thiago Macieira wrote: Well, first of all, Thiago is not the highest authority in Qt. You just had my opinion, not of all people. Sure. I'd call a 'no' from any troll a veto. The only repsonse I got was a no on #qt-labs. That's the only way I have of reaching 'all people' until open

Re: A Qt replacement for KGlobal::ref and deref

2011-02-10 Thread Ingo Klöcker
On Thursday 10 February 2011, Stephen Kelly wrote: Thiago Macieira wrote: If the user can't get any kind of feedback, the application shouldn't be running anymore. System tray icons are a kind of feedback. Again, I might be missing something here. Does a systray icon already count

Re: Use Q_GLOBAL_STATIC where K_GLOBAL_STATIC is not needed?

2011-02-10 Thread Michael Pyne
On Thursday, February 10, 2011 16:35:20 Stephen Kelly wrote: Thiago Macieira wrote: On Thursday, 10 de February de 2011 21:08:05 Stephen Kelly wrote: Thiago Macieira wrote: It should have been in a qglobalstatic_p.h. We might even do that -- and intentionally break applications that are

Re: Use Q_GLOBAL_STATIC where K_GLOBAL_STATIC is not needed?

2011-02-10 Thread Thiago Macieira
On Thursday, 10 de February de 2011 17:11:42 Michael Pyne wrote: I say this as someone who uses QAtomicInt assuming a mode of operation that is not explicitly documented (i.e. it is safe to initialize its memory with 0 and avoid running the ctor). If Nokia changes it I would grumble, but it