Re: KEditListWidget

2011-03-18 Thread Fabrice Ménard
Le jeudi 17 mars 2011 23:40:32 Christoph Feck a écrit : Do you need it in 4.6.2? I can apply to trunk, but I won't touch branches until my git foo matures Trunk is ok for me. Thanks -- Fabrice Ménard

How to know if I'm showing a tooltip?

2011-03-18 Thread John Tapsell
Hi all, When the user hovers over an item, it shows a tooltip. I update that tooltip once a second using the following code: if(QToolTip::isVisible()) { QWidget *w = d-mUi-treeView-viewport(); if(w-geometry().contains(d-mUi-treeView-mapFromGlobal(

Dependencies Policy?

2011-03-18 Thread John Layt
Hi, I was wondering if we need to define a New Dependencies policy, or at least some guidelines to remind people what to think about when choosing or creating new dependencies? Something like: * All new dependencies must be advised to the kde-build and kde-packager lists * Any changes to KDE

Re: How to know if I'm showing a tooltip?

2011-03-18 Thread John Tapsell
On 18 March 2011 11:24, John Tapsell johnf...@gmail.com wrote: I've tried   window()-isActiveWindow()  which partially solves the problem, but it's possible to have a dialog box on top, but have the main window have the focus.. I figured it out - I just need: if

Re: Dependencies Policy?

2011-03-18 Thread Rex Dieter
John Layt wrote: I was wondering if we need to define a New Dependencies policy, or at least some guidelines to remind people what to think about when choosing or creating new dependencies? I would welcome a formal policy. here's some references I found to related existing documents and

KSambaShare destructor proposed patch

2011-03-18 Thread Fabrice Ménard
Hi, As KSambaShare and KDirWatch are global statics we must ensure that an object has not already been destroyed before calling anything on it. Regards, -- Fabrice Ménarddiff --git a/kio/kio/ksambashare.cpp b/kio/kio/ksambashare.cpp index e82f1b7..dfab22e 100644 --- a/kio/kio/ksambashare.cpp

Git Workflow - Outstanding Issues

2011-03-18 Thread John Layt
Hi, We still have some outstanding issues from the Git Workflow meeting a while back (see http://community.kde.org/20110213_GitWorkflowAgenda) which I'd like to see updated. * Workflow eean, steveire and PovAddict were to draw up alternative workflow proposals, steveire has drawn up one at

Re: KSambaShare destructor proposed patch

2011-03-18 Thread David Faure
On Friday 18 March 2011, Fabrice Ménard wrote: Hi, As KSambaShare and KDirWatch are global statics we must ensure that an object has not already been destroyed before calling anything on it. Looks good, please commit -- if you don't have a kde svn/git account yet, please get one, your

Re: Review Request: Fix handling of FTP urls whose path name ends with a type code

2011-03-18 Thread David Faure
On Wednesday 16 March 2011, Thiago Macieira wrote: Suggestion: path.left(path.length() - sizeof ;type=); Unreadable. sizeof(;type=) == strlen(;type=X) A hidden off-by-one, how nice to have in our code ;) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by

Re: Review Request: Patch for FTP ioslave unnecessarily asks for password

2011-03-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100873/#review2040 --- Hmm, this whole block is inside if (failedAuth0), so this means

Re: Git Workflow - Outstanding Issues

2011-03-18 Thread Wolfgang Rohdewald
On Freitag 18 März 2011, John Layt wrote: * Commit Template I've finally committed the Commit Template into kdelibs, any Git project that wants to use a different version can commit that to their own repo provided they follow the basic rules. would it be feasible to add a section like # --[

Re: Git Workflow - Outstanding Issues

2011-03-18 Thread Parker Coates
On Fri, Mar 18, 2011 at 23:25, Wolfgang Rohdewald wrote: On Freitag 18 März 2011, John Layt wrote: * Commit Template I've finally committed the Commit Template into kdelibs, any Git project that  wants to use a different version can commit that to their own repo provided they follow the basic

Re: Git Workflow - Outstanding Issues

2011-03-18 Thread Wolfgang Rohdewald
On Samstag 19 März 2011, Parker Coates wrote: On Fri, Mar 18, 2011 at 23:25, Wolfgang Rohdewald wrote: On Freitag 18 März 2011, John Layt wrote: * Commit Template I've finally committed the Commit Template into kdelibs, any Git project that wants to use a different version can commit

Re: Review Request: Patch for FTP ioslave unnecessarily asks for password

2011-03-18 Thread Dawit Alemayehu
On March 18, 2011, 11:22 p.m., David Faure wrote: Hmm, this whole block is inside if (failedAuth0), so this means kio_ftp tried to log in, but without using the cached credentials? Ah, probably because it tries anonymous first. Which kind of sucks on sites where you have recorded a

Re: Review Request: Patch for FTP ioslave unnecessarily asks for password

2011-03-18 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100873/ --- (Updated March 19, 2011, 4:37 a.m.) Review request for kdelibs. Changes