Re: Review Request: KIO Proxy Support Overhaul Part II: KProtocolManager & KIO::Scheduler

2011-04-06 Thread Dawit Alemayehu
> On April 6, 2011, 10:17 p.m., David Faure wrote: > > Thanks for working on this, iirc this is needed by many users. You are welcome. Yes, a lot of users that rely on PAC files (in corporate settings) have asked for these functionality for a very long time (back to the good old KDE 2.x days).

Re: Review Request: KIO Proxy Support Overhaul Part II: KProtocolManager & KIO::Scheduler

2011-04-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101037/#review2447 --- Ship it! Thanks for working on this, iirc this is needed by man

Re: Review request: Kcmgrub2

2011-04-06 Thread Michael Jansen
On Wednesday 06 April 2011 20:57:02 Alberto Mattea wrote: > In data mercoledì 6 aprile 2011 20:43:40, Michael Jansen ha scritto: > > > > You might also want to consider using KDE's > > > > macro_optional_find_package() together with macro_log_feature(), > > > > so you show a list of all the depende

Re: Review request: Kcmgrub2

2011-04-06 Thread Alberto Mattea
In data mercoledì 6 aprile 2011 20:43:40, Michael Jansen ha scritto: > > > You might also want to consider using KDE's > > > macro_optional_find_package() together with macro_log_feature(), so you > > > show a list of all the dependencies which have or have not been found > > > instead of failing a

Re: Review request: Kcmgrub2

2011-04-06 Thread Michael Jansen
> > You might also want to consider using KDE's > > macro_optional_find_package() together with macro_log_feature(), so you > > show a list of all the dependencies which have or have not been found > > instead of failing at the first one. > > > > I remember some discussions before about build-tim

Re: Review request: Kcmgrub2

2011-04-06 Thread Alberto Mattea
In data mercoledì 6 aprile 2011 20:01:32, Raphael Kubo da Costa ha scritto: > Alberto Mattea writes: > > In data mercoledì 6 aprile 2011 00:28:21, Raphael Kubo da Costa ha scritto: > >> Buildsystem-wise: > >> * I did not understand why you used include() instead of > >> > >> find_package() in,

Re: Review request: Kcmgrub2

2011-04-06 Thread Raphael Kubo da Costa
Alberto Mattea writes: > In data mercoledì 6 aprile 2011 00:28:21, Raphael Kubo da Costa ha scritto: >> Buildsystem-wise: >> >> * I did not understand why you used include() instead of >> find_package() in, for example, >> >> include(FindPyQt4) > > Actually I used an article on the KDE

Re: Review request: Kcmgrub2

2011-04-06 Thread Alberto Mattea
Hi, thanks for the review. In data mercoledì 6 aprile 2011 00:28:21, Raphael Kubo da Costa ha scritto: > Alberto Mattea writes: > > Hi all, > > after 4 releases I think kcmgrub2 has reached an acceptable level of > > maturity, so I'd ask for a move to kdereview. It is currently in > > playground-