Re: Review Request: kcm-grub2

> The following line should probably be simplified (see > http://websvn.kde.org/?revision=1184860&view=revision): > > src/kcm_grub2.cpp:113:QTreeWidgetItem *item = new > QTreeWidgetItem(ui.treeWidget_recover, QStringList(QString()) << name > << partition->filePath() << volume->l

Re: Review Request: Do not modify .fonts.conf when loading it. Now nothing is written before the user clicks apply or ok. Fixes Bug 105797.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101359/ --- (Updated May 25, 2011, 8:11 p.m.) Review request for KDE Base Apps and KDE

Re: Review Request: Catch a bogus username in a url intented to fool a user into visiting a site unintentionally

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101440/#review3535 --- This review has been submitted with commit 3bbd4496bc8a01e80df6

Re: [4.7 Beta1 blocker] plasma depending on kdelibs/experimental

On Wednesday, May 25, 2011 21:58:13 Marco Martin wrote: > just a reminder on this: > do we all agree it's a blocker? I would agree it's a blocker, kdelibs should not depend on KDE libraries which don't also have a stable ABI. > and that statically including that library in libplasma would be a s

Re: Review Request: Catch a bogus username in a url intented to fool a user into visiting a site unintentionally

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101440/ --- (Updated May 25, 2011, 11:34 p.m.) Review request for kdelibs and David Fa

Re: Review Request: Catch a bogus username in a url intented to fool a user into visiting a site unintentionally

> On May 25, 2011, 9:31 p.m., Albert Astals Cid wrote: > > kioslave/http/http.cpp, line 4334 > > > > > > You are not using i18nc correctly, you need to have the parameters > > inside the call, not use arg > > Alb

Re: Review Request: Catch a bogus username in a url intented to fool a user into visiting a site unintentionally

> On May 25, 2011, 9:31 p.m., Albert Astals Cid wrote: > > kioslave/http/http.cpp, line 4334 > > > > > > You are not using i18nc correctly, you need to have the parameters > > inside the call, not use arg Obvious

Re: Review Request: Catch a bogus username in a url intented to fool a user into visiting a site unintentionally

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101440/#review3530 --- kioslave/http/http.cpp

Re: getting rid of qt3support in kde-workspace

Am Mittwoch, 25. Mai 2011, 17:48:42 schrieb Aaron J. Seigo: > hi :) > > i just finished pushing a set of changes to the (ironically named?) > qt3support branch in kde-workspace which leaves no traces of qt3support or > kde3support left in that module. huzzah! > > i'm ok with holding on to the bra

Re: [4.7 Beta1 blocker] plasma depending on kdelibs/experimental

On Saturday 21 May 2011, Marco Martin wrote: > > > > I now discover this to be broken in master: > > > > plasma/widgets/declarativewidget.cpp requires kdeclarative.h which comes > > from libkdedeclarative in kdelibs/experimental > > > > Is the previous rule no longer valid? otherwise, how to dea

Re: getting rid of qt3support in kde-workspace

On Wednesday 25 May 2011, Boudewijn Rempt wrote: > On Wednesday 25 May 2011 May, Albert Astals Cid wrote: > > A Wednesday, May 25, 2011, Boudewijn Rempt va escriure: ... > > > (As well as QWidget/QPainter code, too, of course.) > > > > Hope you are really joking with this one. > > No, I'm not jok

Re: getting rid of qt3support in kde-workspace

A Wednesday, May 25, 2011, Boudewijn Rempt va escriure: > On Wednesday 25 May 2011 May, Albert Astals Cid wrote: > > A Wednesday, May 25, 2011, Boudewijn Rempt va escriure: > > > Best get it removed everywhere as soon as possible. > > > > Disagree, removing it for the sake of removing it, is just

Re: getting rid of qt3support in kde-workspace

On Wednesday 25 May 2011, Aaron J. Seigo wrote: > hi :) > > i just finished pushing a set of changes to the (ironically named?) > qt3support branch in kde-workspace which leaves no traces of qt3support or > kde3support left in that module. huzzah! Cool :-) > i'm ok with holding on to the branch

Re: getting rid of qt3support in kde-workspace

On Wednesday 25 May 2011 May, Albert Astals Cid wrote: > A Wednesday, May 25, 2011, Boudewijn Rempt va escriure: > > On Wed, 25 May 2011, Albert Astals Cid wrote: > > > A Wednesday, May 25, 2011, Aaron J. Seigo va escriure: > > >> hi :) > > >> > > >> i just finished pushing a set of changes to the

Re: getting rid of qt3support in kde-workspace

A Wednesday, May 25, 2011, Boudewijn Rempt va escriure: > On Wed, 25 May 2011, Albert Astals Cid wrote: > > A Wednesday, May 25, 2011, Aaron J. Seigo va escriure: > >> hi :) > >> > >> i just finished pushing a set of changes to the (ironically named?) > >> qt3support branch in kde-workspace which

Re: getting rid of qt3support in kde-workspace

On Wed, 25 May 2011, Albert Astals Cid wrote: A Wednesday, May 25, 2011, Aaron J. Seigo va escriure: hi :) i just finished pushing a set of changes to the (ironically named?) qt3support branch in kde-workspace which leaves no traces of qt3support or kde3support left in that module. huzzah! i'

Re: getting rid of qt3support in kde-workspace

A Wednesday, May 25, 2011, Aaron J. Seigo va escriure: > hi :) > > i just finished pushing a set of changes to the (ironically named?) > qt3support branch in kde-workspace which leaves no traces of qt3support or > kde3support left in that module. huzzah! > > i'm ok with holding on to the branch u

Review Request: Catch a bogus username in a url intented to fool a user into visiting a site unintentionally

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101440/ --- Review request for kdelibs and David Faure. Summary --- The attached

getting rid of qt3support in kde-workspace

hi :) i just finished pushing a set of changes to the (ironically named?) qt3support branch in kde-workspace which leaves no traces of qt3support or kde3support left in that module. huzzah! i'm ok with holding on to the branch until 4.8, but if there is interest in getting this into 4.7 it sho

Re: Review Request: Fix KFilePlacesModelTest failure

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101381/#review3512 --- This review has been submitted with commit eb0160d7682855b3f396

Re: Review Request: Set the properties action fom mainWindow actionCollection

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101076/#review3510 --- What is the status of this review? Has it been submitted? If yes

Re: Review Request: Dolphin details view optimization

> On March 10, 2011, 8:05 a.m., Peter Penz wrote: > > Thanks a lot for this good patch, please commit :-) Would also be great if > > this could be backported to 4.6.2. > > Peter Penz wrote: > I've committed the patch and backported it to 4.6. Samuel, can you close this as submitted? - Ch

Re: Review Request: Do not modify .fonts.conf when loading it. Now nothing is written before the user clicks apply or ok. Fixes Bug 105797.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101359/#review3507 --- This patch does not apply to current master. Can you recreate it

Re: Review Request: startkde.cmake should treat font dpi like kcontrol/krdb/krdb.cpp does

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101410/#review3505 --- The big problem with this patch is that the user interface only