Re: kdeinit (was: Summary from Buildsystem BoF at Desktop Summit)

2011-08-20 Thread Oswald Buddenhagen
On Tue, Aug 16, 2011 at 08:58:02PM +0200, Thiago Macieira wrote: frameworks (qt-based), applications and workspace, that sounds pretty much what the KDE Platform is. What are you excluding in your definition? kded, klauncher, kdeinit, kglobalaccel, kwallet? yes, among other things. kded's

Re: Review Request: Umpteenth try to fix KCharSelect crash

2011-08-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102263/#review5842 --- This review has been submitted with commit

Re: kdeinit (was: Summary from Buildsystem BoF at Desktop Summit)

2011-08-20 Thread Oswald Buddenhagen
On Tue, Aug 16, 2011 at 08:00:19PM +0100, John Layt wrote: On Tuesday 16 Aug 2011 15:55:57 Oswald Buddenhagen wrote: On Tue, Aug 16, 2011 at 03:40:22PM +0200, Albert Astals Cid wrote: So you are going to let a guy that has stated publicly that hates KDE where has he done that? and i

Re: Review Request: Avoid terminating a QThread in kio/kio/hostinfo.cpp

2011-08-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102238/#review5846 --- Starting and stopping threads all the time is much more

Re: kdeinit (was: Summary from Buildsystem BoF at Desktop Summit)

2011-08-20 Thread Oswald Buddenhagen
On Wed, Aug 17, 2011 at 11:03:44AM +0200, Aaron J. Seigo wrote: Ossi's email demonstrates an utter lack of understanding on his part as to what kdelibs is. errrm ... right. i hope you had enough time now to rethink that statement. ;) we do not control all (or even most) of the Linux OS

Re: kdeinit (was: Summary from Buildsystem BoF at Desktop Summit)

2011-08-20 Thread Thiago Macieira
On Saturday, 20 de August de 2011 10:02:31 Oswald Buddenhagen wrote: On Tue, Aug 16, 2011 at 08:58:02PM +0200, Thiago Macieira wrote: frameworks (qt-based), applications and workspace, that sounds pretty much what the KDE Platform is. What are you excluding in your definition? kded,

Re: Re: kdeinit (was: Summary from Buildsystem BoF at Desktop Summit)

2011-08-20 Thread Martin Gräßlin
On Saturday 20 August 2011 12:20:55 Thiago Macieira wrote: That I agree: klauncher is systemd for KDE only, so we should see about getting the same benefits from systemd instead. There are two drawbacks with that, though: 1) systemd will not likely ever run on non-Linux systems, not even

Re: kdeinit (was: Summary from Buildsystem BoF at Desktop Summit)

2011-08-20 Thread Oswald Buddenhagen
On Sat, Aug 20, 2011 at 12:20:55PM +0200, Thiago Macieira wrote: On Saturday, 20 de August de 2011 10:02:31 Oswald Buddenhagen wrote: kded's module activation is redundant with systemd. But not at all the same impact. Starting an application and negotiating its connection to D-Bus is

Re: kdeinit (was: Summary from Buildsystem BoF at Desktop Summit)

2011-08-20 Thread Thiago Macieira
On Saturday, 20 de August de 2011 14:11:32 Oswald Buddenhagen wrote: On Sat, Aug 20, 2011 at 12:20:55PM +0200, Thiago Macieira wrote: On Saturday, 20 de August de 2011 10:02:31 Oswald Buddenhagen wrote: kded's module activation is redundant with systemd. But not at all the same impact.

Re: Review Request: Avoid terminating a QThread in kio/kio/hostinfo.cpp

2011-08-20 Thread Dawit Alemayehu
On Aug. 20, 2011, 9:31 a.m., David Faure wrote: Starting and stopping threads all the time is much more wasteful than Albert's approach (which Thiago and I designed) where a single thread is being reused for all queries. And waiting 250ms doesn't seem efficient either. I don't

Re: Review Request: Handle focus in KUrlNavigator

2011-08-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102345/#review5855 --- This review has been submitted with commit

Re: Review Request: Handle focus in KUrlNavigator

2011-08-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102345/#review5856 --- This review has been submitted with commit

Re: Review Request: Handle focus in KUrlNavigator

2011-08-20 Thread Peter Penz
On Aug. 20, 2011, 3 p.m., Commit Hook wrote: This review has been submitted with commit ae3b7a48ec0e34ac64c5531ec45b1f898594898a by Peter Penz to branch KDE/4.7. Thanks for the update of the patch, it works nice now! I did some minor modifications (the button should not trigger the

Re: Review Request: Do not crash because a badly servicetype_profilerc is found

2011-08-20 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101914/ --- (Updated Aug. 20, 2011, 4:51 p.m.) Review request for kdelibs. Summary

Review Request: Don't hang when determining MIME type of corrupted files

2011-08-20 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102391/ --- Review request for kdelibs and David Faure. Summary --- If

kdeutils has migrated to git

2011-08-20 Thread Raphael Kubo da Costa
Hello there, kdeutils has (mostly) finished its migration to git. SVN now only holds MOVED_TO_GIT files which point to the git repositories. Each application (ark, filelight, kcalc, kcharselect, kfloppy, kgpg, kremotecontrol, ktimer, kwallet, printer-applet, superkaramba, sweeper) has its own

Re: kdeinit

2011-08-20 Thread Valentin Rusu
On 08/20/2011 02:11 PM, Oswald Buddenhagen wrote: A cross-desktop specification, but we still use kwallet. There's no reason to dump it in favour of another implementation. So I see no arguments at all in favour of dropping it -- in fact, I see more in keeping it. ksecretservice is a new

Re: kdeutils has migrated to git

2011-08-20 Thread Aaron J. Seigo
On Saturday, August 20, 2011 16:48:09 Raphael Kubo da Costa wrote: For now, I have created a scratch git repository with the files which used to be in the top-level kdeutils directory in SVN, so you can just use the CMakeLists.txt there to build everything (there are no inter-repository

Re: How to see the resolution of merge of KDE/4.7 into KF5

2011-08-20 Thread Nicolas Alvarez
Stephen Kelly wrote: I couldn't make git show me the conflicts. I tried git show, which surprises me as it shows a 3 way diff of a single file which was apparently not in conflict (full output at http://steveire.com/mergecommit). I also tried several variations of git diff

Re: kdeutils has migrated to git

2011-08-20 Thread Nicolas Alvarez
Aaron J. Seigo wrote: On Saturday, August 20, 2011 16:48:09 Raphael Kubo da Costa wrote: For now, I have created a scratch git repository with the files which used to be in the top-level kdeutils directory in SVN, so you can just use the CMakeLists.txt there to build everything (there are no

Re: kdeutils has migrated to git

2011-08-20 Thread Aaron J. Seigo
On Sunday, August 21, 2011 00:13:25 Nicolas Alvarez wrote: As I said in another thread: Superbuild is unrelated and orthogonal to the ability of the kdeutils buildsystem to allow building both as standalone apps and as a single module. see my reply in that other thread as to what superbuild