Re: Review Request: KActivities requires Soprano 2.7 to compile

2011-11-08 Thread Aaron J. Seigo
On Nov. 7, 2011, 3:56 p.m., Ralf Jung wrote: Any comment on this? The patch looks trivial, but I am still new to all this so I'd prefer if someone could confirm that KActivites can and should actually require Soprano 2.7. it builds here with 2.6.51. so 2.7 is not required, but perhaps

Re: New Feature for kdelibs (Was: The case for a kdelibs 4.8)

2011-11-08 Thread Aaron J. Seigo
On Monday, November 7, 2011 19:32:15 Dawit A wrote: Well this is over a month too late, but I have a enhancement change for kcookiejar that needs to go into kdelibs/kioslave for KDE 4.8. The patch has actually been pending for a merge since KDE 4.6. See

Re: Review request for KSecretsService components

2011-11-08 Thread Valentin Rusu
Hello Again, The freeze will come in less thant two days now and I'd like to know if anyone reviewed these components. Thanks, On 10/31/2011 11:48 PM, Valentin Rusu wrote: Hello, Please be advised three repostories need review before integration into the next release: 1.

Review Request: Fix crash when zombie taskbar buttons are left

2011-11-08 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103085/ --- Review request for KDE Runtime and Craig Drummond. Description ---

Re: Review Request: Fix crash when zombie taskbar buttons are left

2011-11-08 Thread Craig Drummond
On Nov. 8, 2011, 9:01 p.m., Craig Drummond wrote: Ship It! Really KSysGuard::ProcessesLocal::getParentPid should be fixed to not crash when passed pid of 0. Also, a similar fix will be needed in getServiceLauncherUrl - Craig ---

Re: Review Request: Fix crash when zombie taskbar buttons are left

2011-11-08 Thread Valentin Rusu
On Nov. 8, 2011, 9:01 p.m., Craig Drummond wrote: Ship It! Craig Drummond wrote: Really KSysGuard::ProcessesLocal::getParentPid should be fixed to not crash when passed pid of 0. Also, a similar fix will be needed in getServiceLauncherUrl Ok, I also fixed getServiceLauncherUrl