---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103226/#review8438
---
kfile/kdiroperator.cpp
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103226/#review8439
---
kfile/kdirselectdialog.cpp
(sorry Aaron for the duplicate, blame GMail)
2011/11/24 Aaron J. Seigo ase...@kde.org:
On Thursday, November 24, 2011 01:21:12 Dario Freddi wrote:
These capabilities used to be provided by HAL in the
10-usb-music-players.fdi file, but HAL is now deprecated, so the
information is being
On Wed, Nov 23, 2011 at 12:00 AM, Alex Fiestas afies...@kde.org wrote:
We're in the process of merging a review which will partly fix the sad
situation of MTP/MPI/iPod devices in libsolid, the review I'm talking about
is:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103212/#review8447
---
Please assign to the Solid team and Dario Freddi, he needs to
On Nov. 24, 2011, 8:37 a.m., Aaron J. Seigo wrote:
kfile/kdirselectdialog.cpp, line 102
http://git.reviewboard.kde.org/r/103226/diff/2/?file=41892#file41892line102
this should be a QWeakPointer. QPointer has significant overhead that
QWeakPointer avoids.
Actually there is no
On Nov. 24, 2011, 8:35 a.m., Aaron J. Seigo wrote:
KDirOperator is called from KFileWidget which is called from KFileDialog. Guess
what the parent-window() would give you in this case ? The KFileDialog because
it is the next valid ancestor widget that has a window-system frame. If we used
On 11/24/2011 01:21 AM, Dario Freddi wrote:
media-player-info is a repository of data files describing media
player capabilities, mostly of mass-storage devices. These files
contain information about the directory layout to use to add music to
these devices, the supported file formats and so on.
So, do have I have green light to give the ship it to this patch?
Thanks and sorry for the mess of me not explaining :p
El Dijous, 24 de novembre de 2011, a les 15:57:22, Alex Fiestas va escriure:
So, do have I have green light to give the ship it to this patch?
Thanks and sorry for the mess of me not explaining :p
From what i can see it is a bug fix, it changes some code in solid and will
not break horribly
On 11/24/2011 06:41 PM, Albert Astals Cid wrote:
So if you are fine living with copied code from somewhere else, go for it.
I'm not happy but I'm fine, better copy paste it than rewrite it just
for fun.
IIRC Qt5 will have this information.
Ship it!
2011/11/24 Alex Fiestas afies...@kde.org:
So, do have I have green light to give the ship it to this patch?
Thanks and sorry for the mess of me not explaining :p
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103226/
---
(Updated Nov. 24, 2011, 3:16 p.m.)
Review request for kdelibs and David
13 matches
Mail list logo
