Re: Review Request: Make it possible to login to 2 different sites from two separate instance of same application

2011-11-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103245/#review8616 --- This review has been submitted with commit

Re: Review Request: Make it possible to login to 2 different sites from two separate instance of same application

2011-11-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103245/#review8617 --- This review has been submitted with commit

Re: Review Request: Proper password caching when opening remote directories in KFileDialog

2011-11-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103226/#review8619 --- kdeui/jobs/kdialogjobuidelegate.cpp

Re: Review Request: Add git support to kdesdk: create_tarball.rb

2011-11-30 Thread Thomas Baumgart
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6842/#review10493 --- Test with the following settings in the config.ini here and ran

Re: Review Request: Fix KDateComboBox shrinking in size after a date is entered

2011-11-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103133/#review8622 --- This review has been submitted with commit

Review Request 101486 (Q/KComboBox related KConfigDialogManager change) breaks apps

2011-11-30 Thread Andreas Pakulat
Hi, just came around to notice this now, but the mentioned code-change from the review request: https://git.reviewboard.kde.org/r/101486/ actually does break apps. In particular it breaks kdevelop. We have a KComboBox subclass which actually wants to store a custom string-property into the

Re: Review Request: Add git support to kdesdk: create_tarball.rb

2011-11-30 Thread Kåre Särs
On Nov. 30, 2011, 6:01 p.m., Thomas Baumgart wrote: trunk/KDE/kdesdk/scripts/createtarball/create_tarball.rb, line 443 http://svn.reviewboard.kde.org/r/6842/diff/1/?file=47267#file47267line443 Is there a specific reason why you don't add the doc subdirectory for stuff fetched

Re: Review Request 101486 (Q/KComboBox related KConfigDialogManager change) breaks apps

2011-11-30 Thread Christoph Feck
On Wednesday 30 November 2011 21:50:41 Andreas Pakulat wrote: Hi, just came around to notice this now, but the mentioned code-change from the review request: https://git.reviewboard.kde.org/r/101486/ actually does break apps. In particular it breaks kdevelop. We have a KComboBox subclass

Re: Review Request: Fix Date Display in dolphin info panel

2011-11-30 Thread Sebastian Trueg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103300/#review8628 --- kio/kfile/kfilemetadatareaderprocess.cpp

Re: Review Request 101486 (Q/KComboBox related KConfigDialogManager change) breaks apps

2011-11-30 Thread Andreas Pakulat
On 30.11.11 22:06:12, Christoph Feck wrote: On Wednesday 30 November 2011 21:50:41 Andreas Pakulat wrote: Since nonetheless there's the case of breaking existing apps with this change, I'd like to check other peoples opinions on adding some more logic to the kconfigdialogmanager's code so

Re: Review Request: Proper password caching when opening remote directories in KFileDialog

2011-11-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103226/#review8634 --- This review has been submitted with commit