Re: Review Request: Add KFontDialog-setSampleText()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103357/#review9405 --- As far as i understand, this is new api and has to go into frameworks only, not 4.8 since that's basically just a bugfixed 4.7.x - Albert Astals Cid On Dec. 8, 2011, 4:11 a.m., Kurt Hindenburg wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103357/ --- (Updated Dec. 8, 2011, 4:11 a.m.) Review request for kdelibs. Description --- Currently there is no way to change the sample text in KFontDialog. I would like to change the sample text in Konsole to display characters that may appear similar in some fonts (iIlLoO0). Diffs - kdeui/fonts/kfontdialog.h 371345e kdeui/fonts/kfontdialog.cpp efd6a35 Diff: http://git.reviewboard.kde.org/r/103357/diff/diff Testing --- Compiled on master branch and testing in Konsole. Thanks, Kurt Hindenburg
Re: Review Request: Add KFontDialog-setSampleText()
I have a button that allows me to change the sample text in kfontview, KDE 4.7.4. In systemsettings font installer, I can rightclick the font view area and find a menu item to change the text in the context menu. On Torsdag den 8. december 2011, Kurt Hindenburg wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103357/ --- Review request for kdelibs. Description --- Currently there is no way to change the sample text in KFontDialog. I would like to change the sample text in Konsole to display characters that may appear similar in some fonts (iIlLoO0). Diffs - kdeui/fonts/kfontdialog.h 371345e kdeui/fonts/kfontdialog.cpp efd6a35 Diff: http://git.reviewboard.kde.org/r/103357/diff/diff Testing --- Compiled on master branch and testing in Konsole. Thanks, Kurt Hindenburg -- Anders
Re: Review Request: Add KFontDialog-setSampleText()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103357/#review9409 --- Using KDE 4.7.4 I can just click and type there. - Anders Lund On Dec. 8, 2011, 4:11 a.m., Kurt Hindenburg wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103357/ --- (Updated Dec. 8, 2011, 4:11 a.m.) Review request for kdelibs. Description --- Currently there is no way to change the sample text in KFontDialog. I would like to change the sample text in Konsole to display characters that may appear similar in some fonts (iIlLoO0). Diffs - kdeui/fonts/kfontdialog.h 371345e kdeui/fonts/kfontdialog.cpp efd6a35 Diff: http://git.reviewboard.kde.org/r/103357/diff/diff Testing --- Compiled on master branch and testing in Konsole. Thanks, Kurt Hindenburg
Re: Review Request: Add KFontDialog-setSampleText()
On Jan. 1, 2012, 5:16 p.m., Anders Lund wrote: Using KDE 4.7.4 I can just click and type there. Thomas Lübking wrote: I guess it's by more about defaults, since the technical use of fonts has other demands (unambiguity) than the regular one (pretty) which the regular user however might not implicitly be aware of. I hope the option to get a view of the font is not limited to technicalities. For many people general readability and asteathics are important parameters as well! And the problem with iIlLoO0 could be considered important for general font usage too. - Anders --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103357/#review9409 --- On Dec. 8, 2011, 4:11 a.m., Kurt Hindenburg wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103357/ --- (Updated Dec. 8, 2011, 4:11 a.m.) Review request for kdelibs. Description --- Currently there is no way to change the sample text in KFontDialog. I would like to change the sample text in Konsole to display characters that may appear similar in some fonts (iIlLoO0). Diffs - kdeui/fonts/kfontdialog.h 371345e kdeui/fonts/kfontdialog.cpp efd6a35 Diff: http://git.reviewboard.kde.org/r/103357/diff/diff Testing --- Compiled on master branch and testing in Konsole. Thanks, Kurt Hindenburg
Re: Review Request: Add KFontDialog-setSampleText()
On Jan. 1, 2012, 2:49 p.m., Albert Astals Cid wrote: As far as i understand, this is new api and has to go into frameworks only, not 4.8 since that's basically just a bugfixed 4.7.x Thomas Lübking wrote: can interim be easily compensated by QListKFontChooser* chooserList = myDialog-findChildrenKFontChooser*(); if (!chooserList.isEmpty()) chooserList.at(0)-setSampleText(iIlLoO0); Thanks for this - I'll use it in the mean time. - Kurt --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103357/#review9405 --- On Dec. 8, 2011, 4:11 a.m., Kurt Hindenburg wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103357/ --- (Updated Dec. 8, 2011, 4:11 a.m.) Review request for kdelibs. Description --- Currently there is no way to change the sample text in KFontDialog. I would like to change the sample text in Konsole to display characters that may appear similar in some fonts (iIlLoO0). Diffs - kdeui/fonts/kfontdialog.h 371345e kdeui/fonts/kfontdialog.cpp efd6a35 Diff: http://git.reviewboard.kde.org/r/103357/diff/diff Testing --- Compiled on master branch and testing in Konsole. Thanks, Kurt Hindenburg
Re: Review Request: Add KFontDialog-setSampleText()
On Jan. 1, 2012, 5:16 p.m., Anders Lund wrote: Using KDE 4.7.4 I can just click and type there. Thomas Lübking wrote: I guess it's by more about defaults, since the technical use of fonts has other demands (unambiguity) than the regular one (pretty) which the regular user however might not implicitly be aware of. Anders Lund wrote: I hope the option to get a view of the font is not limited to technicalities. For many people general readability and asteathics are important parameters as well! And the problem with iIlLoO0 could be considered important for general font usage too. I'm not quite sure what limitations you fear - the option to change the string is not to be touched, neither is the global default one. The driving aspect of this particular case is to have a usable monospace font - and how many fonts with variable width do you know which slash the 0? Code and shell requirements differ a lot from regular font quality aspects, eg. monospace is usually a braindead idea if you care about readability and there have always been flamewars on the best monospaced font while it should actually be the least crap one. This here only covers the issue that there're quite some monospaces which look great at first sight - but then fail on I == l or 0 == O or not being monospaced across weights (what means you cannot use bold glyphs for keywords) Therefore Kurt wants to use a very special string to stress this in Konsole's font dialog. Kate may pick this up, but elsewhere you're far better done with the fox or lorem ipsum. @Kurt: maybe also add |1!o? - Thomas --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103357/#review9409 --- On Dec. 8, 2011, 4:11 a.m., Kurt Hindenburg wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103357/ --- (Updated Dec. 8, 2011, 4:11 a.m.) Review request for kdelibs. Description --- Currently there is no way to change the sample text in KFontDialog. I would like to change the sample text in Konsole to display characters that may appear similar in some fonts (iIlLoO0). Diffs - kdeui/fonts/kfontdialog.h 371345e kdeui/fonts/kfontdialog.cpp efd6a35 Diff: http://git.reviewboard.kde.org/r/103357/diff/diff Testing --- Compiled on master branch and testing in Konsole. Thanks, Kurt Hindenburg
Review Request: KOpenWithDialog: Quote paths selected in the file dialog
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103602/ --- Review request for kdelibs. Description --- KOpenWithDialog expects the input in its line edit to be shell-quoted. Currently, however, when the user picks a path via the provided file dialog, whitespace and other special characters in the path are inserted verbatim. This leads to an error when the user tries to select an executable whose path contains such characters. This tiny patch addresses the issue by adding a private slot that runs all paths coming from the file dialog through KShell::quoteArg(). I believe this solution is better than the one I originally proposed in the linked bug report, since it avoids the ambiguity of having to guess whether whitespace belongs to the path or an argument to the executable. This addresses bug 281952. http://bugs.kde.org/show_bug.cgi?id=281952 Diffs - kio/kfile/kopenwithdialog.h 86c02ab kio/kfile/kopenwithdialog.cpp b5ebbbf Diff: http://git.reviewboard.kde.org/r/103602/diff/diff Testing --- Thanks, Ingomar Wesp
Re: Review Request: KOpenWithDialog: Quote paths selected in the file dialog
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103602/#review9417 --- Why the need for a new slot that connects to urlChanged ? Would simply quoting the user selected text in KOpenWithDialog::slotSelected not suffice ? - Dawit Alemayehu On Jan. 1, 2012, 9:49 p.m., Ingomar Wesp wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103602/ --- (Updated Jan. 1, 2012, 9:49 p.m.) Review request for kdelibs. Description --- KOpenWithDialog expects the input in its line edit to be shell-quoted. Currently, however, when the user picks a path via the provided file dialog, whitespace and other special characters in the path are inserted verbatim. This leads to an error when the user tries to select an executable whose path contains such characters. This tiny patch addresses the issue by adding a private slot that runs all paths coming from the file dialog through KShell::quoteArg(). I believe this solution is better than the one I originally proposed in the linked bug report, since it avoids the ambiguity of having to guess whether whitespace belongs to the path or an argument to the executable. This addresses bug 281952. http://bugs.kde.org/show_bug.cgi?id=281952 Diffs - kio/kfile/kopenwithdialog.h 86c02ab kio/kfile/kopenwithdialog.cpp b5ebbbf Diff: http://git.reviewboard.kde.org/r/103602/diff/diff Testing --- Thanks, Ingomar Wesp
Can we please have an updated and confirmed working build KDE from source as separate user?
Hi, The current kdesrc-build knowledgebase article is incomplete and missing quite a few things to get everything working. Asking this because today i, yet again, wasted a dozen hours getting KDE to run from git under a separate user. There isn't a good description for what needs to be placed in .bashrc and .profile and/or .bash_profile. Where i ended at this moment is the odd thing that dolphin (and all kde apps) crash when i run them from the desktop : http://paste.kde.org/180236/ but runs when running from the command line. I have everything in .profile: http://paste.kde.org/180230/ after a million relogs, a couple dozen times removing my .config (thus also Trolltech.conf) and rebooting in case of libs and configs still in memory.. Yeah, that gets frustrating after a few hours. This is what the (to be created) wiki page should tell the user: 1 - the steps to create a new user 2 - setting up the environment (can't help there since my environment seems to be wrong somewhere) 3 - setting up kdesrc-build 4 - building the minimum required apps to have KDE running (no games, edu tools.. just the bare minimum with a working desktop environment) 5 - updating All other related pages should be deleted or link to the new one to avoid confusion like which page do i need to have?. I can write down step 1 :) And please, if this is complete again.. PLEASE just keep it updated! It's taking so much time right now to just get it running. If you even get it running. Kind regards and happy new year! Mark
Re: Can we please have an updated and confirmed working build KDE from source as separate user?
Honestly, running a separate user for it just makes everything more a pain than it should be.The better way is to just run it under your user but use different environment variables when you want to run master apps. Your crash is likely caused by the fact that you attempted to run an application (Dolphin) from master, yet it was still using the $QTDIR from /usr/.., in other words probably too old. I just have a command, runmaster which switches the current shell to one that has all the environment vars setup to run a compiled application. This way I can have a stable desktop, and run and test things from master manually and whenever I want to. Actually, yes, I see that your QTDIR is pointing to /usr. That is incorrect for building from source. Truly, I recommend not going the separate user route, that's sort of why it's not well documented. Mostly because it shouldn't be used..in fact, I even added it somewhere a long time ago saying that other methods are better than a separate user (no idea if it's there or not, some people go too crazy on wiki edits and don't preserve enough past info). -- Shaun Reich, KDE Software Developer (kde.org)
Re: Review Request: KOpenWithDialog: Quote paths selected in the file dialog
On Jan. 1, 2012, 11:08 p.m., Dawit Alemayehu wrote: Why the need for a new slot that connects to urlChanged ? Would simply quoting the user selected text in KOpenWithDialog::slotSelected not suffice ? AFAICS, KOpenWithDialog::slotSelected is used for setting the contents of the line edit when picking an item from the KApplicationView rather than the file dialog. Unlike the paths returned by the file dialog, these should already be properly quoted. - Ingomar --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103602/#review9417 --- On Jan. 1, 2012, 9:49 p.m., Ingomar Wesp wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103602/ --- (Updated Jan. 1, 2012, 9:49 p.m.) Review request for kdelibs. Description --- KOpenWithDialog expects the input in its line edit to be shell-quoted. Currently, however, when the user picks a path via the provided file dialog, whitespace and other special characters in the path are inserted verbatim. This leads to an error when the user tries to select an executable whose path contains such characters. This tiny patch addresses the issue by adding a private slot that runs all paths coming from the file dialog through KShell::quoteArg(). I believe this solution is better than the one I originally proposed in the linked bug report, since it avoids the ambiguity of having to guess whether whitespace belongs to the path or an argument to the executable. This addresses bug 281952. http://bugs.kde.org/show_bug.cgi?id=281952 Diffs - kio/kfile/kopenwithdialog.h 86c02ab kio/kfile/kopenwithdialog.cpp b5ebbbf Diff: http://git.reviewboard.kde.org/r/103602/diff/diff Testing --- Thanks, Ingomar Wesp
Re: Can we please have an updated and confirmed working build KDE from source as separate user?
You load the oxygen style plugin from here: /usr/lib/kde4/plugins/styles/oxygen.so while it should apparently be: ~/kde/lib/kde4/plugins Since you can run applications from textshells this means your ~/.profile is not invoked by kdm or whatever sets up the session for you - put the exports somewhere into ~/.kde/env For the rest, I've frankly not even an idea what you're talking about - i wasn't even aware there's some sort of kdesrc-build knowledgebase article. Sorry, can't help any further :-( -- Cheers, Thomas Am 02.01.2012, 00:49 Uhr, schrieb Mark mark...@gmail.com: Hi, The current kdesrc-build knowledgebase article is incomplete and missing quite a few things to get everything working. Asking this because today i, yet again, wasted a dozen hours getting KDE to run from git under a separate user. There isn't a good description for what needs to be placed in .bashrc and .profile and/or .bash_profile. Where i ended at this moment is the odd thing that dolphin (and all kde apps) crash when i run them from the desktop : http://paste.kde.org/180236/ but runs when running from the command line. I have everything in .profile: http://paste.kde.org/180230/ after a million relogs, a couple dozen times removing my .config (thus also Trolltech.conf) and rebooting in case of libs and configs still in memory.. Yeah, that gets frustrating after a few hours. This is what the (to be created) wiki page should tell the user: 1 - the steps to create a new user 2 - setting up the environment (can't help there since my environment seems to be wrong somewhere) 3 - setting up kdesrc-build 4 - building the minimum required apps to have KDE running (no games, edu tools.. just the bare minimum with a working desktop environment) 5 - updating All other related pages should be deleted or link to the new one to avoid confusion like which page do i need to have?. I can write down step 1 :) And please, if this is complete again.. PLEASE just keep it updated! It's taking so much time right now to just get it running. If you even get it running. Kind regards and happy new year! Mark
Re: Can we please have an updated and confirmed working build KDE from source as separate user?
On Sun, Jan 1, 2012 at 7:19 PM, Thomas Lübking thomas.luebk...@gmail.com wrote: Since you can run applications from textshells this means your ~/.profile is not invoked by kdm or whatever sets up the session for you - put the exports somewhere into ~/.kde/env Right, good point. Another way that you may want to try is making your own ~/.xsessionrc (believe that's the name), which sets up the variables appropriately. Then you can go into kdm under your regular user, select the session type, (Custom for your master session, or kde4(for your distro one)). The way I see it, the best methods are as follows: They're technically mutually exclusive... (0) Run KDE master as your main session. Obviously this has some problems if this is a production machine. But I've used it for a while (not currently though, because I'm trying not to ;) (1) Run KDE from your distro as usual, when you want to run master applications, open a shell and run the function runmaster, which is just a function on my system which exports the proper vars for that one shell. It makes things quite convenient, you can even run plasma-desktop from it, provided you kill your main one for a bit. In fact, that's how I currently test plasma-desktop changes of mine. I'll give you the shell snippet if you are interested. These options are meant for one user. But of course you can use more than one user...I just don't see the point, it ends up with some very hairy issues. e.g. I had to set proper ACL's for it, so I could edit source files and have the proper perms to go to and fro. -- Shaun Reich, KDE Software Developer (kde.org)
Changing HEAD in kdelibs.git
Does anyone object to sysadmin changing HEAD in kdelibs.git to point to the 4.8 branch, so that a simple clone of the repo results in a checkout of that branch? With kdelibs master being outdated the master branches of our other modules may not build against it (e.g. kde-workspace currently won't build against kdelibs master or the 4.7 branch due to relying on a new enum value) and we have tons of outdated build documentation that makes no mention of master not being good enough. For that matter, even if someone had taken care to document the need to checkout 4.7 after clone, I'm willing to bet it wouldn't have been updated now that plans have changed and we actually made a 4.8 branch (I just fixed the kde- src-build sample config because it hadn't been up- dated yet). -- Best regards, Eike Hein
